Re: [PATCH v1 0/5] Adds media driver for Sony IMX492 sensor

Kieran Bingham
2022-11-28T12:46:37Z

Hi Petko,

What device/ISP are you testing this sensor on?

Quoting Petko Manolov (2022-11-25 15:31:15)
> This patch adds dt-bindings documentation, driver source, etc for Sony imx492
> image sensor.
>
> imx492 is a diagonal 23.1 mm (Type 1.4) CMOS image sensor with color or
> monochrome square pixel array and approximately 47.08 M effective pixels. 12-bit
> digital output makes it possible to output the signals with high definition for
> moving pictures. It is programmable through I2C interface. The I2C client
> address can be either 0x10 or 0x1a depending on SLASEL pin. Image data is sent
> through MIPI CSI-2.
>
> Petko Manolov (5):
> DT bindings for imx492
> media: i2c: imx492: driver's header
> media: i2c: imx492: driver's source
> media: i2c: add imx492 config entry
> media: i2c: add imx492 entry for make

Could you squash patches 2, 3, 4, and 5 into a single patch please?

Also - I think you'll need an entry in MAINTAINERS.

I can't see any reference to the selection controls:
- V4L2_SEL_TGT_CROP_DEFAULT
- V4L2_SEL_TGT_CROP
- V4L2_SEL_TGT_CROP_BOUNDS

Do you have the datasheet or sufficient information to be able to
implement these controls?

--
Kieran

> .../bindings/media/i2c/sony,imx492.yaml | 101 ++
> drivers/media/i2c/Kconfig | 14 +
> drivers/media/i2c/Makefile | 1 +
> drivers/media/i2c/imx492.c | 1092 +++++++++++++++++
> drivers/media/i2c/imx492.h | 555 +++++++++
> 5 files changed, 1763 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx492.yaml
> create mode 100644 drivers/media/i2c/imx492.c
> create mode 100644 drivers/media/i2c/imx492.h
>
> --
> 2.30.2
>