From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81BDAC47089 for ; Tue, 29 Nov 2022 12:37:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234126AbiK2Mhf (ORCPT ); Tue, 29 Nov 2022 07:37:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230128AbiK2Mhd (ORCPT ); Tue, 29 Nov 2022 07:37:33 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E458D5D6B7; Tue, 29 Nov 2022 04:37:30 -0800 (PST) X-IronPort-AV: E=McAfee;i="6500,9779,10545"; a="316232950" X-IronPort-AV: E=Sophos;i="5.96,203,1665471600"; d="scan'208";a="316232950" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2022 04:35:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10545"; a="643767060" X-IronPort-AV: E=Sophos;i="5.96,203,1665471600"; d="scan'208";a="643767060" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 29 Nov 2022 04:35:54 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ozzq4-001hcv-0M; Tue, 29 Nov 2022 14:35:52 +0200 Date: Tue, 29 Nov 2022 14:35:51 +0200 From: Andy Shevchenko To: Hans de Goede Cc: Mark Gross , Bartosz Golaszewski , Linus Walleij , Daniel Scally , Laurent Pinchart , platform-driver-x86@vger.kernel.org, linux-gpio@vger.kernel.org, Sakari Ailus , Kate Hsuan , linux-media@vger.kernel.org Subject: Re: [PATCH 3/5] gpio: tps68470: Add support for the indicator LED outputs Message-ID: References: <20221128214408.165726-1-hdegoede@redhat.com> <20221128214408.165726-4-hdegoede@redhat.com> <007a6345-62e7-20ee-1a48-4adb4a9fa9df@redhat.com> <1940674f-84fc-e5c9-59c6-0e6389c9d285@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1940674f-84fc-e5c9-59c6-0e6389c9d285@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Tue, Nov 29, 2022 at 01:20:03PM +0100, Hans de Goede wrote: > On 11/29/22 12:59, Andy Shevchenko wrote: ... > I'm sorry, but just like with your comments on patch 1/3 > I really don't see the problem here. Unlike "dir" or "out_or_in" > get is a perfectly fine parameter name which is actually clearly > defined by the parameter-name itself. > > And the function + the callers are all in the same file, so > anyone reading the code can easily deduce the meaning from > the code. OK. I'm not insisting, it's a bikeshedding anyway. -- With Best Regards, Andy Shevchenko