From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4923C4332F for ; Thu, 15 Dec 2022 01:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229661AbiLOBPB (ORCPT ); Wed, 14 Dec 2022 20:15:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229588AbiLOBO7 (ORCPT ); Wed, 14 Dec 2022 20:14:59 -0500 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 992E6554F3 for ; Wed, 14 Dec 2022 17:14:58 -0800 (PST) Received: by mail-pl1-x62f.google.com with SMTP id 17so5318909pll.0 for ; Wed, 14 Dec 2022 17:14:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zL+Tdk+zCs8TNT7g6HIaDXRKNhigXeKBHzTFkpkj2gI=; b=UapGBTztJgPfjtfzXdgNAR9cPneWdf2FVDpFiB7Ypqb05B/VgDq/V/llETgCRqnXWE zIgINj2kFsj4glPxOBDilt3SXxhzkEsbyKJNDAkTEmJ0OSHqfjMEeO5mc6uv16xCf8EC vAuEHiWTdh8X4XdRNCQrfRzZ3o0XwAtRBgL/o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zL+Tdk+zCs8TNT7g6HIaDXRKNhigXeKBHzTFkpkj2gI=; b=vUk33qPUMgBcyIcIeXlUVSXfqJNd6BeCwxmGKgxGRXZPYMc0rQmR3XzdJAmKDDsITI c6+SYqtElDOWIg6x7X9i7uC89rPs6j0kH2pJCMeQmu9C/zvJGXVDqkddP/AHr8GUN7OF V3G09K9c68UuEb0Yo0z3wuu+W8B4TteafV3ImhKI4+/mN0adASBf04h5dX5RAoMHdIJg G6aJ/AmqpRj6jQOPw/dAHAiUqRTxYoLjc+ii6jGXjBIhAY5nzkGNL8YBxMVrUwJbEepU wm3qG/rWv+SgihGnN7J9XAWjB0iZNZciuxmt4zyHlPe3WLjdDM6/kqM6aLPdSzvNB1uB VJtA== X-Gm-Message-State: ANoB5pl3mgZi3mij5P9mvRPaGp/5vnt3YDOi12vqx1TW5wLKxjd6C9ex tazMAnujEpOXEAfFlaETplHcbg== X-Google-Smtp-Source: AA0mqf4dzoANwHiq9DDjTNy8sJ66CZ8Ke5Yjs7gvMynAYN7lBFOtJ+6+OdroCuy2+6wLko9U2Hdq/A== X-Received: by 2002:a05:6a20:9c89:b0:9d:efbf:7876 with SMTP id mj9-20020a056a209c8900b0009defbf7876mr31924066pzb.43.1671066898121; Wed, 14 Dec 2022 17:14:58 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id a10-20020aa794aa000000b00576df4543d4sm429133pfl.166.2022.12.14.17.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 17:14:57 -0800 (PST) Date: Thu, 15 Dec 2022 10:14:53 +0900 From: Sergey Senozhatsky To: Ricardo Ribalda Cc: Yunke Cao , Ming Lei , Jonathan Cameron , Laurent Pinchart , Mauro Carvalho Chehab , Max Staudt , Sergey Senozhatsky , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v2] media: uvcvideo: Do not alloc dev->status Message-ID: References: <20221214-uvc-status-alloc-v2-0-3f1cba6fc734@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221214-uvc-status-alloc-v2-0-3f1cba6fc734@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On (22/12/14 14:37), Ricardo Ribalda wrote: [..] > +struct uvc_status_streaming { > + u8 button; > +} __packed; > + > +struct uvc_status_control { > + u8 bSelector; > + u8 bAttribute; > + u8 bValue[11]; > +} __packed; > + > +struct uvc_status { > + u8 bStatusType; > + u8 bOriginator; > + u8 bEvent; > + union { > + struct uvc_status_control control; > + struct uvc_status_streaming streaming; > + }; > +} __packed; > + > struct uvc_device { > struct usb_device *udev; > struct usb_interface *intf; > @@ -559,7 +579,7 @@ struct uvc_device { > /* Status Interrupt Endpoint */ > struct usb_host_endpoint *int_ep; > struct urb *int_urb; > - u8 *status; > + > struct input_dev *input; > char input_phys[64]; > > @@ -572,6 +592,12 @@ struct uvc_device { > } async_ctrl; > > struct uvc_entity *gpio_unit; > + > + /* > + * Ensure that status is aligned, making it safe to use with > + * non-coherent DMA. > + */ > + struct uvc_status status __aligned(ARCH_KMALLOC_MINALIGN); ____cacheline_aligned ? I don't see anyone using ARCH_KMALLOC_MINALIGN except for slab.h