From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52E75C67871 for ; Wed, 11 Jan 2023 09:54:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238800AbjAKJyV (ORCPT ); Wed, 11 Jan 2023 04:54:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235993AbjAKJxo (ORCPT ); Wed, 11 Jan 2023 04:53:44 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF3A5D109; Wed, 11 Jan 2023 01:51:27 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9221EB81B76; Wed, 11 Jan 2023 09:51:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54F6DC433F1; Wed, 11 Jan 2023 09:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673430685; bh=z0ZYgHqL1YLvYl+ue5zNy1KMy+u3shk6BmiAvHiQZSA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xZGcZ5JDRrdXTJbt9tLPDzh24ToBaCeG04aIrg63SxaV0mqioT6pGZXGHiVeh9ZOU sO0JuLfJTFUVrJVMPgoU9Fwio7tkoa1uh4VeY/xzIKAbqvAAsfPDw+kuuk3E42lxBv sJ9yu85to26aoTWWeVLBJDsI3mtwYFGQ3RchmYyA= Date: Wed, 11 Jan 2023 10:51:22 +0100 From: Greg Kroah-Hartman To: "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, Jens Axboe , Len Brown , Stefan Richter , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Sean Young , Mauro Carvalho Chehab , Rob Herring , Frank Rowand , Maximilian Luz , Hans de Goede , Mark Gross , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , Jiri Slaby , Heikki Krogerus , "Matthew Wilcox (Oracle)" , "Martin K. Petersen" , Chaitanya Kulkarni , Ming Lei , Jilin Yuan , Alan Stern , Andy Shevchenko , Sakari Ailus , Jason Gunthorpe , Thomas Gleixner , Ira Weiny , Dan Williams , Won Chung , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-block@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux1394-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 3/5] driver core: make struct device_type.uevent() take a const * Message-ID: References: <20221123122523.1332370-1-gregkh@linuxfoundation.org> <20221123122523.1332370-3-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, Nov 23, 2022 at 01:38:05PM +0100, Rafael J. Wysocki wrote: > On Wed, Nov 23, 2022 at 1:25 PM Greg Kroah-Hartman > wrote: > > > > The uevent() callback in struct device_type should not be modifying the > > device that is passed into it, so mark it as a const * and propagate the > > function signature changes out into all relevant subsystems that use > > this callback. > > > > Cc: Jens Axboe > > Cc: "Rafael J. Wysocki" > > Cc: Len Brown > > Cc: Stefan Richter > > Cc: Wolfram Sang > > Cc: Alexandre Belloni > > Cc: Dmitry Torokhov > > Cc: Sean Young > > Cc: Mauro Carvalho Chehab > > Cc: Rob Herring > > Cc: Frank Rowand > > Cc: Maximilian Luz > > Cc: Hans de Goede > > Cc: Mark Gross > > Cc: Vinod Koul > > Cc: Bard Liao > > Cc: Pierre-Louis Bossart > > Cc: Sanyog Kale > > Cc: Andreas Noever > > Cc: Michael Jamet > > Cc: Mika Westerberg > > Cc: Yehezkel Bernat > > Cc: Jiri Slaby > > Cc: Heikki Krogerus > > Cc: "Matthew Wilcox (Oracle)" > > Cc: "Martin K. Petersen" > > Cc: Chaitanya Kulkarni > > Cc: Ming Lei > > Cc: Jilin Yuan > > Cc: Alan Stern > > Cc: Andy Shevchenko > > Cc: Sakari Ailus > > Cc: Jason Gunthorpe > > Cc: Thomas Gleixner > > Cc: Ira Weiny > > Cc: Dan Williams > > Cc: Won Chung > > Cc: alsa-devel@alsa-project.org > > Cc: devicetree@vger.kernel.org > > Cc: linux-acpi@vger.kernel.org > > Cc: linux-block@vger.kernel.org > > Cc: linux-i2c@vger.kernel.org > > Cc: linux-i3c@lists.infradead.org > > Cc: linux-input@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: linux-media@vger.kernel.org > > Cc: linux-serial@vger.kernel.org > > Cc: linux-usb@vger.kernel.org > > Cc: linux1394-devel@lists.sourceforge.net > > Cc: platform-driver-x86@vger.kernel.org > > Signed-off-by: Greg Kroah-Hartman > > Acked-by: Rafael J. Wysocki > > (which my ACPI maintainer hat on). thanks for the review, I'll add it to the v2 patch. greg k-h