Re: [PATCH 1/8] media: dt-bindings: media: fsl-pxp: convert to yaml

Krzysztof Kozlowski
2023-01-06T12:34:38Z

On 05/01/2023 14:47, Michael Tretter wrote:
> Convert the bindings of the Freescale Pixel Pipeline to YAML.
>
> The conversion drops the previously listed compatibles for several SoCs.
> It is unclear, if the PXP on these SoCs is compatible to any of the PXPs
> on the existing SoCs and would allow to reuse the already defined
> compatibles. The missing compatibles should be brought back when the
> support for the PXP on these SoCs is added.
>

Subject: only one "media" prefix.

> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> .../bindings/media/fsl,imx6ull-pxp.yaml | 62 +++++++++++++++++++
> .../devicetree/bindings/media/fsl-pxp.txt | 26 --------
> 2 files changed, 62 insertions(+), 26 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml
> delete mode 100644 Documentation/devicetree/bindings/media/fsl-pxp.txt
>
> diff --git a/Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml b/Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml
> new file mode 100644
> index 000000000000..e5f227b84759
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/media/fsl,imx6ull-pxp.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

Drop qyotes from both.

> +
> +title: Freescale Pixel Pipeline
> +
> +maintainers:
> + - Philipp Zabel <p.zabel@pengutronix.de>
> + - Michael Tretter <m.tretter@pengutronix.de>
> +
> +description:
> + The Pixel Pipeline (PXP) is a memory-to-memory graphics processing engine
> + that supports scaling, colorspace conversion, alpha blending, rotation, and
> + pixel conversion via lookup table. Different versions are present on various
> + i.MX SoCs from i.MX23 to i.MX7.
> +
> +properties:
> + compatible:
> + enum:
> + - fsl,imx6ul-pxp
> + - fsl,imx6ull-pxp
> + - fsl,imx7d-pxp
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + minItems: 1
> + maxItems: 2
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: axi
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names

Add allOf:if:then restricting interrupts per variant.

> +
> +additionalProperties: False
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/imx6ul-clock.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +

Best regards,
Krzysztof