Re: [PATCH 1/8] media: dt-bindings: media: fsl-pxp: convert to yaml

Michael Tretter
2023-01-06T08:23:55Z

On Thu, 05 Jan 2023 21:18:21 -0600, Rob Herring wrote:
> On Thu, 05 Jan 2023 14:47:22 +0100, Michael Tretter wrote:
> > Convert the bindings of the Freescale Pixel Pipeline to YAML.
> >
> > The conversion drops the previously listed compatibles for several SoCs.
> > It is unclear, if the PXP on these SoCs is compatible to any of the PXPs
> > on the existing SoCs and would allow to reuse the already defined
> > compatibles. The missing compatibles should be brought back when the
> > support for the PXP on these SoCs is added.
> >
> > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> > ---
> > .../bindings/media/fsl,imx6ull-pxp.yaml | 62 +++++++++++++++++++
> > .../devicetree/bindings/media/fsl-pxp.txt | 26 --------
> > 2 files changed, 62 insertions(+), 26 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml
> > delete mode 100644 Documentation/devicetree/bindings/media/fsl-pxp.txt
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.

I am surprised that these warnings didn't show up when I ran 'make
dtbs_check'. I will check if there is something wrong with my setup.

>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230105134729.59542-2-m.tretter@pengutronix.de
>
>
> pxp@20f0000: compatible:0: 'fsl,imx6sll-pxp' is not one of ['fsl,imx6ul-pxp', 'fsl,imx6ull-pxp', 'fsl,imx7d-pxp']
> arch/arm/boot/dts/imx6sll-evk.dtb
> arch/arm/boot/dts/imx6sll-kobo-clarahd.dtb
> arch/arm/boot/dts/imx6sll-kobo-librah2o.dtb
>
> pxp@20f0000: compatible: ['fsl,imx6sll-pxp', 'fsl,imx6ull-pxp'] is too long
> arch/arm/boot/dts/imx6sll-evk.dtb
> arch/arm/boot/dts/imx6sll-kobo-clarahd.dtb
> arch/arm/boot/dts/imx6sll-kobo-librah2o.dtb

This is an error in the schema. I dropped the fsl,imx6sll-pxp and
fsl,imx6sx-pxp compatibles, because I thought that they aren't used.

I will send a v2 to fix the schema.

Michael

>
> pxp@2218000: compatible:0: 'fsl,imx6sx-pxp' is not one of ['fsl,imx6ul-pxp', 'fsl,imx6ull-pxp', 'fsl,imx7d-pxp']
> arch/arm/boot/dts/imx6sx-nitrogen6sx.dtb
> arch/arm/boot/dts/imx6sx-sabreauto.dtb
> arch/arm/boot/dts/imx6sx-sdb.dtb
> arch/arm/boot/dts/imx6sx-sdb-mqs.dtb
> arch/arm/boot/dts/imx6sx-sdb-reva.dtb
> arch/arm/boot/dts/imx6sx-sdb-sai.dtb
> arch/arm/boot/dts/imx6sx-softing-vining-2000.dtb
> arch/arm/boot/dts/imx6sx-udoo-neo-basic.dtb
> arch/arm/boot/dts/imx6sx-udoo-neo-extended.dtb
> arch/arm/boot/dts/imx6sx-udoo-neo-full.dtb
>
> pxp@2218000: compatible: ['fsl,imx6sx-pxp', 'fsl,imx6ull-pxp'] is too long
> arch/arm/boot/dts/imx6sx-nitrogen6sx.dtb
> arch/arm/boot/dts/imx6sx-sabreauto.dtb
> arch/arm/boot/dts/imx6sx-sdb.dtb
> arch/arm/boot/dts/imx6sx-sdb-mqs.dtb
> arch/arm/boot/dts/imx6sx-sdb-reva.dtb
> arch/arm/boot/dts/imx6sx-sdb-sai.dtb
> arch/arm/boot/dts/imx6sx-softing-vining-2000.dtb
> arch/arm/boot/dts/imx6sx-udoo-neo-basic.dtb
> arch/arm/boot/dts/imx6sx-udoo-neo-extended.dtb
> arch/arm/boot/dts/imx6sx-udoo-neo-full.dtb
>
> pxp@2218000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm/boot/dts/imx6sx-nitrogen6sx.dtb
> arch/arm/boot/dts/imx6sx-sabreauto.dtb
> arch/arm/boot/dts/imx6sx-sdb.dtb
> arch/arm/boot/dts/imx6sx-sdb-mqs.dtb
> arch/arm/boot/dts/imx6sx-sdb-reva.dtb
> arch/arm/boot/dts/imx6sx-sdb-sai.dtb
> arch/arm/boot/dts/imx6sx-softing-vining-2000.dtb
> arch/arm/boot/dts/imx6sx-udoo-neo-basic.dtb
> arch/arm/boot/dts/imx6sx-udoo-neo-extended.dtb
> arch/arm/boot/dts/imx6sx-udoo-neo-full.dtb
>
>