From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F417C54EBD for ; Fri, 6 Jan 2023 18:40:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235088AbjAFSkl (ORCPT ); Fri, 6 Jan 2023 13:40:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbjAFSki (ORCPT ); Fri, 6 Jan 2023 13:40:38 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60CB77CDD1; Fri, 6 Jan 2023 10:40:37 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E490F4AE; Fri, 6 Jan 2023 19:40:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1673030436; bh=3er2QCt7AsH/h645OXE2gqWnwW8MqKxptC8Ybn5tVBg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R+ZAwj6m55dKvcF62/Arqjt2v6FMjIlpKJIVRefwxZxRDK9zRWsXEQqWtvHsQEbcg ekDjliuT73PdS3GW6Ko/BrGgkcyTNNfKlk8gTqgQFOqGTCFNI93+i6qr/DtN+7B+wL 1damDELi11TqJ23/aFhAjoUJNT+D9SSjKc1Cu6AY= Date: Fri, 6 Jan 2023 20:40:31 +0200 From: Laurent Pinchart To: Michael Tretter Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/8] media: imx-pxp: detect PXP version Message-ID: References: <20230105134729.59542-1-m.tretter@pengutronix.de> <20230105134729.59542-3-m.tretter@pengutronix.de> <20230106140141.GC24101@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230106140141.GC24101@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, Jan 06, 2023 at 03:01:41PM +0100, Michael Tretter wrote: > On Fri, 06 Jan 2023 14:28:47 +0200, Laurent Pinchart wrote: > > On Fri, Jan 06, 2023 at 01:47:32PM +0200, Laurent Pinchart wrote: > > > Thank you for the patch. > > > > > > On Thu, Jan 05, 2023 at 02:47:23PM +0100, Michael Tretter wrote: > > > > Different versions of the Pixel Pipeline have different blocks and their > > > > routing may be different. Read the PXP_HW_VERSION register to determine > > > > the version of the PXP and print it to the log for debugging purposes. > > > > > > Is there a specific reason you chose to read the version register > > > instead of basing the decision on the compatible string ? > > > > Reading the rest of the series, you use the compatible strings later, > > and never use the hw_version field. I'm tempted to propose dropping this > > patch. > > My first try was to use the version register, but it turned out that the > version is the same at least on i.MX6ULL and i.MX7D. I kept it to avoid that > others fall into the same trap. > > > > > > > Signed-off-by: Michael Tretter > > > > --- > > > > drivers/media/platform/nxp/imx-pxp.c | 18 ++++++++++++++++++ > > > > 1 file changed, 18 insertions(+) > > > > > > > > diff --git a/drivers/media/platform/nxp/imx-pxp.c b/drivers/media/platform/nxp/imx-pxp.c > > > > index 689ae5e6ac62..05abe40558b0 100644 > > > > --- a/drivers/media/platform/nxp/imx-pxp.c > > > > +++ b/drivers/media/platform/nxp/imx-pxp.c > > > > @@ -10,6 +10,7 @@ > > > > * Pawel Osciak, > > > > * Marek Szyprowski, > > > > */ > > > > +#include > > > > #include > > > > #include > > > > #include > > > > @@ -52,6 +53,11 @@ MODULE_PARM_DESC(debug, "activates debug info"); > > > > #define MEM2MEM_HFLIP (1 << 0) > > > > #define MEM2MEM_VFLIP (1 << 1) > > > > > > > > +#define PXP_VERSION_MAJOR(version) \ > > > > + FIELD_GET(BM_PXP_VERSION_MAJOR, version) > > > > +#define PXP_VERSION_MINOR(version) \ > > > > + FIELD_GET(BM_PXP_VERSION_MINOR, version) > > > > + > > > > #define dprintk(dev, fmt, arg...) \ > > > > v4l2_dbg(1, debug, &dev->v4l2_dev, "%s: " fmt, __func__, ## arg) > > > > > > > > @@ -192,6 +198,8 @@ struct pxp_dev { > > > > struct clk *clk; > > > > void __iomem *mmio; > > > > > > > > + u32 hw_version; > > > > + > > > > atomic_t num_inst; > > > > struct mutex dev_mutex; > > > > spinlock_t irqlock; > > > > @@ -1660,6 +1668,11 @@ static int pxp_soft_reset(struct pxp_dev *dev) > > > > return 0; > > > > } > > > > > > > > +static u32 pxp_read_version(struct pxp_dev *dev) > > > > +{ > > > > + return readl(dev->mmio + HW_PXP_VERSION); > > > > +} > > > > + > > > > static int pxp_probe(struct platform_device *pdev) > > > > { > > > > struct pxp_dev *dev; > > > > @@ -1705,6 +1718,11 @@ static int pxp_probe(struct platform_device *pdev) > > > > goto err_clk; > > > > } > > > > > > > > + dev->hw_version = pxp_read_version(dev); > > > > + dev_info(&pdev->dev, "PXP Version %d.%d\n", > > > > > > As the version can't be negative, I'd use %u.%u. > > > > > > > + PXP_VERSION_MAJOR(dev->hw_version), > > > > + PXP_VERSION_MINOR(dev->hw_version)); > > > > + > > > > > > The driver now prints two messages at probe time, it would be nice to > > > combine them, or remove the other one. That's a candidate for a future > > > patch though. > > I would reduce the level to dev_debug. Then the version is not always printed, > but it can be easily enabled if necessary for the bringup on another platform. Fine with me. > > > > ret = v4l2_device_register(&pdev->dev, &dev->v4l2_dev); > > > > if (ret) > > > > goto err_clk; -- Regards, Laurent Pinchart