From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64568C54EBD for ; Fri, 6 Jan 2023 18:43:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235449AbjAFSnM (ORCPT ); Fri, 6 Jan 2023 13:43:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231493AbjAFSnL (ORCPT ); Fri, 6 Jan 2023 13:43:11 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B45258833; Fri, 6 Jan 2023 10:43:10 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B9C44AE; Fri, 6 Jan 2023 19:43:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1673030589; bh=ANMwKdLTFB/DW0H3uaMBofhSKclONfYV8wOa/W2GIL0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hgUkIMwQyo7zmfMEdPSHPAnWNRSGhCo1IQdzNKLhLjvzgIXKYG0FaO15NppNJg94E 7gkFGTYSq/NKO9vme03kcshb8FDjhD58WGRDhdHYaccd59pwK7SLvLq1OzWreuMIKf Jt4M/qmNaIPR6TE6jXdkPUuH/V473NVYvjjz+vkE= Date: Fri, 6 Jan 2023 20:43:03 +0200 From: Laurent Pinchart To: Michael Tretter Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 8/8] ARM: dts: imx7d: add node for PXP Message-ID: References: <20230105134729.59542-1-m.tretter@pengutronix.de> <20230105134729.59542-9-m.tretter@pengutronix.de> <20230106143621.GF24101@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230106143621.GF24101@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, Jan 06, 2023 at 03:36:21PM +0100, Michael Tretter wrote: > On Fri, 06 Jan 2023 14:36:41 +0200, Laurent Pinchart wrote: > > Hi Michael, > > > > Thank you for the patch. > > > > On Thu, Jan 05, 2023 at 02:47:29PM +0100, Michael Tretter wrote: > > > The i.MX7d contains a Pixel Pipeline in version 3.0. Add the device tree > > > node to make it available. > > > > > > Signed-off-by: Michael Tretter > > > --- > > > arch/arm/boot/dts/imx7d.dtsi | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi > > > index 7ceb7c09f7ad..728cc9413a7c 100644 > > > --- a/arch/arm/boot/dts/imx7d.dtsi > > > +++ b/arch/arm/boot/dts/imx7d.dtsi > > > @@ -165,6 +165,15 @@ pcie_phy: pcie-phy@306d0000 { > > > reg = <0x306d0000 0x10000>; > > > status = "disabled"; > > > }; > > > + > > > + pxp: pxp@30700000 { > > > + compatible = "fsl,imx7d-pxp"; > > > > Hmmm... The i.MX7S also has a PXP that seems compatible. I thus wonder > > if we shouldn't move this node to imx7s.dtsi. > > The i.MX7S has a PXP at the same address, but the architecture in the > reference manual (Figure 13-71. PXP Architecture, p. 3797) looks slightly > different wrt. the location of the multiplexers. The reference manual is also > conspicuously lacking documentation of the DATA_PATH_CTRL0 register. > > I wouldn't risk adding the node to the imx7s.dtsi and would rather keep the > option to add a different compatible for the i.MX7S to be able to handle the > difference. OK, fine with me. > > > + reg = <0x30700000 0x10000>; > > > + interrupts = , > > > + ; > > > > Nitpicking, alignment ? > > > > > + clocks = <&clks IMX7D_PXP_CLK>; > > > + clock-names = "axi"; > > > + }; > > > }; > > > > > > &aips3 { -- Regards, Laurent Pinchart