From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EF8DC38142 for ; Tue, 24 Jan 2023 12:53:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234047AbjAXMxO (ORCPT ); Tue, 24 Jan 2023 07:53:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234146AbjAXMxC (ORCPT ); Tue, 24 Jan 2023 07:53:02 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05809460A6 for ; Tue, 24 Jan 2023 04:52:23 -0800 (PST) X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="412517350" X-IronPort-AV: E=Sophos;i="5.97,242,1669104000"; d="scan'208";a="412517350" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2023 04:50:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="612035726" X-IronPort-AV: E=Sophos;i="5.97,242,1669104000"; d="scan'208";a="612035726" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP; 24 Jan 2023 04:50:43 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pKIl6-00ELPr-33; Tue, 24 Jan 2023 14:50:40 +0200 Date: Tue, 24 Jan 2023 14:50:40 +0200 From: Andy Shevchenko To: Hans de Goede Cc: Mauro Carvalho Chehab , Sakari Ailus , Tsuchiya Yuto , Yury Luneff , Nable , andrey.i.trufanov@gmail.com, Fabio Aiuto , linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 33/57] media: atomisp: ov2680: Add test pattern control Message-ID: References: <20230123125205.622152-1-hdegoede@redhat.com> <20230123125205.622152-34-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Tue, Jan 24, 2023 at 12:27:55PM +0100, Hans de Goede wrote: > On 1/23/23 19:46, Andy Shevchenko wrote: > > On Mon, Jan 23, 2023 at 01:51:41PM +0100, Hans de Goede wrote: > >> Add a test pattern control. This is a 1:1 copy of the test pattern > >> control in the main drivers/media/i2c/ov2680.c driver. > > > > Hmm... I'm not sure I understand the trend of the changes. > > We have two drivers of the same sensor, correct? > > So, the idea is to move the AtomISP-specific one to be like > > the generic and then kill it eventually? > > The goal is to kill one eventually yes. I'm not sure which > one to kill yet though. I have actually found a whole bunch > of bugs in the main drivers/media/i2c/ov2680.c code and > given its buggy-ness I wonder if anyone is actually using it. > > I need to start an email thread about this (and a couple of > other open questions which I have), I have a bunch of notes > which I need to turn into emails for this. > > > If so, why do we add something here? > > Because I suspect that the atomisp version might eventually > be the one we want to keep (and move to drivers/media/i2c). Fine, just add a few words into cover letter. Btw, do you use `b4` tool to handle patch(es) series? It has a nice feature to handle a series as a PR. In that case the cover letter becomes a merge-commit message which is cool feature in my opinion. -- With Best Regards, Andy Shevchenko