From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 200D6C38142 for ; Tue, 24 Jan 2023 10:48:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233436AbjAXKs2 (ORCPT ); Tue, 24 Jan 2023 05:48:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231791AbjAXKsY (ORCPT ); Tue, 24 Jan 2023 05:48:24 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 258444238 for ; Tue, 24 Jan 2023 02:47:44 -0800 (PST) X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="314168538" X-IronPort-AV: E=Sophos;i="5.97,242,1669104000"; d="scan'208";a="314168538" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2023 02:46:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="835920488" X-IronPort-AV: E=Sophos;i="5.97,242,1669104000"; d="scan'208";a="835920488" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 24 Jan 2023 02:46:18 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pKGoi-00EIVH-0R; Tue, 24 Jan 2023 12:46:16 +0200 Date: Tue, 24 Jan 2023 12:46:15 +0200 From: Andy Shevchenko To: Hans de Goede Cc: Mauro Carvalho Chehab , Sakari Ailus , Tsuchiya Yuto , Yury Luneff , Nable , andrey.i.trufanov@gmail.com, Fabio Aiuto , linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 41/57] media: atomisp: ov2680: Fix frame_size list Message-ID: References: <20230123125205.622152-1-hdegoede@redhat.com> <20230123125205.622152-42-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230123125205.622152-42-hdegoede@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Jan 23, 2023 at 01:51:49PM +0100, Hans de Goede wrote: > 3 fixes for the framesize list: > > 1. Drop modes < 640x480, these are made by significant cropping, > leading to such a small remainig field-of-view that they are > not really usable Wondering if we have an algo to actually scale instead of crop. > 2. 1616x1082 is presumably intended to be 1600x1080 + 16 pixels > padding in both dimensions, but the height is wrong. > Change this to 1616x1096. > > 3. The 800x600 mode is missing the 16 pixels padding and > 720x592 is missing 16 pixels padding in its width and > the 720x576 base mode is a mode with non square pixels, > while the sensor has square pixels. > Replace both with 768x576 + 16 pixels padding -> 784x592 Reviewed-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- > drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c > index 432539dd274c..81fd36b09090 100644 > --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c > +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c > @@ -700,17 +700,13 @@ static int ov2680_enum_frame_size(struct v4l2_subdev *sd, > { > static const struct v4l2_frmsize_discrete ov2680_frame_sizes[] = { > { 1616, 1216 }, > - { 1616, 1082 }, > + { 1616, 1096 }, > { 1616, 916 }, > { 1456, 1096 }, > { 1296, 976 }, > { 1296, 736 }, > - { 800, 600 }, > - { 720, 592 }, > + { 784, 592 }, > { 656, 496 }, > - { 336, 256 }, > - { 352, 288 }, > - { 176, 144 }, > }; > int index = fse->index; > > -- > 2.39.0 > -- With Best Regards, Andy Shevchenko