From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60C38C38142 for ; Tue, 24 Jan 2023 10:48:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232744AbjAXKsw (ORCPT ); Tue, 24 Jan 2023 05:48:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229933AbjAXKsv (ORCPT ); Tue, 24 Jan 2023 05:48:51 -0500 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEBCE4392D for ; Tue, 24 Jan 2023 02:48:12 -0800 (PST) X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="328357325" X-IronPort-AV: E=Sophos;i="5.97,242,1669104000"; d="scan'208";a="328357325" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2023 02:48:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="907440171" X-IronPort-AV: E=Sophos;i="5.97,242,1669104000"; d="scan'208";a="907440171" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 24 Jan 2023 02:48:03 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pKGqP-00EIXr-2M; Tue, 24 Jan 2023 12:48:01 +0200 Date: Tue, 24 Jan 2023 12:48:01 +0200 From: Andy Shevchenko To: Hans de Goede Cc: Mauro Carvalho Chehab , Sakari Ailus , Tsuchiya Yuto , Yury Luneff , Nable , andrey.i.trufanov@gmail.com, Fabio Aiuto , linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 43/57] media: atomisp: ov2680: Drop MAX_FMTS define Message-ID: References: <20230123125205.622152-1-hdegoede@redhat.com> <20230123125205.622152-44-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230123125205.622152-44-hdegoede@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Jan 23, 2023 at 01:51:51PM +0100, Hans de Goede wrote: > The ov2680 only supports a single format, there is no need to > use a define for this. Reviewed-by: Andy Shevchenko (One nit-pick below) > Signed-off-by: Hans de Goede > --- > drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 2 +- > drivers/staging/media/atomisp/i2c/ov2680.h | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c > index 81fd36b09090..994b6fe40069 100644 > --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c > +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c > @@ -687,7 +687,7 @@ static int ov2680_enum_mbus_code(struct v4l2_subdev *sd, > struct v4l2_subdev_state *sd_state, > struct v4l2_subdev_mbus_code_enum *code) > { > - if (code->index >= MAX_FMTS) > + if (code->index) Perhaps a comment above? /* We support only a single format */ > return -EINVAL; > > code->code = MEDIA_BUS_FMT_SBGGR10_1X10; > diff --git a/drivers/staging/media/atomisp/i2c/ov2680.h b/drivers/staging/media/atomisp/i2c/ov2680.h > index 189d1b2b7584..5aa46f669715 100644 > --- a/drivers/staging/media/atomisp/i2c/ov2680.h > +++ b/drivers/staging/media/atomisp/i2c/ov2680.h > @@ -46,8 +46,6 @@ > > #define OV2680_FOCAL_LENGTH_NUM 334 /*3.34mm*/ > > -#define MAX_FMTS 1 > - > #define OV2680_INTEGRATION_TIME_MARGIN 8 > #define OV2680_ID 0x2680 > > -- > 2.39.0 > -- With Best Regards, Andy Shevchenko