From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFF24C05027 for ; Mon, 23 Jan 2023 14:12:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232132AbjAWOMd (ORCPT ); Mon, 23 Jan 2023 09:12:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230081AbjAWOMc (ORCPT ); Mon, 23 Jan 2023 09:12:32 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9814B15CBD for ; Mon, 23 Jan 2023 06:12:29 -0800 (PST) X-IronPort-AV: E=McAfee;i="6500,9779,10598"; a="305705699" X-IronPort-AV: E=Sophos;i="5.97,239,1669104000"; d="scan'208";a="305705699" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2023 06:12:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10598"; a="725054091" X-IronPort-AV: E=Sophos;i="5.97,239,1669104000"; d="scan'208";a="725054091" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 23 Jan 2023 06:12:25 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pJxYd-00DlvG-2e; Mon, 23 Jan 2023 16:12:23 +0200 Date: Mon, 23 Jan 2023 16:12:23 +0200 From: Andy Shevchenko To: Hans de Goede Cc: Mauro Carvalho Chehab , Sakari Ailus , Tsuchiya Yuto , Yury Luneff , Nable , andrey.i.trufanov@gmail.com, Fabio Aiuto , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, Arnd Bergmann Subject: Re: [PATCH 01/57] media: atomisp: fix videobuf2 Kconfig depenendency Message-ID: References: <20230123125205.622152-1-hdegoede@redhat.com> <20230123125205.622152-2-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230123125205.622152-2-hdegoede@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Jan 23, 2023 at 01:51:09PM +0100, Hans de Goede wrote: > From: Arnd Bergmann > > The recent conversion missed the Kconfig bit, so it can now > end up in a link error on randconfig builds: > > ld.lld: error: undefined symbol: vb2_vmalloc_memops > >>> referenced by atomisp_fops.c > >>> drivers/staging/media/atomisp/pci/atomisp_fops.o:(atomisp_open) in archive vmlinux.a IIRC I have given my Tb tag [1]... For your convenience (but please, gather them next time) Tested-by: Andy Shevchenko [1]: https://lore.kernel.org/linux-media/Y7Vf6nejMFXs%2FqAk@smile.fi.intel.com/ > Fixes: cb48ae89be3b ("media: atomisp: Convert to videobuf2") > Signed-off-by: Arnd Bergmann > Link: https://lore.kernel.org/r/20230104082212.3770415-1-arnd@kernel.org > Reviewed-by: Hans de Goede > Signed-off-by: Hans de Goede > --- > drivers/staging/media/atomisp/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig > index 2c8d7fdcc5f7..c9bff98e5309 100644 > --- a/drivers/staging/media/atomisp/Kconfig > +++ b/drivers/staging/media/atomisp/Kconfig > @@ -14,7 +14,7 @@ config VIDEO_ATOMISP > depends on VIDEO_DEV && INTEL_ATOMISP > depends on PMIC_OPREGION > select IOSF_MBI > - select VIDEOBUF_VMALLOC > + select VIDEOBUF2_VMALLOC > select VIDEO_V4L2_SUBDEV_API > help > Say Y here if your platform supports Intel Atom SoC > -- > 2.39.0 > -- With Best Regards, Andy Shevchenko