From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Tsuchiya Yuto <kitakar@gmail.com>,
Yury Luneff <yury.lunev@gmail.com>,
Nable <nable.maininbox@googlemail.com>,
andrey.i.trufanov@gmail.com, Fabio Aiuto <fabioaiuto83@gmail.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH 11/57] media: atomisp: Remove no longer used binning info from sensor resolution info
Date: Mon, 23 Jan 2023 16:33:59 +0200 [thread overview]
Message-ID: <Y86a12t/LYcFtA+s@smile.fi.intel.com> (raw)
In-Reply-To: <20230123125205.622152-12-hdegoede@redhat.com>
On Mon, Jan 23, 2023 at 01:51:19PM +0100, Hans de Goede wrote:
> Remove the no longer used bin_factor_x, bin_factor_y and bin_mode members
> from the resolution info inside various atomisp camera sensor drivers.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/staging/media/atomisp/i2c/gc0310.h | 6 --
> drivers/staging/media/atomisp/i2c/gc2235.h | 27 ---------
> drivers/staging/media/atomisp/i2c/mt9m114.h | 12 ----
> drivers/staging/media/atomisp/i2c/ov2680.h | 39 ------------
> drivers/staging/media/atomisp/i2c/ov2722.h | 30 ----------
> .../staging/media/atomisp/i2c/ov5693/ov5693.h | 60 -------------------
> 6 files changed, 174 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/gc0310.h b/drivers/staging/media/atomisp/i2c/gc0310.h
> index 2a559b0d474d..cae480ae6fba 100644
> --- a/drivers/staging/media/atomisp/i2c/gc0310.h
> +++ b/drivers/staging/media/atomisp/i2c/gc0310.h
> @@ -123,9 +123,6 @@ struct gc0310_resolution {
> u32 skip_frames;
> u16 pixels_per_line;
> u16 lines_per_frame;
> - u8 bin_factor_x;
> - u8 bin_factor_y;
> - u8 bin_mode;
> bool used;
> };
>
> @@ -386,9 +383,6 @@ static struct gc0310_resolution gc0310_res_preview[] = {
> .pixels_per_line = 0x0314,
> .lines_per_frame = 0x0213,
> #endif
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .skip_frames = 2,
> .regs = gc0310_VGA_30fps,
> },
> diff --git a/drivers/staging/media/atomisp/i2c/gc2235.h b/drivers/staging/media/atomisp/i2c/gc2235.h
> index 8e33eb166bed..55ea422291ba 100644
> --- a/drivers/staging/media/atomisp/i2c/gc2235.h
> +++ b/drivers/staging/media/atomisp/i2c/gc2235.h
> @@ -134,9 +134,6 @@ struct gc2235_resolution {
> u32 skip_frames;
> u16 pixels_per_line;
> u16 lines_per_frame;
> - u8 bin_factor_x;
> - u8 bin_factor_y;
> - u8 bin_mode;
> bool used;
> };
>
> @@ -536,9 +533,6 @@ static struct gc2235_resolution gc2235_res_preview[] = {
> .used = 0,
> .pixels_per_line = 2132,
> .lines_per_frame = 1068,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = gc2235_1600_900_30fps,
> },
> @@ -552,9 +546,6 @@ static struct gc2235_resolution gc2235_res_preview[] = {
> .used = 0,
> .pixels_per_line = 2132,
> .lines_per_frame = 1368,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = gc2235_1616_1082_30fps,
> },
> @@ -567,9 +558,6 @@ static struct gc2235_resolution gc2235_res_preview[] = {
> .used = 0,
> .pixels_per_line = 2132,
> .lines_per_frame = 1368,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = gc2235_1616_1216_30fps,
> },
> @@ -593,9 +581,6 @@ static struct gc2235_resolution gc2235_res_still[] = {
> .used = 0,
> .pixels_per_line = 2132,
> .lines_per_frame = 1068,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = gc2235_1600_900_30fps,
> },
> @@ -608,9 +593,6 @@ static struct gc2235_resolution gc2235_res_still[] = {
> .used = 0,
> .pixels_per_line = 2132,
> .lines_per_frame = 1368,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = gc2235_1616_1082_30fps,
> },
> @@ -623,9 +605,6 @@ static struct gc2235_resolution gc2235_res_still[] = {
> .used = 0,
> .pixels_per_line = 2132,
> .lines_per_frame = 1368,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = gc2235_1616_1216_30fps,
> },
> @@ -644,9 +623,6 @@ static struct gc2235_resolution gc2235_res_video[] = {
> .used = 0,
> .pixels_per_line = 1828,
> .lines_per_frame = 888,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = gc2235_1296_736_30fps,
> },
> @@ -659,9 +635,6 @@ static struct gc2235_resolution gc2235_res_video[] = {
> .used = 0,
> .pixels_per_line = 1492,
> .lines_per_frame = 792,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = gc2235_960_640_30fps,
> },
> diff --git a/drivers/staging/media/atomisp/i2c/mt9m114.h b/drivers/staging/media/atomisp/i2c/mt9m114.h
> index 831875071cbb..b0cd1b724394 100644
> --- a/drivers/staging/media/atomisp/i2c/mt9m114.h
> +++ b/drivers/staging/media/atomisp/i2c/mt9m114.h
> @@ -316,9 +316,6 @@ struct mt9m114_res_struct {
> struct regval_list *regs;
> u16 pixels_per_line;
> u16 lines_per_frame;
> - u8 bin_factor_x;
> - u8 bin_factor_y;
> - u8 bin_mode;
> };
>
> /* 2 bytes used for address: 256 bytes total */
> @@ -350,9 +347,6 @@ static struct mt9m114_res_struct mt9m114_res[] = {
>
> .pixels_per_line = 0x0640,
> .lines_per_frame = 0x0307,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> },
> {
> .desc = "848P",
> @@ -366,9 +360,6 @@ static struct mt9m114_res_struct mt9m114_res[] = {
>
> .pixels_per_line = 0x0640,
> .lines_per_frame = 0x03E8,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> },
> {
> .desc = "960P",
> @@ -382,9 +373,6 @@ static struct mt9m114_res_struct mt9m114_res[] = {
>
> .pixels_per_line = 0x0644, /* consistent with regs arrays */
> .lines_per_frame = 0x03E5, /* consistent with regs arrays */
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> },
> };
>
> diff --git a/drivers/staging/media/atomisp/i2c/ov2680.h b/drivers/staging/media/atomisp/i2c/ov2680.h
> index 2bc350c67711..596e14453fb3 100644
> --- a/drivers/staging/media/atomisp/i2c/ov2680.h
> +++ b/drivers/staging/media/atomisp/i2c/ov2680.h
> @@ -147,9 +147,6 @@ struct ov2680_resolution {
> u32 skip_frames;
> u16 pixels_per_line;
> u16 lines_per_frame;
> - u8 bin_factor_x;
> - u8 bin_factor_y;
> - u8 bin_mode;
> };
>
> struct ov2680_format {
> @@ -758,9 +755,6 @@ static struct ov2680_resolution ov2680_res_preview[] = {
> .fps = 30,
> .pixels_per_line = 1698,//1704,
> .lines_per_frame = 1294,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2680_1616x1216_30fps,
> },
> @@ -771,9 +765,6 @@ static struct ov2680_resolution ov2680_res_preview[] = {
> .fps = 30,
> .pixels_per_line = 1698,//1704,
> .lines_per_frame = 1294,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2680_1616x1082_30fps,
> },
> @@ -784,9 +775,6 @@ static struct ov2680_resolution ov2680_res_preview[] = {
> .pix_clk_freq = 66,
> .pixels_per_line = 1698,//1704,
> .lines_per_frame = 1294,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2680_1616x916_30fps,
> },
> @@ -797,9 +785,6 @@ static struct ov2680_resolution ov2680_res_preview[] = {
> .pix_clk_freq = 66,
> .pixels_per_line = 1698,//1704,
> .lines_per_frame = 1294,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2680_1456x1096_30fps,
> },
> @@ -810,9 +795,6 @@ static struct ov2680_resolution ov2680_res_preview[] = {
> .pix_clk_freq = 66,
> .pixels_per_line = 1698,//1704,
> .lines_per_frame = 1294,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2680_1296x976_30fps,
> },
> @@ -823,9 +805,6 @@ static struct ov2680_resolution ov2680_res_preview[] = {
> .pix_clk_freq = 66,
> .pixels_per_line = 1698,//1704,
> .lines_per_frame = 1294,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2680_720p_30fps,
> },
> @@ -836,9 +815,6 @@ static struct ov2680_resolution ov2680_res_preview[] = {
> .pix_clk_freq = 66,
> .pixels_per_line = 1698,//1704,
> .lines_per_frame = 1294,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2680_800x600_30fps,
> },
> @@ -849,9 +825,6 @@ static struct ov2680_resolution ov2680_res_preview[] = {
> .pix_clk_freq = 66,
> .pixels_per_line = 1698,//1704,
> .lines_per_frame = 1294,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2680_720x592_30fps,
> },
> @@ -862,9 +835,6 @@ static struct ov2680_resolution ov2680_res_preview[] = {
> .pix_clk_freq = 66,
> .pixels_per_line = 1698,//1704,
> .lines_per_frame = 1294,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2680_656x496_30fps,
> },
> @@ -875,9 +845,6 @@ static struct ov2680_resolution ov2680_res_preview[] = {
> .pix_clk_freq = 66,
> .pixels_per_line = 1698,//1704,
> .lines_per_frame = 1294,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2680_QVGA_30fps,
> },
> @@ -888,9 +855,6 @@ static struct ov2680_resolution ov2680_res_preview[] = {
> .pix_clk_freq = 66,
> .pixels_per_line = 1698,//1704,
> .lines_per_frame = 1294,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2680_CIF_30fps,
> },
> @@ -901,9 +865,6 @@ static struct ov2680_resolution ov2680_res_preview[] = {
> .pix_clk_freq = 66,
> .pixels_per_line = 1698,//1704,
> .lines_per_frame = 1294,
> - .bin_factor_x = 0,
> - .bin_factor_y = 0,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2680_QCIF_30fps,
> },
> diff --git a/drivers/staging/media/atomisp/i2c/ov2722.h b/drivers/staging/media/atomisp/i2c/ov2722.h
> index 5802cdb0e90c..020743a944c4 100644
> --- a/drivers/staging/media/atomisp/i2c/ov2722.h
> +++ b/drivers/staging/media/atomisp/i2c/ov2722.h
> @@ -177,9 +177,6 @@ struct ov2722_resolution {
> u32 skip_frames;
> u16 pixels_per_line;
> u16 lines_per_frame;
> - u8 bin_factor_x;
> - u8 bin_factor_y;
> - u8 bin_mode;
> bool used;
> int mipi_freq;
> };
> @@ -1109,9 +1106,6 @@ static struct ov2722_resolution ov2722_res_preview[] = {
> .used = 0,
> .pixels_per_line = 2260,
> .lines_per_frame = 1244,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2722_1632_1092_30fps,
> .mipi_freq = 422400,
> @@ -1125,9 +1119,6 @@ static struct ov2722_resolution ov2722_res_preview[] = {
> .used = 0,
> .pixels_per_line = 2260,
> .lines_per_frame = 1244,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2722_1452_1092_30fps,
> .mipi_freq = 422400,
> @@ -1141,9 +1132,6 @@ static struct ov2722_resolution ov2722_res_preview[] = {
> .used = 0,
> .pixels_per_line = 2068,
> .lines_per_frame = 1114,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2722_1080p_30fps,
> .mipi_freq = 345600,
> @@ -1167,9 +1155,6 @@ struct ov2722_resolution ov2722_res_still[] = {
> .used = 0,
> .pixels_per_line = 2260,
> .lines_per_frame = 1244,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2722_1632_1092_30fps,
> .mipi_freq = 422400,
> @@ -1183,9 +1168,6 @@ struct ov2722_resolution ov2722_res_still[] = {
> .used = 0,
> .pixels_per_line = 2260,
> .lines_per_frame = 1244,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2722_1452_1092_30fps,
> .mipi_freq = 422400,
> @@ -1199,9 +1181,6 @@ struct ov2722_resolution ov2722_res_still[] = {
> .used = 0,
> .pixels_per_line = 2068,
> .lines_per_frame = 1114,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2722_1080p_30fps,
> .mipi_freq = 345600,
> @@ -1220,9 +1199,6 @@ struct ov2722_resolution ov2722_res_video[] = {
> .used = 0,
> .pixels_per_line = 2048,
> .lines_per_frame = 1184,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2722_QVGA_30fps,
> .mipi_freq = 364800,
> @@ -1236,9 +1212,6 @@ struct ov2722_resolution ov2722_res_video[] = {
> .used = 0,
> .pixels_per_line = 2048,
> .lines_per_frame = 1184,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2722_480P_30fps,
> },
> @@ -1251,9 +1224,6 @@ struct ov2722_resolution ov2722_res_video[] = {
> .used = 0,
> .pixels_per_line = 2068,
> .lines_per_frame = 1114,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .skip_frames = 3,
> .regs = ov2722_1080p_30fps,
> .mipi_freq = 345600,
> diff --git a/drivers/staging/media/atomisp/i2c/ov5693/ov5693.h b/drivers/staging/media/atomisp/i2c/ov5693/ov5693.h
> index c9b9dc780f96..5e17eaf8fd6e 100644
> --- a/drivers/staging/media/atomisp/i2c/ov5693/ov5693.h
> +++ b/drivers/staging/media/atomisp/i2c/ov5693/ov5693.h
> @@ -198,9 +198,6 @@ struct ov5693_resolution {
> int pix_clk_freq;
> u16 pixels_per_line;
> u16 lines_per_frame;
> - u8 bin_factor_x;
> - u8 bin_factor_y;
> - u8 bin_mode;
> bool used;
> };
>
> @@ -1109,9 +1106,6 @@ static struct ov5693_resolution ov5693_res_preview[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .regs = ov5693_736x496_30fps,
> },
> {
> @@ -1123,9 +1117,6 @@ static struct ov5693_resolution ov5693_res_preview[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .regs = ov5693_1616x1216_30fps,
> },
> {
> @@ -1137,9 +1128,6 @@ static struct ov5693_resolution ov5693_res_preview[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .regs = ov5693_2576x1456_30fps,
> },
> {
> @@ -1151,9 +1139,6 @@ static struct ov5693_resolution ov5693_res_preview[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .regs = ov5693_2576x1936_30fps,
> },
> };
> @@ -1175,9 +1160,6 @@ struct ov5693_resolution ov5693_res_still[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .regs = ov5693_736x496_30fps,
> },
> {
> @@ -1189,9 +1171,6 @@ struct ov5693_resolution ov5693_res_still[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .regs = ov5693_1424x1168_30fps,
> },
> {
> @@ -1203,9 +1182,6 @@ struct ov5693_resolution ov5693_res_still[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .regs = ov5693_1616x1216_30fps,
> },
> {
> @@ -1217,9 +1193,6 @@ struct ov5693_resolution ov5693_res_still[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .regs = ov5693_2592x1456_30fps,
> },
> {
> @@ -1231,9 +1204,6 @@ struct ov5693_resolution ov5693_res_still[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .regs = ov5693_2592x1944_30fps,
> },
> };
> @@ -1250,9 +1220,6 @@ struct ov5693_resolution ov5693_res_video[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 2,
> - .bin_factor_y = 2,
> - .bin_mode = 1,
> .regs = ov5693_736x496,
> },
> {
> @@ -1264,9 +1231,6 @@ struct ov5693_resolution ov5693_res_video[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 2,
> - .bin_factor_y = 2,
> - .bin_mode = 1,
> .regs = ov5693_336x256,
> },
> {
> @@ -1278,9 +1242,6 @@ struct ov5693_resolution ov5693_res_video[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 2,
> - .bin_factor_y = 2,
> - .bin_mode = 1,
> .regs = ov5693_368x304,
> },
> {
> @@ -1292,9 +1253,6 @@ struct ov5693_resolution ov5693_res_video[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 2,
> - .bin_factor_y = 2,
> - .bin_mode = 1,
> .regs = ov5693_192x160,
> },
> {
> @@ -1306,9 +1264,6 @@ struct ov5693_resolution ov5693_res_video[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 2,
> - .bin_factor_y = 2,
> - .bin_mode = 0,
> .regs = ov5693_1296x736,
> },
> {
> @@ -1320,9 +1275,6 @@ struct ov5693_resolution ov5693_res_video[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 2,
> - .bin_factor_y = 2,
> - .bin_mode = 0,
> .regs = ov5693_1296x976,
> },
> {
> @@ -1334,9 +1286,6 @@ struct ov5693_resolution ov5693_res_video[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .regs = ov5693_1636p_30fps,
> },
> {
> @@ -1348,9 +1297,6 @@ struct ov5693_resolution ov5693_res_video[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .regs = ov5693_1940x1096,
> },
> {
> @@ -1362,9 +1308,6 @@ struct ov5693_resolution ov5693_res_video[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .regs = ov5693_2592x1456_30fps,
> },
> {
> @@ -1376,9 +1319,6 @@ struct ov5693_resolution ov5693_res_video[] = {
> .used = 0,
> .pixels_per_line = 2688,
> .lines_per_frame = 1984,
> - .bin_factor_x = 1,
> - .bin_factor_y = 1,
> - .bin_mode = 0,
> .regs = ov5693_2592x1944_30fps,
> },
> };
> --
> 2.39.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-23 14:34 UTC|newest]
Thread overview: 168+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 12:51 [PATCH 00/57] media: atomisp: Big power-management changes + lots of fixes Hans de Goede
2023-01-23 12:51 ` [PATCH 01/57] media: atomisp: fix videobuf2 Kconfig depenendency Hans de Goede
2023-01-23 14:12 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 02/57] media: atomisp: use vb2_start_streaming_called() Hans de Goede
2023-01-23 12:51 ` [PATCH 03/57] media: atomisp: Remove atomisp_sw_contex struct Hans de Goede
2023-01-23 14:14 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 04/57] media: atomisp: Move power-management over to a custom pm-domain Hans de Goede
2023-01-23 12:51 ` [PATCH 05/57] media: atomisp: Silence "isys dma store at addr, val" debug messages Hans de Goede
2023-01-23 14:18 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 06/57] media: atomisp: Remove non working doorbell check from punit_ddr_dvfs_enable() Hans de Goede
2023-01-23 12:51 ` [PATCH 07/57] media: atomisp: Remove useless msleep(10) before power-on on BYT Hans de Goede
2023-01-23 14:40 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 08/57] media: atomisp: Remove custom ATOMISP_IOC_ISP_MAKERNOTE ioctl Hans de Goede
2023-01-23 14:30 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 09/57] media: atomisp: Remove custom ATOMISP_IOC_G_SENSOR_MODE_DATA ioctl Hans de Goede
2023-01-23 14:31 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 10/57] media: atomisp: Remove V4L2_CID_BIN_FACTOR_HORZ/_VERT Hans de Goede
2023-01-23 14:33 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 11/57] media: atomisp: Remove no longer used binning info from sensor resolution info Hans de Goede
2023-01-23 14:33 ` Andy Shevchenko [this message]
2023-01-23 12:51 ` [PATCH 12/57] media: atomisp: Propagate set_fmt() errors in queue_setup() Hans de Goede
2023-01-23 14:35 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 13/57] media: atomisp: Remove deferred firmware loading support Hans de Goede
2023-01-23 14:37 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 14/57] media: atomisp: Check buffer index is in range inside atomisp_qbuf_wrapper() Hans de Goede
2023-01-23 14:38 ` Andy Shevchenko
2023-01-24 11:09 ` Hans de Goede
2023-01-23 12:51 ` [PATCH 15/57] media: atomisp: Drop atomisp_init_pipe() Hans de Goede
2023-01-23 15:30 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 16/57] media: atomisp: Remove unnecessary memset(foo, 0, sizeof(foo)) calls Hans de Goede
2023-01-23 17:41 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 17/57] media: atomisp: Only set default_run_mode on first open of a stream/asd Hans de Goede
2023-01-23 17:42 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 18/57] media: atomisp: Do not turn off sensor when the atomisp-sub-dev does not own it Hans de Goede
2023-01-23 12:51 ` [PATCH 19/57] media: atomisp: Allow sensor drivers without a s_power callback Hans de Goede
2023-01-23 17:49 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 20/57] media: atomisp: Fix regulator registers on BYT devices with CRC PMIC Hans de Goede
2023-01-23 17:51 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 21/57] media: atomisp: Remove atomisp_gmin_find_subdev() Hans de Goede
2023-01-23 17:53 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 22/57] media: atomisp: Add atomisp_register_sensor_no_gmin() helper Hans de Goede
2023-01-23 17:55 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 23/57] media: atomisp: Fix WARN() when the vb2 start_streaming callback fails Hans de Goede
2023-01-23 17:56 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 24/57] media: atomisp: Drop ffmt local var from atomisp_set_fmt() Hans de Goede
2023-01-23 12:51 ` [PATCH 25/57] media: atomisp: Stop overriding padding w/h to 12 on BYT Hans de Goede
2023-01-23 17:59 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 26/57] media: atomisp: Put sensor ACPI devices in D3 before disable ACPI power-resources Hans de Goede
2023-01-23 12:51 ` [PATCH 27/57] media: atomisp: Remove isp_subdev_link_setup() Hans de Goede
2023-01-23 18:02 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 28/57] media: Add ovxxxx_16bit_addr_reg_helpers.h Hans de Goede
2023-01-23 18:09 ` Andy Shevchenko
2023-01-24 11:21 ` Hans de Goede
2023-01-24 12:47 ` Andy Shevchenko
2023-01-23 18:15 ` Andy Shevchenko
2023-01-23 18:23 ` Andy Shevchenko
2023-01-24 11:25 ` Hans de Goede
2023-02-08 9:52 ` Laurent Pinchart
2023-02-08 11:27 ` Andy Shevchenko
2023-02-08 15:41 ` Laurent Pinchart
2023-02-08 15:50 ` Andy Shevchenko
2023-02-08 16:03 ` Laurent Pinchart
2023-02-08 17:31 ` Andy Shevchenko
2023-02-09 10:31 ` Laurent Pinchart
2023-02-09 15:03 ` Hans de Goede
2023-02-09 16:11 ` Laurent Pinchart
2023-02-10 10:21 ` Sakari Ailus
2023-02-10 10:29 ` Laurent Pinchart
2023-02-10 10:47 ` Sakari Ailus
2023-02-10 10:53 ` Andy Shevchenko
2023-02-10 11:05 ` Laurent Pinchart
2023-02-10 15:35 ` Andy Shevchenko
2023-02-10 16:01 ` Hans de Goede
2023-02-10 11:19 ` Hans de Goede
2023-02-10 11:35 ` Laurent Pinchart
2023-02-10 12:01 ` Hans de Goede
2023-02-10 11:04 ` Laurent Pinchart
2023-02-10 11:18 ` Sakari Ailus
2023-02-10 11:34 ` Laurent Pinchart
2023-02-10 11:20 ` Hans de Goede
2023-02-10 11:45 ` Laurent Pinchart
2023-02-10 11:56 ` Hans de Goede
2023-02-10 12:09 ` Laurent Pinchart
2023-02-10 12:17 ` Sakari Ailus
2023-02-10 12:59 ` Hans de Goede
2023-02-10 13:31 ` Sakari Ailus
2023-02-10 12:47 ` Hans de Goede
2023-02-10 13:18 ` Sakari Ailus
2023-02-10 14:43 ` Hans de Goede
2023-02-10 16:43 ` Laurent Pinchart
2023-02-10 20:16 ` Sakari Ailus
2023-02-10 12:26 ` Sakari Ailus
2023-02-10 15:42 ` Andy Shevchenko
2023-02-10 16:39 ` Laurent Pinchart
2023-02-10 20:18 ` Sakari Ailus
2023-02-10 16:40 ` Laurent Pinchart
2023-02-08 11:31 ` Sakari Ailus
2023-02-08 14:33 ` Mauro Carvalho Chehab
2023-02-08 15:39 ` Laurent Pinchart
2023-01-23 12:51 ` [PATCH 29/57] media: atomisp: ov2680: Use the new ovxxxx_16bit_addr_reg_helpers.h Hans de Goede
2023-01-23 18:13 ` Andy Shevchenko
2023-01-24 11:22 ` Hans de Goede
2023-01-23 12:51 ` [PATCH 30/57] media: atomisp: ov2680: Rework flip ctrls Hans de Goede
2023-01-23 18:33 ` Andy Shevchenko
2023-01-29 0:36 ` kernel test robot
2023-01-23 12:51 ` [PATCH 31/57] media: atomisp: ov2680: Drop custom ATOMISP_IOC_S_EXPOSURE support Hans de Goede
2023-01-23 18:35 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 32/57] media: atomisp: ov2680: Add exposure and gain controls Hans de Goede
2023-01-23 18:43 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 33/57] media: atomisp: ov2680: Add test pattern control Hans de Goede
2023-01-23 18:46 ` Andy Shevchenko
2023-01-24 11:27 ` Hans de Goede
2023-01-24 12:50 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 34/57] media: atomisp: ov2680: Fix window settings and enable window for all resolutions Hans de Goede
2023-01-23 18:48 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 35/57] media: atomisp: ov2680: Make setting the modes algorithm based Hans de Goede
2023-01-24 10:37 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 36/57] media: atomisp: ov2680: Use defines for fps, lines-per-frame and skip-frames Hans de Goede
2023-01-24 10:40 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 37/57] media: atomisp: ov2680: Drop unused res member from struct ov2680_device Hans de Goede
2023-01-24 10:39 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 38/57] media: atomisp: ov2680: Fix ov2680_enum_frame_interval() Hans de Goede
2023-01-24 10:42 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 39/57] media: atomisp: ov2680: Drop v4l2_find_nearest_size() call from set_fmt() Hans de Goede
2023-01-24 10:43 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 40/57] media: atomisp: ov2680: Drop struct ov2680_resolution / ov2680_res_preview Hans de Goede
2023-01-24 10:44 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 41/57] media: atomisp: ov2680: Fix frame_size list Hans de Goede
2023-01-24 10:46 ` Andy Shevchenko
2023-01-24 11:29 ` Hans de Goede
2023-01-23 12:51 ` [PATCH 42/57] media: atomisp: ov2680: Remove unused data-types and defines from ov2680.h Hans de Goede
2023-01-24 10:46 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 43/57] media: atomisp: ov2680: Drop MAX_FMTS define Hans de Goede
2023-01-24 10:48 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 44/57] media: atomisp: ov2680: Consistently indent define values Hans de Goede
2023-01-24 10:49 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 45/57] media: atomisp: ov2680: Cleanup includes Hans de Goede
2023-01-24 10:50 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 46/57] media: atomisp: ov2680: Delay power-on till streaming is started Hans de Goede
2023-01-24 10:51 ` Andy Shevchenko
2023-01-24 11:31 ` Hans de Goede
2023-01-24 12:52 ` Andy Shevchenko
2023-01-24 13:35 ` Hans de Goede
2023-01-23 12:51 ` [PATCH 47/57] media: atomisp: ov2680: Add runtime-pm support Hans de Goede
2023-01-24 10:53 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 48/57] media: atomisp: ov2680: s/dev/sensor/ Hans de Goede
2023-01-24 10:54 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 49/57] media: atomisp: ov2680: Use devm_kzalloc() for sensor data struct Hans de Goede
2023-01-24 10:55 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 50/57] media: atomisp: ov2680: Switch over to ACPI powermanagement Hans de Goede
2023-01-24 10:59 ` Andy Shevchenko
2023-01-23 12:51 ` [PATCH 51/57] media: atomisp: ov2722: Call atomisp_gmin_remove_subdev() on probe failure Hans de Goede
2023-01-23 18:36 ` Andy Shevchenko
2023-01-23 12:52 ` [PATCH 52/57] media: atomisp: ov2722: Fix GPIO1 polarity Hans de Goede
2023-01-23 18:39 ` Andy Shevchenko
2023-01-23 18:40 ` Andy Shevchenko
2023-01-23 12:52 ` [PATCH 53/57] media: atomisp: ov2722: Don't take the input_lock for try_fmt calls Hans de Goede
2023-01-23 18:39 ` Andy Shevchenko
2023-01-23 12:52 ` [PATCH 54/57] media: atomisp: ov2722: Power on sensor from set_fmt() callback Hans de Goede
2023-01-23 18:42 ` Andy Shevchenko
2023-01-24 11:32 ` Hans de Goede
2023-01-23 12:52 ` [PATCH 55/57] media: atomisp: pci: Replace bytes macros with functions Hans de Goede
2023-01-23 12:52 ` [PATCH 56/57] media: atomisp: pci: hive_isp_css_common: host: vmem: Replace SUBWORD " Hans de Goede
2023-01-23 18:27 ` Andy Shevchenko
2023-01-23 18:29 ` Andy Shevchenko
2023-01-23 12:52 ` [PATCH 57/57] media: atomisp: pci: sh_css: Inline single invocation of macro STATS_ENABLED() Hans de Goede
2023-01-24 11:01 ` [PATCH 00/57] media: atomisp: Big power-management changes + lots of fixes Andy Shevchenko
2023-01-24 11:05 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y86a12t/LYcFtA+s@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=andrey.i.trufanov@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=hdegoede@redhat.com \
--cc=kitakar@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=nable.maininbox@googlemail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=yury.lunev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox