Re: [PATCH v2 7/8] ACPI: property: Skip MIPI property table without "mipi-img" prefix

Andy Shevchenko
2023-01-24T16:41:41Z

On Tue, Jan 24, 2023 at 05:54:00PM +0200, Sakari Ailus wrote:
> On Mon, Jan 23, 2023 at 05:27:46PM +0200, Andy Shevchenko wrote:
> > On Mon, Jan 23, 2023 at 03:46:16PM +0200, Sakari Ailus wrote:

...

> > > - { "mipi-img-lens-focus", "lens-focus" },
> > > - { "mipi-img-flash-leds", "flash-leds" },
> > > - { "mipi-img-clock-frequency", "clock-frequency" },
> > > - { "mipi-img-led-max-current", "led-max-microamp" },
> > > - { "mipi-img-flash-max-current", "flash-max-microamp" },
> > > - { "mipi-img-flash-max-timeout", "flash-max-timeout-us" },
> > > + { MIPI_IMG_PREFIX "lens-focus", "lens-focus" },
> > > + { MIPI_IMG_PREFIX "flash-leds", "flash-leds" },
> > > + { MIPI_IMG_PREFIX "clock-frequency", "clock-frequency" },
> > > + { MIPI_IMG_PREFIX "led-max-current", "led-max-microamp" },
> > > + { MIPI_IMG_PREFIX "flash-max-current", "flash-max-microamp" },
> > > + { MIPI_IMG_PREFIX "flash-max-timeout", "flash-max-timeout-us" },
> >
> > I don't thing it ads to the readability, so I don't know why this (part of the)
> > change is needed.
>
> Ok, I'll drop this chunk.

Thank you. What you can do, though, is to make the second list on the same
column (in the previous patch) if you consider it would be better.

--
With Best Regards,
Andy Shevchenko