From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44173C54EAA for ; Mon, 23 Jan 2023 17:49:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232600AbjAWRt2 (ORCPT ); Mon, 23 Jan 2023 12:49:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231915AbjAWRt2 (ORCPT ); Mon, 23 Jan 2023 12:49:28 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 695D212078 for ; Mon, 23 Jan 2023 09:49:27 -0800 (PST) X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="309678859" X-IronPort-AV: E=Sophos;i="5.97,240,1669104000"; d="scan'208";a="309678859" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2023 09:49:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="661802412" X-IronPort-AV: E=Sophos;i="5.97,240,1669104000"; d="scan'208";a="661802412" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 23 Jan 2023 09:49:16 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pK0wU-00DrIN-2w; Mon, 23 Jan 2023 19:49:14 +0200 Date: Mon, 23 Jan 2023 19:49:14 +0200 From: Andy Shevchenko To: Hans de Goede Cc: Mauro Carvalho Chehab , Sakari Ailus , Tsuchiya Yuto , Yury Luneff , Nable , andrey.i.trufanov@gmail.com, Fabio Aiuto , linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 19/57] media: atomisp: Allow sensor drivers without a s_power callback Message-ID: References: <20230123125205.622152-1-hdegoede@redhat.com> <20230123125205.622152-20-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230123125205.622152-20-hdegoede@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Jan 23, 2023 at 01:51:27PM +0100, Hans de Goede wrote: > The s_power callback for v4l2-subdevs has been deprecated, allow sensor > drivers without a s_power callback to work by ignoring the -ENOIOCTLCMD > return value. Reviewed-by: Andy Shevchenko > Signed-off-by: Hans de Goede > --- > drivers/staging/media/atomisp/pci/atomisp_fops.c | 2 +- > drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c > index 833c7aac8f0a..ce01479bdd68 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_fops.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c > @@ -832,7 +832,7 @@ static int atomisp_release(struct file *file) > if (isp->inputs[asd->input_curr].asd == asd) { > ret = v4l2_subdev_call(isp->inputs[asd->input_curr].camera, > core, s_power, 0); > - if (ret) > + if (ret && ret != -ENOIOCTLCMD) > dev_warn(isp->dev, "Failed to power-off sensor\n"); > > /* clear the asd field to show this camera is not used */ > diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c > index d0dd3dbd6f6a..77856cbc5ba7 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c > @@ -700,7 +700,7 @@ static int atomisp_s_input(struct file *file, void *fh, unsigned int input) > asd->input_curr != input) { > ret = v4l2_subdev_call(isp->inputs[asd->input_curr].camera, > core, s_power, 0); > - if (ret) > + if (ret && ret != -ENOIOCTLCMD) > dev_warn(isp->dev, > "Failed to power-off sensor\n"); > /* clear the asd field to show this camera is not used */ > @@ -709,7 +709,7 @@ static int atomisp_s_input(struct file *file, void *fh, unsigned int input) > > /* powe on the new sensor */ > ret = v4l2_subdev_call(isp->inputs[input].camera, core, s_power, 1); > - if (ret) { > + if (ret && ret != -ENOIOCTLCMD) { > dev_err(isp->dev, "Failed to power-on sensor\n"); > return ret; > } > -- > 2.39.0 > -- With Best Regards, Andy Shevchenko