Re: [PATCH 35/57] media: atomisp: ov2680: Make setting the modes algorithm based

Andy Shevchenko
2023-01-24T10:38:43Z

On Mon, Jan 23, 2023 at 01:51:43PM +0100, Hans de Goede wrote:
> Instead of using a long fixed register settings list for each resolution,
> calculate the register settings based on the requested width + height.
>
> This will allow future enhancements like adding hblank and vblank controls
> and adding selection support.

...

> + ret = ovxxxx_write_reg16(client, OV2680_HORIZONTAL_START_H, sensor->mode.h_start);
> + if (ret)
> + return ret;
> +
> + ret = ovxxxx_write_reg16(client, OV2680_VERTICAL_START_H, sensor->mode.v_start);
> + if (ret)
> + return ret;

Wondering if those registers are always being accessed as 16-bit. In such case
I would consider to drop _L definitions along with _H suffixes.

--
With Best Regards,
Andy Shevchenko