Re: [PATCH 37/57] media: atomisp: ov2680: Drop unused res member from struct ov2680_device

Andy Shevchenko
2023-01-24T10:39:40Z

On Mon, Jan 23, 2023 at 01:51:45PM +0100, Hans de Goede wrote:
> The res member of struct ov2680_device isn't read anywhere anymore,
> drop it.

Reviewed-by: Andy Shevchenko <andy@kernel.org>

> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 5 -----
> drivers/staging/media/atomisp/i2c/ov2680.h | 1 -
> 2 files changed, 6 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
> index dee6eb3d8c63..09c260ac93bf 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
> @@ -548,10 +548,6 @@ static int ov2680_set_fmt(struct v4l2_subdev *sd,
>
> /* Restore value of all ctrls */
> ret = __v4l2_ctrl_handler_setup(&dev->ctrls.handler);
> - if (ret < 0)
> - goto err;
> -
> - dev->res = res;
> err:
> mutex_unlock(&dev->input_lock);
> return ret;
> @@ -839,7 +835,6 @@ static int ov2680_probe(struct i2c_client *client)
> mutex_init(&dev->input_lock);
>
> dev->client = client;
> - dev->res = &ov2680_res_preview[0];
> v4l2_i2c_subdev_init(&dev->sd, client, &ov2680_ops);
>
> pdata = gmin_camera_platform_data(&dev->sd,
> diff --git a/drivers/staging/media/atomisp/i2c/ov2680.h b/drivers/staging/media/atomisp/i2c/ov2680.h
> index 4c1d20f514b2..e9d0c84705fb 100644
> --- a/drivers/staging/media/atomisp/i2c/ov2680.h
> +++ b/drivers/staging/media/atomisp/i2c/ov2680.h
> @@ -180,7 +180,6 @@ struct ov2680_device {
> struct media_pad pad;
> struct mutex input_lock;
> struct i2c_client *client;
> - struct ov2680_resolution *res;
> struct camera_sensor_platform_data *platform_data;
> bool power_on;
> bool is_streaming;
> --
> 2.39.0
>

--
With Best Regards,
Andy Shevchenko