Re: [PATCH 46/57] media: atomisp: ov2680: Delay power-on till streaming is started

Hans de Goede
2023-01-24T11:32:10Z

Hi,

On 1/24/23 11:51, Andy Shevchenko wrote:
> On Mon, Jan 23, 2023 at 01:51:54PM +0100, Hans de Goede wrote:
>> Move the setting of the mode to stream on, this also allows
>> delaying power-on till streaming is started.
>>
>> And drop the deprecated s_power callback since this now no long
>> is necessary.
>
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
>
> See below.
>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> .../media/atomisp/i2c/atomisp-ov2680.c | 101 +++++++-----------
>> 1 file changed, 41 insertions(+), 60 deletions(-)
>>
>> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
>> index 1dc821ca4e68..2a8c4508cc66 100644
>> --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
>> +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c

<snip>

>> + if (sensor->is_streaming == enable) {
>> + dev_warn(&client->dev, "stream already %sed\n", enable ? "start" : "stopp");
>
> stopP ?!

Yes the format string is "%sed" so "stopp" gives us "stopped".

Regards,

Hans