Re: [PATCH 00/57] media: atomisp: Big power-management changes + lots of fixes

Andy Shevchenko
2023-01-24T11:02:15Z

On Mon, Jan 23, 2023 at 01:51:08PM +0100, Hans de Goede wrote:
> Hi All,
>
> Here is another set of patches resulting from my continued work
> on cleaning up / improving the atomisp driver.
>
> The main changes here are power-management related, divided
> into 2 sets:
>
> 1. Move the pm of the core atomisp device to its own custom PM
> domain. We turn the ISP on/off through the P-Unit and when
> off the PCI subsystem resume method complains about the PCI
> config space not being reachable. Changing to a custom PM
> domain fixes the logs getting filled with PCI subsys errors
> on every open of a /dev/video# node
>
> 2. Except for devices shipped with Android as factory image,
> all the DSDTs I have seen have proper ACPI pm code for
> the sensors. So we really should be using ACPI pm for this.
>
> This series contains a lot of ov2680 patches, including
> reworking the controls (so that control changes can be
> delayed to stream on time instead of directly trying to do
> i2c writes to the turned off sensor). Basically modernizing
> the ov2680 driver a lot (there are still some atomisp-isms left).
>
> And then finally after all the ov2680 cleanups it moves
> the ov2680 code over to using runtime-pm + ACPI pm,
> dropping all the direct PMIC + clk poking done by the
> atomisp_gmin_platform code.
>
> Besides that this also contains quite a few other fixes / cleanups
> for things which I encountered during the way and it contains the
> start of making the ov2722 driver work. With the changes present
> in that driver I get a working (but very dark) stream. I expect
> that once I add a proper exposure control this will start working

The non-commented patches were reviewed, but I'm not so familiar with the
details of the functionality of the PM parts there. So I left them for others
to review.

--
With Best Regards,
Andy Shevchenko