Re: [PATCH 29/57] media: atomisp: ov2680: Use the new ovxxxx_16bit_addr_reg_helpers.h

Hans de Goede
2023-01-24T11:23:14Z

Hi,

On 1/23/23 19:13, Andy Shevchenko wrote:
> On Mon, Jan 23, 2023 at 01:51:37PM +0100, Hans de Goede wrote:
>> Use the new ovxxxx_16bit_addr_reg_helpers.h instead of duplicating
>> the ovxxxx sensor I2C register access helpers found in many different
>> sensor drivers.
>
> ...
>
>> - ret = ov2680_write_reg(client, 1,
>> - OV2680_GROUP_ACCESS, 0x00);
>> + ret = ovxxxx_write_reg8(client, OV2680_GROUP_ACCESS, 0x00);
>> if (ret) {
>> dev_err(&client->dev, "%s: write 0x%02x: error, aborted\n",
>> __func__, OV2680_GROUP_ACCESS);
>
> Wouldn't this be a dup message without any additional value?
>
> Same to many other places.

Ack, these errors are all removed in further refactoring.

Regards,

Hans