From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCBB9C32793 for ; Wed, 18 Jan 2023 14:25:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230087AbjAROXj (ORCPT ); Wed, 18 Jan 2023 09:23:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231286AbjAROXY (ORCPT ); Wed, 18 Jan 2023 09:23:24 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4096B1207F; Wed, 18 Jan 2023 06:06:46 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A16BD1643; Wed, 18 Jan 2023 15:06:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1674050803; bh=XzrhBPMFwhQ+nebZ2587F3r8+byCcSQgzbr7Gg2hBTA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hQ1spppy2ZPBR3+fmNaWZecHnGZU5pn3N5ayuocGL5EFqS708SLZWTLQ9XBgnUgWm jF20iCeFjdue5qw5MSF18DIZUh5htVZV+fQuBA6SdNqEAQQngc1ajK+6FD+IH3fIab OTgEeBi4X8Fbb1pkKnFJehRG02WXQ/oUHnaUb5qU= Date: Wed, 18 Jan 2023 16:06:41 +0200 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Wolfram Sang , linux-renesas-soc@vger.kernel.org, Kieran Bingham , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: renesas: vsp1: blacklist r8a7795 ES1.* Message-ID: References: <20230118122003.132905-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Geert, On Wed, Jan 18, 2023 at 03:02:53PM +0100, Geert Uytterhoeven wrote: > On Wed, Jan 18, 2023 at 2:39 PM Laurent Pinchart wrote: > > On Wed, Jan 18, 2023 at 02:30:51PM +0100, Geert Uytterhoeven wrote: > > > On Wed, Jan 18, 2023 at 2:21 PM Laurent Pinchart wrote: > > > > On Wed, Jan 18, 2023 at 01:20:02PM +0100, Wolfram Sang wrote: > > > > > The earliest revision of these SoC may hang when underrunning. Later > > > > > revisions have that fixed. Bail out when we detect a problematic > > > > > version. > > > > > > > > > > Signed-off-by: Wolfram Sang > > > > > --- > > > > > > > > > > The BSP tries to work around the issue, yet this is neither upstreamable > > > > > nor are we sure the solution is complete. Because the early SoC revision > > > > > is hardly in use, we simply "document" the problem upstream. > > > > > > > > The workaround isn't upstreamable as-is, but I think it could be > > > > upstreamed after being cleaned up. > > > > > > > > Overall, how much support do we still have upstream for H3 ES1.x, and do > > > > we need to keep it ? H3 ES.1x is relatively old, does someone still rely > > > > on it ? > > > > > > I think the upstream support level for R-Car H3 ES1.x is about the same > > > as for H3 ES2.0. > > > > Question is, do we need to keep it ? :-) And if we do, instead of > > black-listing devices in the VSP driver, how about dropping them from > > r8a77950.dtsi ? > > I prefer blacklisting in the driver, as dropping them from r8a77950.dtsi > wouldn't disable them when used with an older or out-of-tree DTB. Is that really a use case we need to care about ? Who will run a recent kernel with an old DTB on a H3 ES1.x, without an easy way to update to a mainline device tree ? It's not like those devices went into production. > > We already delete quite a lot of devices there. > > ... because they don't exist on H3 ES1.x. > > > Note that without VSP support, you will get no display either, so the > > DU device (and the LVDS encoder) so also be deleted. > > True... -- Regards, Laurent Pinchart