Re: [PATCH v3 2/8] ACPI: property: Parse _CRS CSI-2 descriptor

Sakari Ailus
2023-01-30T21:46:14Z

On Mon, Jan 30, 2023 at 11:37:53PM +0200, Andy Shevchenko wrote:
> On Mon, Jan 30, 2023 at 11:18:30PM +0200, Sakari Ailus wrote:
> > On Fri, Jan 27, 2023 at 12:08:39PM +0200, Andy Shevchenko wrote:
> > > On Thu, Jan 26, 2023 at 12:40:55AM +0200, Sakari Ailus wrote:
>
> ...
>
> > > > + /* Collect the devices that have a _CRS CSI-2 resource */
> > > > + acpi_walk_namespace(ACPI_TYPE_DEVICE, handle, ACPI_UINT32_MAX,
> > >
> > > Other serial buses limit the DEPTH by 32, why do we need more here?
> >
> > I'm using the same value as for scanning devices to be added. Effectively
> > this is not a practical limit but it doesn't need to be.
>
> Hmm... Theoretically one may supply a malformed table, quite compact, but with
> huge amount of "fake" devices. I would limit this the same way. If we got a
> report of the depth not being enough we may bump based on the reality. This also
> may limit scanning time.

Then this should be done also for scanning ACPI devices below.

I'd like to have Rafael's opinion before making such changes. I'll prepend
such a patch to the series in that case.

--
Sakari Ailus