public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nikolay Kyx <knv418@gmail.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
	Bingbu Cao <bingbu.cao@intel.com>,
	Tianshu Qiu <tian.shu.qiu@intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: media: ipu3: code style fix - missing a blank line after declarations
Date: Sun, 21 Feb 2021 09:20:45 +0100	[thread overview]
Message-ID: <YDIX3Q0U8/PcVWgN@kroah.com> (raw)
In-Reply-To: <20210221081236.9758-2-knv418@gmail.com>

On Sun, Feb 21, 2021 at 11:12:36AM +0300, Nikolay Kyx wrote:
> This patch fixes the following checkpatch.pl warning:
> 
> WARNING: Missing a blank line after declarations
> 
> in file ipu3-css-fw.h
> 
> Signed-off-by: Nikolay Kyx <knv418@gmail.com>
> ---
> 
> Additionally some style warnings remain valid here and could be fixed by
> another patch.
> 
>  drivers/staging/media/ipu3/ipu3-css-fw.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/ipu3/ipu3-css-fw.h b/drivers/staging/media/ipu3/ipu3-css-fw.h
> index 79ffa7045139..3c078f15a295 100644
> --- a/drivers/staging/media/ipu3/ipu3-css-fw.h
> +++ b/drivers/staging/media/ipu3/ipu3-css-fw.h
> @@ -148,6 +148,7 @@ union imgu_fw_union {
>  struct imgu_fw_info {
>  	size_t header_size;	/* size of fw header */
>  	u32 type __aligned(8);	/* enum imgu_fw_type */
> +
>  	union imgu_fw_union info;	/* Binary info */
>  	struct imgu_abi_blob_info blob;	/* Blob info */
>  	/* Dynamic part */

With your knowledge of C, does this change look correct?

thanks,

greg k-h

  reply	other threads:[~2021-02-21  8:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-21  8:12 [PATCH 1/2] staging: media: ipu3: code style fix - avoid multiple line dereference Nikolay Kyx
2021-02-21  8:12 ` [PATCH 2/2] staging: media: ipu3: code style fix - missing a blank line after declarations Nikolay Kyx
2021-02-21  8:20   ` Greg Kroah-Hartman [this message]
2021-02-21 12:10     ` [PATCH v2] staging: media: ipu3: code style fix - avoid multiple line dereference Nikolay Kyx
  -- strict thread matches above, loose matches on Subject: below --
2021-02-21 10:42 [PATCH 2/2] staging: media: ipu3: code style fix - missing a blank line after declarations Nikolay K.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YDIX3Q0U8/PcVWgN@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bingbu.cao@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=knv418@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tian.shu.qiu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox