From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7978C433E6 for ; Wed, 10 Mar 2021 07:47:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A540564FF6 for ; Wed, 10 Mar 2021 07:47:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230063AbhCJHqw (ORCPT ); Wed, 10 Mar 2021 02:46:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229900AbhCJHq2 (ORCPT ); Wed, 10 Mar 2021 02:46:28 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39F3AC06174A for ; Tue, 9 Mar 2021 23:46:28 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id n17so4510540plc.7 for ; Tue, 09 Mar 2021 23:46:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YtSOPZCf9Da269ZEPcGrsyfquqgeGyegkCV8/Htilvk=; b=R5gEY8VaX1kw0BYeYWpOh2pvYK1+99hrZLVbBXAd3RwBgFjYc1B57PG7nhkaYE0mLc SXm6a1/sZRJ3lPzuMVqkrY91FHDPAe9Jscu5lh0y5zZmfoNOf7VeB8S4X77/Gr9e1ujv wuL7xpQ/EtRPPpp/f3fxRXxIVUJhTNkZFIIqM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YtSOPZCf9Da269ZEPcGrsyfquqgeGyegkCV8/Htilvk=; b=EXRYg+WPXTPFtBdX2KOLMFqLKRM7e9dxu1sWRBWnLXtt0k4xkW/sZuJMjPXeL18R6l +gzhoSIuYD/U+34FpYh52ld9E5+r1z9+oYoCj5UXyyFBbi4+Is777n9EyUZMp9teR7/N 7VsW1QYwEwoIR4U+Tq3XXrZaj9TYEWg728p4KZOpRo3BU1PwLDi7dqhx0tb2Wccditgx SxrQua/RocPtQVk9q8cytvUWkJ92FMtVhEYmbpr09ajnI8hGMvFr7roF8DGJ3qbH7rFY yZBkC+qvknVAQvsxXdRuwuGrqRBwZpP8mwbNTFEmrj0w5Pdm9C1nHufOlP9fhzmMFjSf fGgA== X-Gm-Message-State: AOAM531aVAP6V9U5eXGekCXXs2m1PTRqYr3yQ3fUJmCfjhQPDrUYLyhV IGLM/XvmVnq9WhUqhKMFAHNQlg== X-Google-Smtp-Source: ABdhPJwEa8CkSLK2/AJuxaIcUqDxCJOy2d+vmOQXrdTz9u3hdWTy0ok3NvdeQBqSoRxViggpDTF0wQ== X-Received: by 2002:a17:90a:8:: with SMTP id 8mr2313414pja.6.1615362387840; Tue, 09 Mar 2021 23:46:27 -0800 (PST) Received: from google.com ([2409:10:2e40:5100:30c3:e7ed:8b0a:7f01]) by smtp.gmail.com with ESMTPSA id n9sm1793181pjq.38.2021.03.09.23.46.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 23:46:27 -0800 (PST) Date: Wed, 10 Mar 2021 16:46:22 +0900 From: Sergey Senozhatsky To: Ricardo Ribalda Cc: Tomasz Figa , Marek Szyprowski , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky , stable@vger.kernel.org Subject: Re: [PATCH] media: videobuf2: Fix integer overrun in vb2_mmap Message-ID: References: <20210310074028.1042475-1-ribalda@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210310074028.1042475-1-ribalda@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On (21/03/10 08:40), Ricardo Ribalda wrote: > > The plane_length is an unsigned integer. So, if we have a size of > 0xffffffff bytes we incorrectly allocate 0 bytes instead of 1 << 32. > > Suggested-by: Sergey Senozhatsky > Cc: stable@vger.kernel.org > Fixes: 7f8414594e47 ("[media] media: videobuf2: fix the length check for mmap") > Signed-off-by: Ricardo Ribalda FWIF, Reviewed-by: Sergey Senozhatsky