From: Tomasz Figa <tfiga@chromium.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Christoph Hellwig <hch@lst.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] videobuf2: support new noncontiguous DMA API
Date: Wed, 24 Mar 2021 21:09:12 +0900 [thread overview]
Message-ID: <YFsr6EKFqIS9AjRI@chromium.org> (raw)
In-Reply-To: <20210302004624.31294-1-senozhatsky@chromium.org>
Hi Sergey,
On Tue, Mar 02, 2021 at 09:46:16AM +0900, Sergey Senozhatsky wrote:
> Hello,
>
> RFC
>
> The series adds support for new noncontiguous DMA API [0] and
> adds V4L2_FLAG_MEMORY_NON_COHERENT UAPI. This is similar to previous
> V4L2_FLAG_MEMORY_NON_CONSISTENT (which was renamed), but the patch set
> goes a bit further this time and also does some videobuf2 API
> refactroings along the way.
>
> A corresponding v4l2-compliance patch will be posted shortly.
>
> [0] https://lore.kernel.org/lkml/20210301085236.947011-2-hch@lst.de/
>
> Sergey Senozhatsky (8):
> videobuf2: rework vb2_mem_ops API
> videobuf2: inverse buffer cache_hints flags
> videobuf2: split buffer cache_hints initialisation
> videobuf2: move cache_hints handling to allocators
> videobuf2: add V4L2_FLAG_MEMORY_NON_COHERENT flag
> videobuf2: add queue memory coherency parameter
> videobuf2: handle V4L2_FLAG_MEMORY_NON_COHERENT flag
> videobuf2: handle non-contiguous DMA allocations
>
> .../userspace-api/media/v4l/buffer.rst | 40 +++-
> .../media/v4l/vidioc-create-bufs.rst | 7 +-
> .../media/v4l/vidioc-reqbufs.rst | 16 +-
> .../media/common/videobuf2/videobuf2-core.c | 135 +++++++++-----
> .../common/videobuf2/videobuf2-dma-contig.c | 175 ++++++++++++++----
> .../media/common/videobuf2/videobuf2-dma-sg.c | 39 ++--
> .../media/common/videobuf2/videobuf2-v4l2.c | 47 ++---
> .../common/videobuf2/videobuf2-vmalloc.c | 30 +--
> drivers/media/dvb-core/dvb_vb2.c | 2 +-
> drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 9 +-
> drivers/media/v4l2-core/v4l2-ioctl.c | 5 +-
> include/media/videobuf2-core.h | 57 +++---
> include/uapi/linux/videodev2.h | 13 +-
> 13 files changed, 396 insertions(+), 179 deletions(-)
>
> --
> 2.30.1.766.gb4fecdf3b7-goog
>
Just some minor nits for patch 8. Otherwise, with Hans's comments
addressed:
Acked-by: Tomasz Figa <tfiga@chromium.org>
Thanks for the great job.
Best regards,
Tomasz
prev parent reply other threads:[~2021-03-24 12:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 0:46 [PATCH 0/8] videobuf2: support new noncontiguous DMA API Sergey Senozhatsky
2021-03-02 0:46 ` [PATCH 1/8] videobuf2: rework vb2_mem_ops API Sergey Senozhatsky
2021-03-02 0:46 ` [PATCH 2/8] videobuf2: inverse buffer cache_hints flags Sergey Senozhatsky
2021-03-02 0:46 ` [PATCH 3/8] videobuf2: split buffer cache_hints initialisation Sergey Senozhatsky
2021-03-02 0:46 ` [PATCH 4/8] videobuf2: move cache_hints handling to allocators Sergey Senozhatsky
2021-03-02 0:46 ` [PATCH 5/8] videobuf2: add V4L2_FLAG_MEMORY_NON_COHERENT flag Sergey Senozhatsky
2021-03-22 7:02 ` Hans Verkuil
2021-03-02 0:46 ` [PATCH 6/8] videobuf2: add queue memory coherency parameter Sergey Senozhatsky
2021-03-02 0:46 ` [PATCH 7/8] videobuf2: handle V4L2_FLAG_MEMORY_NON_COHERENT flag Sergey Senozhatsky
2021-03-22 7:16 ` Hans Verkuil
2021-03-22 7:18 ` Hans Verkuil
2021-03-02 0:46 ` [PATCH 8/8] videobuf2: handle non-contiguous DMA allocations Sergey Senozhatsky
2021-03-22 7:40 ` Hans Verkuil
2021-03-24 12:07 ` Tomasz Figa
2023-07-04 10:50 ` Hsia-Jun Li
2023-07-05 10:45 ` Tomasz Figa
2023-07-17 9:21 ` Hsia-Jun Li
2023-07-28 8:19 ` Tomasz Figa
2021-03-02 0:49 ` [PATCH] v4l-compliance: re-introduce NON_COHERENT and cache hints tests Sergey Senozhatsky
2021-03-02 0:50 ` Sergey Senozhatsky
2021-03-24 12:09 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFsr6EKFqIS9AjRI@chromium.org \
--to=tfiga@chromium.org \
--cc=hch@lst.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox