From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4FC4C433B4 for ; Mon, 12 Apr 2021 15:40:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC29661356 for ; Mon, 12 Apr 2021 15:40:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242174AbhDLPkS (ORCPT ); Mon, 12 Apr 2021 11:40:18 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:61775 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240930AbhDLPkR (ORCPT ); Mon, 12 Apr 2021 11:40:17 -0400 X-Originating-IP: 24.194.32.49 Received: from coplandos.local (cpe-24-194-32-49.nycap.res.rr.com [24.194.32.49]) (Authenticated sender: vrzh@vrzh.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 77C5540008; Mon, 12 Apr 2021 15:39:57 +0000 (UTC) Date: Mon, 12 Apr 2021 11:43:00 -0400 From: Martiros Shakhzadyan To: Hans Verkuil Cc: linux-media@vger.kernel.org Subject: Re: Re: [PATCH] staging: media: atomisp: Removed a function entry log Message-ID: References: <20210412023558.360103-1-vrzh@vrzh.net> <20210412023558.360103-3-vrzh@vrzh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Apr 12, 2021 at 11:28:09AM +0200, Hans Verkuil wrote: > On 12/04/2021 04:35, Martiros Shakhzadyan wrote: > > Coding style fix. > > What exactly is the coding style issue? Please mention that. > > Also, by removing the line you change the behavior (i.e. if debugging is > enabled, you no longer see this message). That's more than a coding style > fix... > > Regards, > > Hans > Thank you, Hans - I will resubmit the patch with a better commit message. > > > > Signed-off-by: Martiros Shakhzadyan > > --- > > drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c > > index c017e9066b7a..912eadaffc44 100644 > > --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c > > +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c > > @@ -1175,8 +1175,6 @@ static int ov2722_remove(struct i2c_client *client) > > struct v4l2_subdev *sd = i2c_get_clientdata(client); > > struct ov2722_device *dev = to_ov2722_sensor(sd); > > > > - dev_dbg(&client->dev, "ov2722_remove...\n"); > > - > > dev->platform_data->csi_cfg(sd, 0); > > v4l2_ctrl_handler_free(&dev->ctrl_handler); > > v4l2_device_unregister_subdev(sd); > > >