From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1B96C433B4 for ; Thu, 15 Apr 2021 16:26:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B886C6117A for ; Thu, 15 Apr 2021 16:26:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232648AbhDOQ0m (ORCPT ); Thu, 15 Apr 2021 12:26:42 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:46477 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230056AbhDOQ0l (ORCPT ); Thu, 15 Apr 2021 12:26:41 -0400 X-Originating-IP: 24.194.32.49 Received: from coplandos.local (cpe-24-194-32-49.nycap.res.rr.com [24.194.32.49]) (Authenticated sender: vrzh@vrzh.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id ED7DF240003; Thu, 15 Apr 2021 16:26:14 +0000 (UTC) Date: Thu, 15 Apr 2021 12:29:18 -0400 From: Martiros Shakhzadyan To: Hans Verkuil , Mauro Carvalho Chehab Cc: Sakari Ailus , linux-media@vger.kernel.org, Martiros Shakhzadyan Subject: Re: [PATCH] staging: media: atomisp: cleaning up sh_css.c Message-ID: References: <20210415005106.530914-1-vrzh@vrzh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, Apr 15, 2021 at 03:59:25PM +0200, Hans Verkuil wrote: > Hi Martiros, > > If you look at other patch series, you'll see that they follow this pattern: > > [PATCH x/y] > > and for the cover letter: [PATCH 0/y] > > It's recommended to follow that rule. > > On 15/04/2021 02:50, Martiros Shakhzadyan wrote: > > The following set of patches for sh_css.c aims to resolve coding style issues > > and remove redundancies. > > > > Martiros Shakhzadyan (9): > > staging: media: atomisp: [1/6] Fix sh_css.c brace coding style issues > > staging: media: atomisp: [2/6] Fix sh_css.c brace coding style issues > > staging: media: atomisp: [3/6] Fix sh_css.c brace coding style issues > > staging: media: atomisp: [4/6] Fix sh_css.c brace coding style issues > > staging: media: atomisp: [5/6] Fix sh_css.c brace coding style issues > > staging: media: atomisp: [6/6] Fix sh_css.c brace coding style issues\ > > Why split this up in 6 patches? Just combine it in one. It's all the same thing > for the same source. > > > staging: media: atomisp: Use goto instead of return in ia_css_init() > > staging: media: atomisp: [1/2] Remove redundant assertions in sh_css.c > > staging: media: atomisp: [2/2] Remove redundant assertions in sh_css.c > > Ditto for these two. > > Regards, > > Hans > Gotcha - will resubmit all following this rule (save for the rejected patch) - Thanks! > > > > drivers/staging/media/atomisp/pci/sh_css.c | 266 ++++++++------------- > > 1 file changed, 105 insertions(+), 161 deletions(-) > > >