From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 898DCC433ED for ; Fri, 30 Apr 2021 17:18:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E0A461476 for ; Fri, 30 Apr 2021 17:18:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230506AbhD3RSv (ORCPT ); Fri, 30 Apr 2021 13:18:51 -0400 Received: from msg-2.mailo.com ([213.182.54.12]:38966 "EHLO msg-2.mailo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229750AbhD3RSv (ORCPT ); Fri, 30 Apr 2021 13:18:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1619803075; bh=ojnJ555lXA46GF3/qKIyAUShuviwd+s4Ftf9ASPM424=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=Ro6898nhQabAFbhExawoG3OrpSeVplTWpiPtSGGYFx7zyBdOwP1+2gtO6UgAvEnev goGwDOExM6qWilF500x73krqgHvmRgyjcS9shUHnXfL8lJJo+FTEiM8ut4tUrkKU34 40yqRl9Nw74v7vN2tBnQXGZVPR7l77sLhxVhrCY8= Received: by 192.168.90.13 [192.168.90.13] with ESMTP via ip-206.mailobj.net [213.182.55.206] Fri, 30 Apr 2021 19:17:55 +0200 (CEST) X-EA-Auth: c1gehlscvNEfQhgT4PN/cZce+z64ErNVj5he8oBiRfc/1rwcXcmA8TBoV4AqVJqBm3PHo3spQSTL9XjN5x4mx152xFjdHwQq Date: Fri, 30 Apr 2021 22:47:50 +0530 From: Deepak R Varma To: Sakari Ailus Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: media: atomisp: pci: reposition braces as per coding style Message-ID: References: <20210430163327.GI3@paasikivi.fi.intel.com> <20210430171241.GJ3@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210430171241.GJ3@paasikivi.fi.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, Apr 30, 2021 at 08:12:41PM +0300, Sakari Ailus wrote: > Hi Deepak, > > On Fri, Apr 30, 2021 at 10:34:37PM +0530, Deepak R Varma wrote: > > On Fri, Apr 30, 2021 at 07:33:27PM +0300, Sakari Ailus wrote: > > > Hi Deepak, > > > > > > If you're touching all these lines, I might do a little more. Please see > > > the comments below. > > > > > Hello Sakari, > > I can definitely include other changes, but then it will be many different > > types of changes into a single patch. Will that be okay? > > > > I was planning to address one issue per patch as I think the volume of > > change is going to be high. I mentioned that in the notes section of the patch > > message. > > I think I'd split the patch into smaller chunks if the result becomes too > big but I don't think it's necessary yet. > > Splitting different kinds of simple cleanups into several patches takes > longer time to review when they're touching the same piece of code. As the > chunks in these patches have virtually no dependencies to other chunks, > it's fine to do several kinds of cleanups at once. Okay, sure. That sounds good to me. I will include other related improvements in the same area and send split patch set accordingly. I will include this patch in the patch set. Thank you for the guidance. deepak. > > -- > Kind regards, > > Sakari Ailus