From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Ricardo Ribalda <ribalda@chromium.org>,
Tomasz Figa <tfiga@chromium.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4 0/5] media: uvcvideo: implement UVC 1.5 ROI
Date: Sat, 1 May 2021 10:58:10 +0900 [thread overview]
Message-ID: <YIy1suAHDrArv8fz@google.com> (raw)
In-Reply-To: <8a175117-d142-9265-65ee-43302bb82444@xs4all.nl>
Hi Hans,
On (21/04/30 14:49), Hans Verkuil wrote:
> Hi Sergey,
>
> On 30/04/2021 13:26, Sergey Senozhatsky wrote:
> > Hello,
> >
> > This patch set implements UVC 1.5 ROI using v4l2_selection API.
>
> Is the selection API the right approach for this? Wouldn't it make
> sense to use controls instead?
[..]
> If this was discussed before, then can you give a me pointer to that discussion?
> I couldn't find anything for that, but I didn't look very long for it :-)
I believe Tomasz raised this question over IRC back in the days and there
was no clear conclusion at the end: selection API vs control - 50/50 split.
After internal discussions we decided to go with the selection API.
> In any case, it doesn't really feel like it is the right API for this job.
Well, we pass a rectangle to the driver. The driver already knows what
to do with some of those rectangles, we teach it to handle one more. So
we don't introduce anything new, but use the existing API instead.
next prev parent reply other threads:[~2021-05-01 1:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 11:26 [PATCHv4 0/5] media: uvcvideo: implement UVC 1.5 ROI Sergey Senozhatsky
2021-04-30 11:26 ` [PATCHv4 1/5] media: v4l UAPI: add ROI selection targets Sergey Senozhatsky
2021-04-30 11:26 ` [PATCHv4 2/5] media: v4l UAPI: document " Sergey Senozhatsky
2021-04-30 11:26 ` [PATCHv4 3/5] media: uvcvideo: add ROI auto controls Sergey Senozhatsky
2021-04-30 11:26 ` [PATCHv4 4/5] media: v4l UAPI: document ROI auto_controls Sergey Senozhatsky
2021-04-30 11:26 ` [PATCHv4 5/5] media: uvcvideo: add UVC 1.5 ROI control Sergey Senozhatsky
2021-04-30 12:49 ` [PATCHv4 0/5] media: uvcvideo: implement UVC 1.5 ROI Hans Verkuil
2021-05-01 1:58 ` Sergey Senozhatsky [this message]
2021-05-26 10:32 ` Hans Verkuil
2021-05-01 8:21 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIy1suAHDrArv8fz@google.com \
--to=senozhatsky@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox