From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0750CC47087 for ; Fri, 28 May 2021 09:25:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9A41613D1 for ; Fri, 28 May 2021 09:25:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234673AbhE1J0p (ORCPT ); Fri, 28 May 2021 05:26:45 -0400 Received: from mga12.intel.com ([192.55.52.136]:63474 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230127AbhE1J0n (ORCPT ); Fri, 28 May 2021 05:26:43 -0400 IronPort-SDR: 1L4+cdeu5GhIHAl0hs+b9cEEpCEMUTHrje0B0zqm7cZATHGUiR/VFIWMvBYTiAosUi6Z/zn03E H2cnG7dJjoDA== X-IronPort-AV: E=McAfee;i="6200,9189,9997"; a="182587330" X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="182587330" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2021 02:25:08 -0700 IronPort-SDR: fvRycI8A6hhTpE4Q/druGLrPzPSqqxIsuoI5iDzyefS3ZUUd7ausiZQMCwjh8+myopl3lO/VoX 5JmkwZ33tLRQ== X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="415238430" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2021 02:25:05 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lmYjm-00FHJC-Lu; Fri, 28 May 2021 12:25:02 +0300 Date: Fri, 28 May 2021 12:25:02 +0300 From: Andy Shevchenko To: Wolfram Sang , Hans de Goede , Mauro Carvalho Chehab , linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, Mika Westerberg , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman Subject: Re: [PATCH v1 1/6] i2c: acpi: Export i2c_acpi_find_client_by_adev() for users Message-ID: References: <20210526124322.48915-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, May 28, 2021 at 12:23:31PM +0300, Andy Shevchenko wrote: > On Thu, May 27, 2021 at 10:26:33PM +0200, Wolfram Sang wrote: > > On Wed, May 26, 2021 at 03:43:17PM +0300, Andy Shevchenko wrote: > > > There is at least one user that will gain from the > > > i2c_acpi_find_client_by_adev() being exported. > > > > No objections per se. But as the user is in staging, I want to ask if > > the use there is really a solution we would also accept outside of > > staging? Or is it a hack? > > The similar OF API is exported for users, although amount of users and their > locations are different. The AtomISP driver is not in the best shape, I agree, > but for now any possible steps to make it better would be good steps in my > opinion. Later we may see if we can do this piece of code differently (IIRC > current way is probably the best taking into account legacy platforms support). Btw, we may move all current exports from I2C ACPI to its own namespace, then we won't really care if it'e exported or not, only explicit consumers will use it. -- With Best Regards, Andy Shevchenko