public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC v2] MEDIA: Driver for ON Semi AR0521 camera sensor
Date: Fri, 25 Jun 2021 08:59:32 +0200	[thread overview]
Message-ID: <YNV+1JSdyjWDYfwp@kroah.com> (raw)
In-Reply-To: <m3h7hm4h14.fsf@t19.piap.pl>

On Fri, Jun 25, 2021 at 08:03:51AM +0200, Krzysztof Hałasa wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
> 
> > I would not waste my time on code that does not have a signed-off-by on
> > it, otherwise the developer is obviously saying they do not want to
> > merge this as-is.
> 
> I would want it be be merged as-is, and would happily supply a SOB, but
> nobody would merge it at this point. This isn't a problem, though.
> 
> > And I think we all have plenty of code from
> > developers that actually want to have their patches merged.
> 
> Oh well. I want to have *MY* patch merged. That's exactly why I did what
> I did. I did state that I will sign if off when I get positive response,
> when the patch is ready to be merged. Isn't it clear?

Not clear at all, this is not how kernel development works.

Developers submit changes they are comfortable with and wish to get
merged, and reviewers review them and merge them if all is good.

Do not submit stuff that you do not feel comfortable with having merged
as that just wastes reviewer's time.

Are you helping to review code that developers submit but say they do
not want to have merged?

best of luck!

greg k-h

  reply	other threads:[~2021-06-25  6:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 11:18 [RFC v2] MEDIA: Driver for ON Semi AR0521 camera sensor Krzysztof Hałasa
2021-06-22 11:57 ` Laurent Pinchart
2021-06-23  4:21   ` Krzysztof Hałasa
2021-06-23  4:31     ` Laurent Pinchart
2021-06-23  5:28       ` Krzysztof Hałasa
2021-06-23 13:17         ` Laurent Pinchart
2021-06-23 14:27           ` Kieran Bingham
2021-06-24  4:57             ` Krzysztof Hałasa
2021-06-24 12:10               ` Laurent Pinchart
2021-06-24 12:39                 ` Greg KH
2021-06-24 13:22                   ` Krzysztof Hałasa
2021-06-24 13:29                     ` Greg KH
2021-06-24 14:17                       ` Krzysztof Hałasa
2021-06-24 14:31                         ` Greg KH
2021-06-24 13:34                     ` Laurent Pinchart
2021-06-24 14:42                       ` Greg KH
2021-06-25  6:03                         ` Krzysztof Hałasa
2021-06-25  6:59                           ` Greg KH [this message]
2021-06-24 11:10   ` Mauro Carvalho Chehab
2021-06-24 13:51     ` Krzysztof Hałasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNV+1JSdyjWDYfwp@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=khalasa@piap.pl \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox