From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ECE2C2B9F4 for ; Fri, 25 Jun 2021 06:59:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A4FD61248 for ; Fri, 25 Jun 2021 06:59:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230003AbhFYHB6 (ORCPT ); Fri, 25 Jun 2021 03:01:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:56866 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229922AbhFYHB5 (ORCPT ); Fri, 25 Jun 2021 03:01:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7B5D661400; Fri, 25 Jun 2021 06:59:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624604375; bh=VKXj5JQQkxkDMTbPDvpRlNGDFjj0Beb4Z5ufAQkXQQI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zt6Xhe2YgP3mYsKF759VLR50hnx7/nKqYtI4PRBJR5wrvk3n03Y3SH8I2TwdLyitM ElOMsdrsW3AtGsZq/TYljY1oeiACAc0g8tl5bqBhW5/3ASzlI9Uo9QCzSeWWoMUBrM CBWIm3mv9EppDIcN63lPlk8HtmCSd3pP7+LYXf4Q= Date: Fri, 25 Jun 2021 08:59:32 +0200 From: Greg KH To: Krzysztof =?utf-8?Q?Ha=C5=82asa?= Cc: Laurent Pinchart , Kieran Bingham , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v2] MEDIA: Driver for ON Semi AR0521 camera sensor Message-ID: References: <42958029-5625-5f4d-a075-2f59a74e0fb5@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, Jun 25, 2021 at 08:03:51AM +0200, Krzysztof Hałasa wrote: > Greg KH writes: > > > I would not waste my time on code that does not have a signed-off-by on > > it, otherwise the developer is obviously saying they do not want to > > merge this as-is. > > I would want it be be merged as-is, and would happily supply a SOB, but > nobody would merge it at this point. This isn't a problem, though. > > > And I think we all have plenty of code from > > developers that actually want to have their patches merged. > > Oh well. I want to have *MY* patch merged. That's exactly why I did what > I did. I did state that I will sign if off when I get positive response, > when the patch is ready to be merged. Isn't it clear? Not clear at all, this is not how kernel development works. Developers submit changes they are comfortable with and wish to get merged, and reviewers review them and merge them if all is good. Do not submit stuff that you do not feel comfortable with having merged as that just wastes reviewer's time. Are you helping to review code that developers submit but say they do not want to have merged? best of luck! greg k-h