From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E21CFC636C8 for ; Tue, 20 Jul 2021 14:41:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD64C610CC for ; Tue, 20 Jul 2021 14:41:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240212AbhGTOAz (ORCPT ); Tue, 20 Jul 2021 10:00:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239313AbhGTNqE (ORCPT ); Tue, 20 Jul 2021 09:46:04 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9322EC0613B6 for ; Tue, 20 Jul 2021 07:24:08 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id a13so26187057wrf.10 for ; Tue, 20 Jul 2021 07:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=SFxqvandCjDRl0fUYEBNMfLKMtMBK/moBSvmGeLpe8A=; b=EDIWfob19WX9iUQJe1J5IXSmMhr8mlTZCU8guENY5JLlCWZ9hE8lw0Sh7rBstRSgOU /oxpS26rh8sbRuu6q5YmVHA7rd91a+uJgJZENH2FbZywAmR05gQQR01e6rwjkGwZO+4F aw1+W1Bwbpd+ggmfvL7ILmlGMfyqzbhgavun4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=SFxqvandCjDRl0fUYEBNMfLKMtMBK/moBSvmGeLpe8A=; b=HiGn6g4E75dBp7bHe0US4GBcBTeWqeo1R9Li5JEHE6NyW6zCnuJQzBiT7iKGcOS+RO hLvyOfGJvUPDfr10ympNTUvmsPErMt0e17q7TWeqqaEGdIsY0XcxZLxpBnlGOji3rz5Z JpcsVqdeAEG28Xzln1HT9l+BMVZFQxUwJPL6sYs7KPIo383NWVU4wADM8GjQvmx1DXvw 4zeQ63S56gknNRg9353L0EsEvTipcwMvd9NDMcBYMxu6PRXOQMwS5NlB7a0bc3iu4LxL FUqblJXArX10Ep9rKp42mLlTFRm6vN9M1F1cmFkaT+ItITH6HBFroFjdWoaoETTbWK8y 6yFA== X-Gm-Message-State: AOAM5310ZTPXsT6xg36bbwpd0tWEGCFDsFnqxrfs1bJC2EYVwGfBPu49 3SvZUaO95T+/d8rxAyPkKJWn+A== X-Google-Smtp-Source: ABdhPJyTvrKheJwNGUheDAAcCGTY+qv3s7J8bwr7G61A1ywBBEj71bQ7C/3g+gWu5XPyZIRFsUasCQ== X-Received: by 2002:a5d:63ca:: with SMTP id c10mr36112316wrw.163.1626791047204; Tue, 20 Jul 2021 07:24:07 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id p9sm12391582wrj.54.2021.07.20.07.24.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 07:24:06 -0700 (PDT) Date: Tue, 20 Jul 2021 16:24:04 +0200 From: Daniel Vetter To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: Rob Clark , dri-devel@lists.freedesktop.org, Rob Clark , freedreno@lists.freedesktop.org, Sai Prakash Ranjan , open list , Jonathan Marek , Emma Anholt , Bernard Zhao , Sharat Masetty , AngeloGioacchino Del Regno , Konrad Dybcio , Akhil P Oommen , Douglas Anderson , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Zhenzhong Duan , "Kristian H. Kristensen" , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Marijn Suijten , Lee Jones , Dave Airlie , "open list:DMA BUFFER SHARING FRAMEWORK" Subject: Re: [Linaro-mm-sig] [PATCH 00/11] drm/msm: drm scheduler conversion and cleanups Message-ID: Mail-Followup-To: Christian =?iso-8859-1?Q?K=F6nig?= , Rob Clark , dri-devel@lists.freedesktop.org, Rob Clark , freedreno@lists.freedesktop.org, Sai Prakash Ranjan , open list , Jonathan Marek , Emma Anholt , Bernard Zhao , Sharat Masetty , AngeloGioacchino Del Regno , Konrad Dybcio , Akhil P Oommen , Douglas Anderson , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Zhenzhong Duan , "Kristian H. Kristensen" , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Marijn Suijten , Lee Jones , Dave Airlie , "open list:DMA BUFFER SHARING FRAMEWORK" References: <20210717202924.987514-1-robdclark@gmail.com> <582b8869-f370-3803-60a8-df31088f8088@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux phenom 5.10.0-7-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Tue, Jul 20, 2021 at 04:16:56PM +0200, Christian König wrote: > Am 20.07.21 um 16:07 schrieb Daniel Vetter: > > On Mon, Jul 19, 2021 at 10:40:57AM +0200, Christian König wrote: > > > Am 17.07.21 um 22:29 schrieb Rob Clark: > > > > From: Rob Clark > > > > > > > > Conversion to gpu_scheduler, and bonus removal of > > > > drm_gem_object_put_locked() > > > Oh yes please! > > > > > > If I'm not completely mistaken that was the last puzzle piece missing to > > > unify TTMs and GEMs refcount of objects. > > Why does drm/msm, a driver not using ttm at all, block ttm refactorings? > > We can just check whether the TTM using driver is potentially using locked > > final unref and have a special version of > > drm_gem_object_put_guaranteed_unlocked or whatever the bikeshed will look > > like, which doesn't have the migth_lock. > > Because we now don't have any unrealistic lock inversion between > dev->struct_mutex and obj->resv lockdep can complain any more. Yeah I know, but we didn't have that since a while ago if you're limiting the audit to ttm using drivers. Which are the only ones that matter for this, the only thing that caused issues was object_put still being dev->struct_mutex infested for backwards compat. But even that changed a while ago I think. -Daniel > > Cheers, > Christian. > > > > > Anyway, deed is done now :-) > > -Daniel > > > > > Only problem is that I only see patch 7 and 9 in my inbox. Where is the > > > rest? > > > > > > Thanks, > > > Christian. > > > > > > > Rob Clark (11): > > > > drm/msm: Docs and misc cleanup > > > > drm/msm: Small submitqueue creation cleanup > > > > drm/msm: drop drm_gem_object_put_locked() > > > > drm: Drop drm_gem_object_put_locked() > > > > drm/msm/submit: Simplify out-fence-fd handling > > > > drm/msm: Consolidate submit bo state > > > > drm/msm: Track "seqno" fences by idr > > > > drm/msm: Return ERR_PTR() from submit_create() > > > > drm/msm: Conversion to drm scheduler > > > > drm/msm: Drop struct_mutex in submit path > > > > drm/msm: Utilize gpu scheduler priorities > > > > > > > > drivers/gpu/drm/drm_gem.c | 22 -- > > > > drivers/gpu/drm/msm/Kconfig | 1 + > > > > drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 4 +- > > > > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 6 +- > > > > drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +- > > > > drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 7 +- > > > > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 12 +- > > > > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- > > > > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 4 +- > > > > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 6 +- > > > > drivers/gpu/drm/msm/msm_drv.c | 30 +- > > > > drivers/gpu/drm/msm/msm_fence.c | 39 --- > > > > drivers/gpu/drm/msm/msm_fence.h | 2 - > > > > drivers/gpu/drm/msm/msm_gem.c | 91 +----- > > > > drivers/gpu/drm/msm/msm_gem.h | 37 ++- > > > > drivers/gpu/drm/msm/msm_gem_submit.c | 300 ++++++++++++-------- > > > > drivers/gpu/drm/msm/msm_gpu.c | 50 +--- > > > > drivers/gpu/drm/msm/msm_gpu.h | 41 ++- > > > > drivers/gpu/drm/msm/msm_ringbuffer.c | 70 ++++- > > > > drivers/gpu/drm/msm/msm_ringbuffer.h | 12 + > > > > drivers/gpu/drm/msm/msm_submitqueue.c | 49 +++- > > > > include/drm/drm_gem.h | 2 - > > > > include/uapi/drm/msm_drm.h | 10 +- > > > > 23 files changed, 440 insertions(+), 359 deletions(-) > > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch