From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4A4BC432BE for ; Thu, 2 Sep 2021 14:37:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AAFF261054 for ; Thu, 2 Sep 2021 14:37:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345405AbhIBOiO (ORCPT ); Thu, 2 Sep 2021 10:38:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345384AbhIBOiO (ORCPT ); Thu, 2 Sep 2021 10:38:14 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE3B8C061575 for ; Thu, 2 Sep 2021 07:37:15 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id u16so3313898wrn.5 for ; Thu, 02 Sep 2021 07:37:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=CT4LAspdSBwDkfapAAwxnh3D14vFcnZ3QM8rnn3hC1E=; b=hccyw/Ba5hg0YsYFQ1hC6F4QOU6QYLFs/YLEPT/bx5DPd9gLmKg7nBFjrR74RwDtdb xCoyWUJGIRQ5y5KsnR6a19WJV6B1JqA3VXG55x3t1SiI6rqGUB1DZOgJy9XCYj9E4vx3 htOiY2t7CjVWRQ2JzzOz2Y8bSfc8qkd5XU2SA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=CT4LAspdSBwDkfapAAwxnh3D14vFcnZ3QM8rnn3hC1E=; b=jUN0JCI2T0fjo8CNFpnYk5z5Kx2VTMcLN68G/x+7imlvnB/ZZwNsE7CGRocvSkgIUS F8Xx9nhJy+JCirsQ9VKAxe4fOf67hWQJsiEpMlZ8S0jJDzvXEfRXYIhN1x9Kf7j+kk11 rvyy4sPHeyoG+pXGQ33aX9U6M/BAe3U5/ilUGLJ/91kSjr8ZmOwBHu8S/TwHnIVXtWKt YynWpTQUXpe3sBSGMFFKXyfj6DkKj8s2voupt3Mj5rZIYzsEEDc8V/XkaBBrRhf6vuXE FMeOF6y8fDLp+XF8WT2w3ApHCc90rnNe9DfigD9sNtb+kmfgZrtVJ+RZ+QONr0NTNDi/ U92g== X-Gm-Message-State: AOAM532bDWmDyclr4d4ysKK04qYZ+FFMM1HW2Iuj2wIQteagPsY61GMu 1sMvjvXlJP7Gvac/Rd7ck31LVA== X-Google-Smtp-Source: ABdhPJw3CeDkQUgOa1ZqnOlCigj/LcT6+bjut2s4XIt/vXZTFskefL6mrH1JT9ZeSEabF6naeFODww== X-Received: by 2002:adf:c508:: with SMTP id q8mr4287862wrf.260.1630593434296; Thu, 02 Sep 2021 07:37:14 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id t14sm2035337wrw.59.2021.09.02.07.37.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 07:37:13 -0700 (PDT) Date: Thu, 2 Sep 2021 16:37:12 +0200 From: Daniel Vetter To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: dri-devel@lists.freedesktop.org, daniel@ffwll.ch, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH 1/2] dma-buf: clarify dma_fence_ops->wait documentation Message-ID: References: <20210901120240.7339-1-christian.koenig@amd.com> <20210901120240.7339-2-christian.koenig@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210901120240.7339-2-christian.koenig@amd.com> X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, Sep 01, 2021 at 02:02:39PM +0200, Christian König wrote: > This callback is pretty much deprecated and should not be used by new implementations. > > Clarify that in the documentation as well. > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter > --- > include/linux/dma-fence.h | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h > index 6ffb4b2c6371..a44e42b86c2a 100644 > --- a/include/linux/dma-fence.h > +++ b/include/linux/dma-fence.h > @@ -214,19 +214,15 @@ struct dma_fence_ops { > * Custom wait implementation, defaults to dma_fence_default_wait() if > * not set. > * > - * The dma_fence_default_wait implementation should work for any fence, as long > - * as @enable_signaling works correctly. This hook allows drivers to > - * have an optimized version for the case where a process context is > - * already available, e.g. if @enable_signaling for the general case > - * needs to set up a worker thread. > + * Deprecated and should not be used by new implementations. Only used > + * by existing implementations which need special handling for their > + * hardware reset procedure. > * > * Must return -ERESTARTSYS if the wait is intr = true and the wait was > * interrupted, and remaining jiffies if fence has signaled, or 0 if wait > * timed out. Can also return other error values on custom implementations, > * which should be treated as if the fence is signaled. For example a hardware > * lockup could be reported like that. > - * > - * This callback is optional. > */ > signed long (*wait)(struct dma_fence *fence, > bool intr, signed long timeout); > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch