From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A51C433FE for ; Wed, 8 Sep 2021 18:00:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 781326113D for ; Wed, 8 Sep 2021 18:00:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240197AbhIHSB6 (ORCPT ); Wed, 8 Sep 2021 14:01:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235092AbhIHSB4 (ORCPT ); Wed, 8 Sep 2021 14:01:56 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41B3AC061757 for ; Wed, 8 Sep 2021 11:00:47 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id n27so5883082eja.5 for ; Wed, 08 Sep 2021 11:00:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=FjMddd6JdOMGv2zR5AkGsbruNkJ2WJnwA4ML9l26Ntg=; b=h/thbqp2AXqJm3KuoLxS0MSVyghbMdZNZ/SPfJhS9SJxQyIJ5pOzbsxhd9UaZRnI+p CFEgz3jRmxulMN0CaBwFdvDuG5mUqyVt6fkEYzZu0uQdWzeVmGOHUWiKormP/Y7dzgE9 IcdgIY4Sk8Ft31k9qe+0u+W8UuXN4aP8Upn1M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=FjMddd6JdOMGv2zR5AkGsbruNkJ2WJnwA4ML9l26Ntg=; b=qSEnSPUb3NIMzg08/qHBX8jejUVCtJczrbUqt6CeN4wpWb27fYYVMD0T9XLT11q1Fd EWTiYsO+4SE2ybydR49MVw8LvR9fGJTTXXNMUAlnOWZWtfYkG5MBB1ERprsJpfuQw7nC R3SYTCMOcJQVPpX+j0I7mma4MFoAHnyl2A33zeD+8zimJRvXtN9kXtFfSGZsEyZknCOU 8bU4dhqDA8DNhpNAhDs8nFXh9dQ9NugIJjzzSUZxhX1IA0tstg+3EYcVs/wy3RW107YL LGa5/yLd4txe5LpzGpfCH7G4n0DQ2+vGKqOjBdCoQ9u8iIlu2x/v/sEakqdARqAEvTnP vXlw== X-Gm-Message-State: AOAM530VsR6uWTHQ2r2glQrJKhUX4vcKb0VJ72TPkl6pX2KSW8P1cj81 hA3CtH3Mxp9YDGSFoZmyhF3qSA== X-Google-Smtp-Source: ABdhPJxP00rpn4vKC4uI/DzFIyL0W94TxWGPF415ddLUFQDIRK8wcdXlFBHgzxiBag6dfD3mpal/Dw== X-Received: by 2002:a17:907:9617:: with SMTP id gb23mr1126172ejc.175.1631124045783; Wed, 08 Sep 2021 11:00:45 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id z8sm1411638ejd.94.2021.09.08.11.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 11:00:45 -0700 (PDT) Date: Wed, 8 Sep 2021 20:00:43 +0200 From: Daniel Vetter To: Rob Clark Cc: dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Daniel Vetter , Christian =?iso-8859-1?Q?K=F6nig?= , Michel =?iso-8859-1?Q?D=E4nzer?= , Pekka Paalanen , Rob Clark , Sumit Semwal , Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= , "open list:SYNC FILE FRAMEWORK" , open list Subject: Re: [PATCH v3 6/9] dma-buf/fence-array: Add fence deadline support Message-ID: Mail-Followup-To: Rob Clark , dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Christian =?iso-8859-1?Q?K=F6nig?= , Michel =?iso-8859-1?Q?D=E4nzer?= , Pekka Paalanen , Rob Clark , Sumit Semwal , Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= , "open list:SYNC FILE FRAMEWORK" , open list References: <20210903184806.1680887-1-robdclark@gmail.com> <20210903184806.1680887-7-robdclark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210903184806.1680887-7-robdclark@gmail.com> X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, Sep 03, 2021 at 11:47:57AM -0700, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > drivers/dma-buf/dma-fence-array.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/dma-buf/dma-fence-array.c b/drivers/dma-buf/dma-fence-array.c > index d3fbd950be94..8d194b09ee3d 100644 > --- a/drivers/dma-buf/dma-fence-array.c > +++ b/drivers/dma-buf/dma-fence-array.c > @@ -119,12 +119,23 @@ static void dma_fence_array_release(struct dma_fence *fence) > dma_fence_free(fence); > } > > +static void dma_fence_array_set_deadline(struct dma_fence *fence, > + ktime_t deadline) > +{ > + struct dma_fence_array *array = to_dma_fence_array(fence); > + unsigned i; > + > + for (i = 0; i < array->num_fences; ++i) > + dma_fence_set_deadline(array->fences[i], deadline); Hm I wonder whether this can go wrong, and whether we need Christian's massive fence iterator that I've seen flying around. If you nest these things too much it could all go wrong I think. I looked at other users which inspect dma_fence_array and none of them have a risk for unbounded recursion. Maybe check with Christian. -Daniel > +} > + > const struct dma_fence_ops dma_fence_array_ops = { > .get_driver_name = dma_fence_array_get_driver_name, > .get_timeline_name = dma_fence_array_get_timeline_name, > .enable_signaling = dma_fence_array_enable_signaling, > .signaled = dma_fence_array_signaled, > .release = dma_fence_array_release, > + .set_deadline = dma_fence_array_set_deadline, > }; > EXPORT_SYMBOL(dma_fence_array_ops); > > -- > 2.31.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch