From: Daniel Vetter <daniel@ffwll.ch>
To: "Christian König" <christian.koenig@amd.com>
Cc: Shunsuke Mie <mie@igel.co.jp>,
Sumit Semwal <sumit.semwal@linaro.org>,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-buf: Update obsoluted comments on dma_buf_vmap/vunmap()
Date: Wed, 13 Oct 2021 14:28:11 +0200 [thread overview]
Message-ID: <YWbQ28oOQnzg9cJS@phenom.ffwll.local> (raw)
In-Reply-To: <5ae41c5a-0ff4-5a82-2100-56bc415b5638@amd.com>
On Fri, Oct 08, 2021 at 02:09:41PM +0200, Christian König wrote:
> Am 08.10.21 um 13:20 schrieb Shunsuke Mie:
> > A comment for the dma_buf_vmap/vunmap() is not catching up a
> > corresponding implementation.
> >
> > Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
You're also pushing?
-Daniel
>
> > ---
> > drivers/dma-buf/dma-buf.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> > index beb504a92d60..7b619998f03a 100644
> > --- a/drivers/dma-buf/dma-buf.c
> > +++ b/drivers/dma-buf/dma-buf.c
> > @@ -1052,8 +1052,8 @@ EXPORT_SYMBOL_GPL(dma_buf_move_notify);
> > *
> > * Interfaces::
> > *
> > - * void \*dma_buf_vmap(struct dma_buf \*dmabuf)
> > - * void dma_buf_vunmap(struct dma_buf \*dmabuf, void \*vaddr)
> > + * void \*dma_buf_vmap(struct dma_buf \*dmabuf, struct dma_buf_map \*map)
> > + * void dma_buf_vunmap(struct dma_buf \*dmabuf, struct dma_buf_map \*map)
> > *
> > * The vmap call can fail if there is no vmap support in the exporter, or if
> > * it runs out of vmalloc space. Note that the dma-buf layer keeps a reference
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2021-10-13 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 11:20 [PATCH] dma-buf: Update obsoluted comments on dma_buf_vmap/vunmap() Shunsuke Mie
2021-10-08 12:09 ` Christian König
2021-10-13 12:28 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWbQ28oOQnzg9cJS@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mie@igel.co.jp \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox