From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1156AC433F5 for ; Wed, 13 Oct 2021 14:15:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5E44610A2 for ; Wed, 13 Oct 2021 14:15:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236535AbhJMOR1 (ORCPT ); Wed, 13 Oct 2021 10:17:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236491AbhJMOR0 (ORCPT ); Wed, 13 Oct 2021 10:17:26 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 449AAC061570 for ; Wed, 13 Oct 2021 07:15:23 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id g25so8973485wrb.2 for ; Wed, 13 Oct 2021 07:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=WfZtUnTgQXcuUIGw85OC0CUsD42sr1oPRAFFNuvZ6vU=; b=ExMubW21+4a97m5mSEFLHC9XE9MQ2rqhKXnFfUtb02KNCJ6frbMJapifImudEV85yE ZoSRmocQMD0h+MlCb+wna6t9fVtMP10RYA858x3kZZoI//0nLM9SWPKgo5N+WhoyqGqH HoAyDoNdNZagrHVtOf8MKVvQLwookmfLTFgtQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=WfZtUnTgQXcuUIGw85OC0CUsD42sr1oPRAFFNuvZ6vU=; b=tBr5sDannzx2Yg42ys5iT4OGf2lH43D3kauaYza2JUzXJkp+TLgziVeG87gWLpREpY vuYA9/PNc3phU5iQolHCb0NZ6SCUzZDKoxpKYLeyx+cRTvp41FcEifNeJ2XHqllB/Q+k ALCW0gLoD3l9ZMaGSsJ6x3UVWbZ4Mt4BnmEDZgv+i8BPrBgW/KJr/q8w/4Bsy3PTLmrJ 4tpHEmjpLYs6y3wSoWoCnReqqrgr6/Gg5qu3HoRehK+/IcaJBzroX9HjpaIi4/A8uAT6 1EyRn+YWJIdygZlSmiiVEvpDuQ853UwstdyDdJVZUqrYKvSHDELT6gIrQwJ1MXz8TMi9 3i3w== X-Gm-Message-State: AOAM531OJ17HRdQKsiohfuLK2BEYfBf3+8faFoiAJdkTfKa7rvvDjfc5 lVGkW2Hi+6f4YFBGVnmf/f4mvA== X-Google-Smtp-Source: ABdhPJxEdOAPir5NiPEsWYJ0b0z5FbQiLYs1r5nFHyg+GaXVx1ytCUeEH/1VyYHA7NvIhI+FT3AUsg== X-Received: by 2002:adf:a78a:: with SMTP id j10mr40605280wrc.231.1634134519349; Wed, 13 Oct 2021 07:15:19 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id b190sm5491879wmd.25.2021.10.13.07.15.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 07:15:18 -0700 (PDT) Date: Wed, 13 Oct 2021 16:15:17 +0200 From: Daniel Vetter To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, daniel@ffwll.ch, tvrtko.ursulin@linux.intel.com Subject: Re: [PATCH 15/28] drm/radeon: use new iterator in radeon_sync_resv Message-ID: References: <20211005113742.1101-1-christian.koenig@amd.com> <20211005113742.1101-16-christian.koenig@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211005113742.1101-16-christian.koenig@amd.com> X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Tue, Oct 05, 2021 at 01:37:29PM +0200, Christian König wrote: > Simplifying the code a bit. > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/radeon/radeon_sync.c | 22 +++------------------- > 1 file changed, 3 insertions(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_sync.c b/drivers/gpu/drm/radeon/radeon_sync.c > index 9257b60144c4..b991ba1bcd51 100644 > --- a/drivers/gpu/drm/radeon/radeon_sync.c > +++ b/drivers/gpu/drm/radeon/radeon_sync.c > @@ -91,33 +91,17 @@ int radeon_sync_resv(struct radeon_device *rdev, > struct dma_resv *resv, > bool shared) > { > - struct dma_resv_list *flist; > - struct dma_fence *f; > + struct dma_resv_iter cursor; > struct radeon_fence *fence; > - unsigned i; > + struct dma_fence *f; > int r = 0; > > - /* always sync to the exclusive fence */ > - f = dma_resv_excl_fence(resv); > - fence = f ? to_radeon_fence(f) : NULL; > - if (fence && fence->rdev == rdev) > - radeon_sync_fence(sync, fence); > - else if (f) > - r = dma_fence_wait(f, true); > - > - flist = dma_resv_shared_list(resv); > - if (shared || !flist || r) > - return r; > - > - for (i = 0; i < flist->shared_count; ++i) { > - f = rcu_dereference_protected(flist->shared[i], > - dma_resv_held(resv)); > + dma_resv_for_each_fence(&cursor, resv, shared, f) { > fence = to_radeon_fence(f); > if (fence && fence->rdev == rdev) > radeon_sync_fence(sync, fence); > else > r = dma_fence_wait(f, true); > - > if (r) > break; > } > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch