* [PATCH] staging: media: rkvdec: Constify static struct v4l2_m2m_ops
@ 2021-10-12 22:11 Rikard Falkeborn
2021-10-13 22:50 ` Ezequiel Garcia
2021-10-15 11:12 ` Kieran Bingham
0 siblings, 2 replies; 3+ messages in thread
From: Rikard Falkeborn @ 2021-10-12 22:11 UTC (permalink / raw)
To: Ezequiel Garcia, Mauro Carvalho Chehab
Cc: Greg Kroah-Hartman, linux-media, linux-rockchip, linux-staging,
linux-kernel, Rikard Falkeborn
The only usage of rkvdec_m2m_ops is to pass its address to v4l2_m2m_init(),
which takes a pointer to const v4l2_m2m_ops as argument. Make it const
to allow the compiler to put it in read-only memory.
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
drivers/staging/media/rkvdec/rkvdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
index bf00fe6534a3..28aab5c7fe33 100644
--- a/drivers/staging/media/rkvdec/rkvdec.c
+++ b/drivers/staging/media/rkvdec/rkvdec.c
@@ -677,7 +677,7 @@ static void rkvdec_device_run(void *priv)
rkvdec_job_finish(ctx, VB2_BUF_STATE_ERROR);
}
-static struct v4l2_m2m_ops rkvdec_m2m_ops = {
+static const struct v4l2_m2m_ops rkvdec_m2m_ops = {
.device_run = rkvdec_device_run,
};
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: media: rkvdec: Constify static struct v4l2_m2m_ops
2021-10-12 22:11 [PATCH] staging: media: rkvdec: Constify static struct v4l2_m2m_ops Rikard Falkeborn
@ 2021-10-13 22:50 ` Ezequiel Garcia
2021-10-15 11:12 ` Kieran Bingham
1 sibling, 0 replies; 3+ messages in thread
From: Ezequiel Garcia @ 2021-10-13 22:50 UTC (permalink / raw)
To: Rikard Falkeborn
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media,
linux-rockchip, linux-staging, linux-kernel
On Wed, Oct 13, 2021 at 12:11:44AM +0200, Rikard Falkeborn wrote:
> The only usage of rkvdec_m2m_ops is to pass its address to v4l2_m2m_init(),
> which takes a pointer to const v4l2_m2m_ops as argument. Make it const
> to allow the compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
> drivers/staging/media/rkvdec/rkvdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
> index bf00fe6534a3..28aab5c7fe33 100644
> --- a/drivers/staging/media/rkvdec/rkvdec.c
> +++ b/drivers/staging/media/rkvdec/rkvdec.c
> @@ -677,7 +677,7 @@ static void rkvdec_device_run(void *priv)
> rkvdec_job_finish(ctx, VB2_BUF_STATE_ERROR);
> }
>
> -static struct v4l2_m2m_ops rkvdec_m2m_ops = {
> +static const struct v4l2_m2m_ops rkvdec_m2m_ops = {
> .device_run = rkvdec_device_run,
> };
>
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: media: rkvdec: Constify static struct v4l2_m2m_ops
2021-10-12 22:11 [PATCH] staging: media: rkvdec: Constify static struct v4l2_m2m_ops Rikard Falkeborn
2021-10-13 22:50 ` Ezequiel Garcia
@ 2021-10-15 11:12 ` Kieran Bingham
1 sibling, 0 replies; 3+ messages in thread
From: Kieran Bingham @ 2021-10-15 11:12 UTC (permalink / raw)
To: Ezequiel Garcia, Mauro Carvalho Chehab, Rikard Falkeborn
Cc: Greg Kroah-Hartman, linux-media, linux-rockchip, linux-staging,
linux-kernel, Rikard Falkeborn
Quoting Rikard Falkeborn (2021-10-12 23:11:44)
> The only usage of rkvdec_m2m_ops is to pass its address to v4l2_m2m_init(),
> which takes a pointer to const v4l2_m2m_ops as argument. Make it const
> to allow the compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/staging/media/rkvdec/rkvdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
> index bf00fe6534a3..28aab5c7fe33 100644
> --- a/drivers/staging/media/rkvdec/rkvdec.c
> +++ b/drivers/staging/media/rkvdec/rkvdec.c
> @@ -677,7 +677,7 @@ static void rkvdec_device_run(void *priv)
> rkvdec_job_finish(ctx, VB2_BUF_STATE_ERROR);
> }
>
> -static struct v4l2_m2m_ops rkvdec_m2m_ops = {
> +static const struct v4l2_m2m_ops rkvdec_m2m_ops = {
> .device_run = rkvdec_device_run,
> };
>
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-15 11:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-12 22:11 [PATCH] staging: media: rkvdec: Constify static struct v4l2_m2m_ops Rikard Falkeborn
2021-10-13 22:50 ` Ezequiel Garcia
2021-10-15 11:12 ` Kieran Bingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox