From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Daniel Scally <djrscally@gmail.com>
Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
linux-media@vger.kernel.org, Yong Zhi <yong.zhi@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: Re: [PATCH v4 16/16] media: i2c: ov8865: Fix lockdep error
Date: Mon, 1 Nov 2021 13:31:34 +0200 [thread overview]
Message-ID: <YX/QFlAfbTzOQuEB@smile.fi.intel.com> (raw)
In-Reply-To: <20211101001119.46056-17-djrscally@gmail.com>
On Mon, Nov 01, 2021 at 12:11:19AM +0000, Daniel Scally wrote:
> From: Hans de Goede <hdegoede@redhat.com>
>
> ov8865_state_init() calls ov8865_state_mipi_configure() which uses
> __v4l2_ctrl_s_ctrl[_int64](). This means that sensor->mutex (which
> is also sensor->ctrls.handler.lock) must be locked before calling
> ov8865_state_init().
>
> Note ov8865_state_mipi_configure() is also used in other places where
> the lock is already held so it cannot be changed itself.
>
> This fixes the following lockdep kernel WARN:
> [ 13.233413] ------------[ cut here ]------------
You may drop this noisy line.
> [ 13.233421] WARNING: CPU: 0 PID: 8 at drivers/media/v4l2-core/v4l2-ctrls-api.c:833 __v4l2_ctrl_s_ctrl+0x4d/0x60 [videodev]
> ...
> [ 13.234063] Call Trace:
> [ 13.234074] ov8865_state_configure+0x98b/0xc00 [ov8865]
> [ 13.234095] ov8865_probe+0x4b1/0x54c [ov8865]
> [ 13.234117] i2c_device_probe+0x13c/0x2d0
Seems to me that this should be moved to the head of the series with Fixes tag
added.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-11-01 11:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 0:11 [PATCH v4 00/16] Extensions to ov8865 driver Daniel Scally
2021-11-01 0:11 ` [PATCH v4 01/16] media: i2c: Add ACPI support to ov8865 Daniel Scally
2021-11-01 10:01 ` Andy Shevchenko
2021-11-01 23:24 ` Daniel Scally
2021-11-01 0:11 ` [PATCH v4 02/16] media: i2c: Fix incorrect value in comment Daniel Scally
2021-11-01 0:11 ` [PATCH v4 03/16] media: i2c: Defer probe if not endpoint found Daniel Scally
2021-11-01 0:11 ` [PATCH v4 04/16] media: i2c: Support 19.2MHz input clock in ov8865 Daniel Scally
2021-11-01 10:29 ` Andy Shevchenko
2021-11-21 23:14 ` Daniel Scally
2021-11-01 14:52 ` Sakari Ailus
2021-11-20 22:46 ` Daniel Scally
2021-11-21 23:32 ` Daniel Scally
2021-11-01 0:11 ` [PATCH v4 05/16] media: i2c: Add .get_selection() support to ov8865 Daniel Scally
2021-11-01 0:11 ` [PATCH v4 06/16] media: i2c: Switch control to V4L2_CID_ANALOGUE_GAIN Daniel Scally
2021-11-01 0:11 ` [PATCH v4 07/16] media: i2c: Add vblank control to ov8865 Daniel Scally
2021-11-01 14:54 ` Sakari Ailus
2021-11-01 23:45 ` Daniel Scally
2021-11-02 9:26 ` Sakari Ailus
2021-11-01 0:11 ` [PATCH v4 08/16] media: i2c: Add hblank " Daniel Scally
2021-11-01 0:11 ` [PATCH v4 09/16] media: i2c: Update HTS values in ov8865 Daniel Scally
2021-11-01 15:04 ` Sakari Ailus
2021-11-22 0:18 ` Daniel Scally
2021-11-01 0:11 ` [PATCH v4 10/16] media: i2c: cap exposure at height + vblank " Daniel Scally
2021-11-01 0:11 ` [PATCH v4 11/16] media: i2c: Add controls from fwnode to ov8865 Daniel Scally
2021-11-01 0:11 ` [PATCH v4 12/16] media: i2c: Switch exposure control unit to lines Daniel Scally
2021-11-01 0:11 ` [PATCH v4 13/16] media: i2c: Re-order runtime pm initialisation Daniel Scally
2021-11-01 11:30 ` Andy Shevchenko
2021-11-02 8:30 ` Daniel Scally
2021-11-01 0:11 ` [PATCH v4 14/16] media: i2c: Use dev_err_probe() in ov8865 Daniel Scally
2021-11-01 0:11 ` [PATCH v4 15/16] media: ipu3-cio2: Add INT347A to cio2-bridge Daniel Scally
2021-11-01 0:11 ` [PATCH v4 16/16] media: i2c: ov8865: Fix lockdep error Daniel Scally
2021-11-01 11:31 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YX/QFlAfbTzOQuEB@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=djrscally@gmail.com \
--cc=hdegoede@redhat.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox