* [PATCH] drm/amdkfd: Use max() instead of doing it manually
@ 2021-12-03 9:31 Jiapeng Chong
2021-12-03 9:42 ` Ville Syrjälä
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-12-03 9:31 UTC (permalink / raw)
To: Felix.Kuehling
Cc: alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel,
sumit.semwal, amd-gfx, dri-devel, linux-kernel, linux-media,
linaro-mm-sig, Jiapeng Chong
Fix following coccicheck warning:
./drivers/gpu/drm/amd/amdkfd/kfd_svm.c:2193:16-17: WARNING opportunity
for max().
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index f2db49c..4f7e7b1 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -2190,7 +2190,7 @@ void schedule_deferred_list_work(struct svm_range_list *svms)
start = mni->interval_tree.start;
last = mni->interval_tree.last;
- start = (start > range->start ? start : range->start) >> PAGE_SHIFT;
+ start = max(start, range->start) >> PAGE_SHIFT;
last = (last < (range->end - 1) ? last : range->end - 1) >> PAGE_SHIFT;
pr_debug("[0x%lx 0x%lx] range[0x%lx 0x%lx] notifier[0x%lx 0x%lx] %d\n",
start, last, range->start >> PAGE_SHIFT,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/amdkfd: Use max() instead of doing it manually
2021-12-03 9:31 [PATCH] drm/amdkfd: Use max() instead of doing it manually Jiapeng Chong
@ 2021-12-03 9:42 ` Ville Syrjälä
0 siblings, 0 replies; 2+ messages in thread
From: Ville Syrjälä @ 2021-12-03 9:42 UTC (permalink / raw)
To: Jiapeng Chong
Cc: Felix.Kuehling, airlied, Xinhui.Pan, linux-kernel, amd-gfx,
linaro-mm-sig, dri-devel, alexander.deucher, christian.koenig,
linux-media
On Fri, Dec 03, 2021 at 05:31:53PM +0800, Jiapeng Chong wrote:
> Fix following coccicheck warning:
>
> ./drivers/gpu/drm/amd/amdkfd/kfd_svm.c:2193:16-17: WARNING opportunity
> for max().
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> index f2db49c..4f7e7b1 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> @@ -2190,7 +2190,7 @@ void schedule_deferred_list_work(struct svm_range_list *svms)
>
> start = mni->interval_tree.start;
> last = mni->interval_tree.last;
> - start = (start > range->start ? start : range->start) >> PAGE_SHIFT;
> + start = max(start, range->start) >> PAGE_SHIFT;
> last = (last < (range->end - 1) ? last : range->end - 1) >> PAGE_SHIFT;
There's an open coded min() on the very next line.
> pr_debug("[0x%lx 0x%lx] range[0x%lx 0x%lx] notifier[0x%lx 0x%lx] %d\n",
> start, last, range->start >> PAGE_SHIFT,
> --
> 1.8.3.1
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-03 9:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-03 9:31 [PATCH] drm/amdkfd: Use max() instead of doing it manually Jiapeng Chong
2021-12-03 9:42 ` Ville Syrjälä
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).