From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98165C433EF for ; Wed, 15 Dec 2021 21:11:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229598AbhLOVLF (ORCPT ); Wed, 15 Dec 2021 16:11:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229586AbhLOVLE (ORCPT ); Wed, 15 Dec 2021 16:11:04 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56BD9C061574 for ; Wed, 15 Dec 2021 13:11:04 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 668FF3F0; Wed, 15 Dec 2021 22:11:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1639602661; bh=m3+Mvj+MeKOGL8gocXZQgNBCsti3GwpmYaMPUFFYoXc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cIQqeYPmVhPDjMIJWquso0etgqvFflKWNOkShUj8O0Lkxpu5YlEgSOICfTA19twci QozqgSzeftseX5UmtvVKS59yn4VGgUQorX9n7el98NXslWAuthgBY8k8GUZy+qIvOY bYGZSDZyd9h4tLdBcebU/f8xQhc3HN7IXf/9nb+w= Date: Wed, 15 Dec 2021 23:10:59 +0200 From: Laurent Pinchart To: mchehab+huawei@kernel.org, Ariel D'Alessandro Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl, sean@mess.org, p.zabel@pengutronix.de, ezequiel@collabora.com, nicolas@ndufresne.ca, kieran.bingham@ideasonboard.com, gjasny@googlemail.com, xavier.claessens@collabora.com, nicolas.dufresne@collabora.com, user.vdr@gmail.com, sakari.ailus@iki.fi, rosenp@gmail.com Subject: Re: [v4l-utils v5 0/5] Add support for meson building Message-ID: References: <20210512184946.102863-1-ariel.dalessandro@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210512184946.102863-1-ariel.dalessandro@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Mauro, As I still haven't given up on getting this merged, I'd like to know what you would consider to be missing. Could you share a checklist of features that are needed and/or issues to be fixed for you to accept this series ? On Wed, May 12, 2021 at 03:49:41PM -0300, Ariel D'Alessandro wrote: > Hi all, > > Another attempt to support meson build, addressing comments/fixes from > reviewers. > > This patchset was developed on top of v4l-utils current master branch: > > commit f0c7e3d71eaf4182bae7eb3ee0e43b4eeb047ea9 > Author: Hans Verkuil > > v4l2-ctl: add '--set-edid type=list' support > > You can find the patchset pushed to the following branch: > > https://gitlab.collabora.com/adalessandro/v4l-utils/-/tree/v4l-utils-meson-v5 > > Feedback appreciated as always :-) > > Changes from v4: > > * Dropped install_subdir() work-around to install empty dir. Supported > now in meson v0.57. > * Bump to meson v0.57. Replaced deprecated methods. > * Added override_dependency() calls on libraries. > * Properly check for bpf and SDL2 dependencies. > * Removed libraries_private field from libv4lconvert pkgconfig. > * Documented meson static builds support. > * Set default compiler standard options. > * Added bpf check in keytable. > > Changes from v3: > > * Split Doxygen support patch. > * Properly generate config.h configuration file. > > Changes from v2: > > * Updated to current master branch. > * Moved README to markdown syntax. > * Documented meson build. > * Set PACKAGE_VERSION config macro as quoted. > > Changes from v1: > > * Updated project version to 1.21.0. > * Fixed clang includes in keytable bpf compilation. > * Improved variable reutilization in meson scripts. > * Set libraries version and soversion. > * Control symbol visibility. > * Install empty 'protocols' directory in keytable user dir. > * Fixed svg filenames in qv4l2 and qvidcap. > * Added support for Doxygen documentation (html and man). > * Updated required meson version to v0.53 (for fs module). > * Added new files to EXTRA_DIST in each Makefile.am. > > Regards, > > Ariel D'Alessandro (5): > Move README to markdown syntax > Add support for meson building > Copy Doxygen configuration file to doc/ > meson: Add support for doxygen documentation > Makefile.am: Distribute meson related files > > .gitignore | 1 + > INSTALL.meson.md | 142 + > Makefile.am | 5 +- > README | 274 -- > README.md | 332 +++ > contrib/Makefile.am | 3 +- > contrib/cobalt-ctl/Makefile.am | 2 + > contrib/cobalt-ctl/meson.build | 8 + > contrib/decode_tm6000/Makefile.am | 2 + > contrib/decode_tm6000/meson.build | 14 + > contrib/gconv/Makefile.am | 2 +- > contrib/gconv/meson.build | 44 + > contrib/meson.build | 13 + > contrib/rds-saa6588/Makefile.am | 2 + > contrib/rds-saa6588/meson.build | 7 + > contrib/test/Makefile.am | 3 +- > contrib/test/meson.build | 143 + > contrib/xc3028-firmware/Makefile.am | 2 +- > contrib/xc3028-firmware/meson.build | 11 + > doc/Doxyfile.in | 2352 +++++++++++++++++ > doc/meson.build | 34 + > lib/Makefile.am | 2 +- > lib/libdvbv5/Makefile.am | 2 +- > lib/libdvbv5/meson.build | 159 ++ > lib/libv4l-mplane/Makefile.am | 2 + > lib/libv4l-mplane/meson.build | 23 + > lib/libv4l1/Makefile.am | 2 +- > lib/libv4l1/meson.build | 62 + > lib/libv4l2/Makefile.am | 2 +- > lib/libv4l2/meson.build | 71 + > lib/libv4l2rds/Makefile.am | 2 + > lib/libv4l2rds/meson.build | 37 + > lib/libv4lconvert/Makefile.am | 2 +- > lib/libv4lconvert/meson.build | 117 + > lib/meson.build | 11 + > libdvbv5-po/meson.build | 3 + > meson.build | 334 +++ > meson_options.txt | 50 + > utils/Makefile.am | 2 +- > utils/cec-compliance/Makefile.am | 2 +- > utils/cec-compliance/meson.build | 22 + > utils/cec-ctl/Makefile.am | 2 +- > utils/cec-ctl/meson.build | 18 + > utils/cec-follower/Makefile.am | 2 +- > utils/cec-follower/meson.build | 19 + > utils/cx18-ctl/Makefile.am | 2 + > utils/cx18-ctl/meson.build | 8 + > utils/dvb/Makefile.am | 2 +- > utils/dvb/meson.build | 70 + > utils/gen_media_bus_format_codes.sh | 7 + > utils/gen_media_bus_format_names.sh | 7 + > utils/ir-ctl/Makefile.am | 2 + > utils/ir-ctl/meson.build | 23 + > utils/ivtv-ctl/Makefile.am | 2 + > utils/ivtv-ctl/meson.build | 13 + > utils/keytable/Makefile.am | 3 +- > utils/keytable/bpf_protocols/Makefile.am | 3 +- > .../bpf_protocols/clang_sys_includes.sh | 9 + > utils/keytable/bpf_protocols/meson.build | 31 + > utils/keytable/meson.build | 81 + > utils/keytable/rc_keymaps/meson.build | 151 ++ > utils/libcecutil/Makefile.am | 2 +- > utils/libcecutil/meson.build | 45 + > utils/libmedia_dev/Makefile.am | 2 +- > utils/libmedia_dev/meson.build | 14 + > utils/libv4l2util/Makefile.am | 2 +- > utils/libv4l2util/meson.build | 16 + > utils/media-ctl/Makefile.am | 2 + > utils/media-ctl/meson.build | 43 + > utils/meson.build | 46 + > utils/qv4l2/Makefile.am | 3 +- > utils/qv4l2/meson.build | 80 + > utils/qvidcap/Makefile.am | 3 +- > utils/qvidcap/meson.build | 82 + > utils/rds-ctl/Makefile.am | 1 + > utils/rds-ctl/meson.build | 13 + > utils/v4l2-compliance/Makefile.am | 2 +- > utils/v4l2-compliance/meson.build | 58 + > utils/v4l2-ctl/Makefile.am | 2 +- > utils/v4l2-ctl/meson.build | 75 + > utils/v4l2-dbg/Makefile.am | 2 +- > utils/v4l2-dbg/meson.build | 16 + > utils/v4l2-sysfs-path/Makefile.am | 2 + > utils/v4l2-sysfs-path/meson.build | 14 + > v4l-utils-po/meson.build | 3 + > 85 files changed, 4987 insertions(+), 299 deletions(-) > create mode 100644 INSTALL.meson.md > delete mode 100644 README > create mode 100644 README.md > create mode 100644 contrib/cobalt-ctl/meson.build > create mode 100644 contrib/decode_tm6000/meson.build > create mode 100644 contrib/gconv/meson.build > create mode 100644 contrib/meson.build > create mode 100644 contrib/rds-saa6588/meson.build > create mode 100644 contrib/test/meson.build > create mode 100644 contrib/xc3028-firmware/meson.build > create mode 100644 doc/Doxyfile.in > create mode 100644 doc/meson.build > create mode 100644 lib/libdvbv5/meson.build > create mode 100644 lib/libv4l-mplane/meson.build > create mode 100644 lib/libv4l1/meson.build > create mode 100644 lib/libv4l2/meson.build > create mode 100644 lib/libv4l2rds/meson.build > create mode 100644 lib/libv4lconvert/meson.build > create mode 100644 lib/meson.build > create mode 100644 libdvbv5-po/meson.build > create mode 100644 meson.build > create mode 100644 meson_options.txt > create mode 100644 utils/cec-compliance/meson.build > create mode 100644 utils/cec-ctl/meson.build > create mode 100644 utils/cec-follower/meson.build > create mode 100644 utils/cx18-ctl/meson.build > create mode 100644 utils/dvb/meson.build > create mode 100755 utils/gen_media_bus_format_codes.sh > create mode 100755 utils/gen_media_bus_format_names.sh > create mode 100644 utils/ir-ctl/meson.build > create mode 100644 utils/ivtv-ctl/meson.build > create mode 100755 utils/keytable/bpf_protocols/clang_sys_includes.sh > create mode 100644 utils/keytable/bpf_protocols/meson.build > create mode 100644 utils/keytable/meson.build > create mode 100644 utils/keytable/rc_keymaps/meson.build > create mode 100644 utils/libcecutil/meson.build > create mode 100644 utils/libmedia_dev/meson.build > create mode 100644 utils/libv4l2util/meson.build > create mode 100644 utils/media-ctl/meson.build > create mode 100644 utils/meson.build > create mode 100644 utils/qv4l2/meson.build > create mode 100644 utils/qvidcap/meson.build > create mode 100644 utils/rds-ctl/meson.build > create mode 100644 utils/v4l2-compliance/meson.build > create mode 100644 utils/v4l2-ctl/meson.build > create mode 100644 utils/v4l2-dbg/meson.build > create mode 100644 utils/v4l2-sysfs-path/meson.build > create mode 100644 v4l-utils-po/meson.build -- Regards, Laurent Pinchart