public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: "Marko Mäkelä" <marko.makela@iki.fi>
To: Sean Young <sean@mess.org>
Cc: linux-media@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: Re: Inconsistent RC5 ir-keytable events
Date: Mon, 3 Jan 2022 14:21:03 +0200	[thread overview]
Message-ID: <YdLqL2ViSwWzS/Ig@jyty> (raw)
In-Reply-To: <20220103110743.GA22001@gofer.mess.org>

Hi Sean,

Mon, Jan 03, 2022 at 11:07:43AM +0000, Sean Young wrote:
>I am not sure if the naked eye can observe a delay of 200ms rather than 
>100ms.

I thought that I might be able to distinguish "fast blinking" (5Hz or 
200ms) and "very fast blinking" (10Hz or 100ms), but I am not so sure 
anymore.

>This is the timeout field on rcdev. I think it is set here:
>
>https://git.linuxtv.org/media_tree.git/tree/drivers/media/usb/dvb-usb-v2/rtl28xxu.c#n1810
>
>I think the interval is to set to value which is much to high; I think 
>the 211 ms comes from this 200 value here. So, I think if you lower 
>this to 100 then your problems might go away.

According to my old notes from this RCU, the repeat period was slightly 
less than 110ms. In fact, the 212ms value from my output could be 
2*106ms.

>I had forgotten that that for the delay between key down and key up, 
>this also adds the repeat period for the protocol, see
>https://git.linuxtv.org/media_tree.git/tree/drivers/media/rc/rc-main.c#n857
>
>So actually that is 110ms + 9741us ≈ 119m, which is near enough the 
>values seen above. I suspect the issue is the interval but please 
>experiment.

If the correct threshold is 106ms and your suggestion of 100 does not 
work, I will try a lower value, such as 94 or 95, to get 94+9.741 < 106.

I will get back to you once I have tested the change, hopefully during 
this week.

	Marko

  reply	other threads:[~2022-01-03 12:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <YdKdPosyzj2urFpS@jyty>
2022-01-03  9:21 ` Inconsistent RC5 ir-keytable events Sean Young
2022-01-03 10:35   ` Marko Mäkelä
2022-01-03 11:07     ` Sean Young
2022-01-03 12:21       ` Marko Mäkelä [this message]
2022-01-04 16:07         ` Marko Mäkelä
2022-01-05  9:53           ` Sean Young
2022-01-06 11:41             ` Marko Mäkelä
2022-01-13 16:55               ` Sean Young
2022-01-14  6:31                 ` Marko Mäkelä
2022-01-29 17:15                   ` Marko Mäkelä
2022-02-08 16:46                     ` Sean Young
2022-02-09  8:12                       ` Marko Mäkelä
2022-02-12 11:16                         ` Sean Young
2022-02-12 16:34                           ` Sean Young
2022-02-13 17:12                             ` Marko Mäkelä
2022-03-26 18:44                               ` Marko Mäkelä
2022-04-10 14:07                                 ` Marko Mäkelä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YdLqL2ViSwWzS/Ig@jyty \
    --to=marko.makela@iki.fi \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=sean@mess.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox