From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C57F0C433FE for ; Tue, 8 Feb 2022 16:51:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383559AbiBHQvH (ORCPT ); Tue, 8 Feb 2022 11:51:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352392AbiBHQvG (ORCPT ); Tue, 8 Feb 2022 11:51:06 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E91D2C061576; Tue, 8 Feb 2022 08:51:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644339065; x=1675875065; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=LQ2TSOan0gGSwFS9dmZ5mUhQvRTUXTQik0dQLzJOjk0=; b=PIfwvJLIL7HCmshYXmW3p4v3Xw4IHgoKMKQ44r/bOmkJ1HfwF8irsCfy Xb/pyb6ID1+V7xE8WMkc/trI/Mt6ElFdRwb02mTUqzG/GR4AKsQEpzrFm Dcu441DVHURBT/wuu8NlxhpGlRPdL5QYZRb6R+UNlBlhZxNmKdOBuZwoX IwHlnSxybSw6Cx4xPdOcWx8tvDoy2RARQjUk6+RJRKk4LIKFu20ZQ1EuE X5Vs8z8qCeHy743wPfNnTJAE55UsCcVb8kueFut1oahFi/OIusebN5/Qx 0dLMhXJ2nz/M8C7cpMW5MAtJWZ3ikzoAB/HmmrHdAyxiB7x8AyBQlokuw Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="273524587" X-IronPort-AV: E=Sophos;i="5.88,353,1635231600"; d="scan'208";a="273524587" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 08:51:05 -0800 X-IronPort-AV: E=Sophos;i="5.88,353,1635231600"; d="scan'208";a="525616268" Received: from punajuuri.fi.intel.com (HELO paasikivi.fi.intel.com) ([10.237.72.43]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 08:51:03 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 51060203BC; Tue, 8 Feb 2022 18:51:01 +0200 (EET) Date: Tue, 8 Feb 2022 18:51:01 +0200 From: Sakari Ailus To: Laurent Pinchart Cc: linux-media@vger.kernel.org, Jacopo Mondi , Rob Herring , devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/2] media: dt-bindings: media: i2c: Add MT9M114 camera sensor binding Message-ID: References: <20220207012055.15158-1-laurent.pinchart@ideasonboard.com> <20220207012055.15158-2-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207012055.15158-2-laurent.pinchart@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Laurent, On Mon, Feb 07, 2022 at 03:20:54AM +0200, Laurent Pinchart wrote: > Add device tree binding for the onsemi MT9M114 CMOS camera sensor. > > Signed-off-by: Laurent Pinchart > --- > Changes since v1: > > - Use graph schema > - Drop unneeded properties > - Rename ON Semiconductor to onsemi > --- > .../bindings/media/i2c/onnn,mt9m114.yaml | 110 ++++++++++++++++++ > MAINTAINERS | 7 ++ > 2 files changed, 117 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml > new file mode 100644 > index 000000000000..55b67833f9a1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml > @@ -0,0 +1,110 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/onnn,mt9m114.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: onsemi 1/6-inch 720p CMOS Digital Image Sensor > + > +maintainers: > + - Laurent Pinchart > + > +description: |- > + The onsemi MT9M114 is a 1/6-inch 720p (1.26 Mp) CMOS digital image sensor > + with an active pixel-array size of 1296H x 976V. It is programmable through > + an I2C interface and outputs image data over a 8-bit parallel or 1-lane MIPI > + CSI-2 connection. > + > +properties: > + compatible: > + const: onnn,mt9m114 > + > + reg: > + description: I2C device address > + enum: > + - 0x48 > + - 0x5d > + > + clocks: > + description: EXTCLK clock signal > + maxItems: 1 > + > + vdd-supply: > + description: > + Core digital voltage supply, 1.8V > + > + vddio-supply: > + description: > + I/O digital voltage supply, 1.8V or 2.8V > + > + vaa-supply: > + description: > + Analog voltage supply, 2.8V > + > + reset-gpios: > + description: |- > + Reference to the GPIO connected to the RESET_BAR pin, if any (active > + low). > + > + port: > + $ref: /schemas/graph.yaml#/$defs/port-base > + additionalProperties: false > + > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + additionalProperties: false > + > + properties: > + bus-type: > + enum: [4, 5, 6] With bus-type 5, shouldn't you have the parallel interface sync signal polarity properties? Possibly also others if the hardware supports them. > + > + remote-endpoint: true > + > + # The number and mapping of lanes (for CSI-2), and the bus width and > + # signal polarities (for parallel and BT.656) are fixed and must not > + # be specified. > + > + required: > + - bus-type > + > +required: > + - compatible > + - reg > + - clocks > + - vdd-supply > + - vddio-supply > + - vaa-supply > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + i2c0 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + sensor@48 { > + compatible = "onnn,mt9m114"; > + reg = <0x48>; > + > + clocks = <&clk24m 0>; > + > + reset-gpios = <&gpio5 21 GPIO_ACTIVE_LOW>; > + > + vddio-supply = <®_cam_1v8>; > + vdd-supply = <®_cam_1v8>; > + vaa-supply = <®_2p8v>; > + > + port { > + endpoint { > + bus-type = <4>; > + remote-endpoint = <&mipi_csi_in>; > + }; > + }; > + }; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index f41088418aae..e9919a359c12 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -13096,6 +13096,13 @@ T: git git://linuxtv.org/media_tree.git > F: drivers/media/i2c/mt9m032.c > F: include/media/i2c/mt9m032.h > > +MT9M114 ONSEMI SENSOR DRIVER > +M: Laurent Pinchart > +L: linux-media@vger.kernel.org > +S: Maintained > +T: git git://linuxtv.org/media_tree.git > +F: Documentation/devicetree/bindings/media/i2c.onnn,mt9m114.yaml > + > MT9P031 APTINA CAMERA SENSOR > M: Laurent Pinchart > L: linux-media@vger.kernel.org -- Regards, Sakari Ailus