Re: [PATCH v2 33/66] media: sun6i-csi: Rework register definitions, invert misleading fields

Paul Kocialkowski
2022-02-11T15:17:32Z

[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]

Hi,

On Wed 09 Feb 22, 10:39, Maxime Ripard wrote:
> On Sat, Feb 05, 2022 at 07:53:56PM +0100, Paul Kocialkowski wrote:
> > This cleans up the register definitions a bit, adds a prefix, remove masks.
> > Registers are now fully defined, some additional fields were added when
> > needed. New format definitions are added for future use.
> >
> > Some fields are wrongly defined (inverted) in Allwinner litterature
> > (e.g. field vs frame prefixes), which is quite misleading. They are
> > now corrected to reflect their actual behavior.
>
> How was it tested?
>
> In particular, see
> https://lore.kernel.org/all/20180305093535.11801-7-maxime.ripard@bootlin.com/

No oscilloscope testing on my side to investigate the matter in depth,
so the polarities inversion is based on what you changed in the driver.

The idea is to change the register definitions to match what the hardware
appears to be doing (based on your good look at the oscilloscope) to avoid
the confusion of setting register fields that look contradictory.
It's just a rename and the behavior remains the same.

Paul

--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]