Re: [PATCH v2 32/66] media: sun6i-csi: Add capture state using vsync for page flip

Maxime Ripard
2022-02-09T10:16:56Z

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

On Sat, Feb 05, 2022 at 07:53:55PM +0100, Paul Kocialkowski wrote:
> This introduces a new state structure and associated helpers for
> capture, which handles the buffer queue and state for each submitted
> buffer.
>
> Besides from the code refactoring, this changes the page flip point
> to vsync instead of frame done, which allows working with only
> two buffers without losing frames. This is apparently a more
> appropriate thing to do with this controller.

Why? What issues were you seeing before, how does using a separate
interrupt addresses it, and what makes you think it's more appropriate?

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]