From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA0C0C433F5 for ; Sun, 20 Feb 2022 22:42:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244739AbiBTWmV (ORCPT ); Sun, 20 Feb 2022 17:42:21 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236661AbiBTWmU (ORCPT ); Sun, 20 Feb 2022 17:42:20 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE444BC85 for ; Sun, 20 Feb 2022 14:41:56 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5214025B; Sun, 20 Feb 2022 23:41:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1645396914; bh=ai+akVvNXyQ+A81jPhhzZ/hhJOmQdZZvW7ZnYVtz0aw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VSwlv5uP9L2X8fgIljUy6RadPrBeDV5Gcxbnzl/sx9dqBMLfv2M+Na8aDDTPIytDq VozSYfIxHySwR8NgdP6ORynPP8YeT3/B4fgDEn/q/iK2TvM/rVZ12UKMRpCsDSfTaV wrNMO7GswrWRL06SmRQ/EAeRj9gDV1HptJJ2i7c8= Date: Mon, 21 Feb 2022 00:41:45 +0200 From: Laurent Pinchart To: Adam Ford Cc: Jacopo Mondi , Steve Longerbeam , Philipp Zabel , Shawn Guo , Sascha Hauer , Fabio Estevam , Mauro Carvalho Chehab , Hans Verkuil , martin.kepplinger@puri.sm, rmfrfs@gmail.com, xavier.roumegue@oss.nxp.com, Alexander Stein , dorota.czaplejewicz@puri.sm, Sascha Hauer , NXP Linux Team , linux-media , "open list:STAGING SUBSYSTEM" , arm-soc Subject: Re: [PATCH v2 0/7] media: imx: Destage imx7-mipi-csis Message-ID: References: <20220218183421.583874-1-jacopo@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Adam, On Sun, Feb 20, 2022 at 12:19:30PM -0600, Adam Ford wrote: > On Sun, Feb 20, 2022 at 8:56 AM Jacopo Mondi wrote: > > > > Hello > > this series includes patches from two series previously sent: > > https://lore.kernel.org/linux-media/20220119112024.11339-1-jacopo@jmondi.org/ > > https://lore.kernel.org/linux-media/20220211180216.290133-1-jacopo@jmondi.org/ > > v1: > > https://lore.kernel.org/linux-media/20220214184318.409208-1-jacopo@jmondi.org/T/#t > > > > Which can now be marked as superseded. > > > > The first 2 patches performs the de-staging of the imx7-mipi-csis driver and > > are now reviewed. > > > > The rest of the series builds on top of the comment received on: > > https://lore.kernel.org/linux-media/20220119112024.11339-3-jacopo@jmondi.org/ > > > > If DUAL pixel mode is used in the CSIS driver, then the CSI block of the IMX8MM > > SoC needs to be operated in dual mode as well. To do so, use the image format > > sample size to determine in the CSI bridge if dual or single mode should be > > used. > > > > Laurent could you test on MM to see if it works now ? > > Jacopo, > > Do you have a repo I can clone? If not, I need to know which branch > to apply to the series. I have an 8MM with an OV5640, and I'm willing > to test if Laurent can't. I've applied the patches on top of v5.17-rc4 plus a few backports, and pushed the result to https://gitlab.com/ideasonboard/nxp/linux/-/tree/pinchartl/v5.17/csis. > > On top two small patches I was carrying in my tree to add more formats to the > > CSIS driver, the last one with the caveat that RGB24 is transmitted on the wire > > with one format and stored in memory with a different one. > > > > Series based on top of the most recent media master branch. > > > > Thanks > > j > > > > v1->v2: > > - Remove per-SoC handling in CSI bridge and only use image formats > > - Add TODO note to the staging driver > > - Fix PIXEL_DUAL mode comments for imx-mipi-csis > > - Add output format translation to imx-mipi-csis to handle RGB24 > > > > Jacopo Mondi (7): > > media: imx: De-stage imx7-mipi-csis > > media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c > > media: imx: imx7-media-csi: Use dual sampling for YUV 1X16 > > media: imx: imx-mipi-csis: Set PIXEL_MODE for YUV422 > > media: imx: imx-mipi-csis: Add RGB565_1X16 > > media: imx: imx-mipi-csis: Add BGR888 > > media: imx: imx-mipi-csis: Add output format > > > > Documentation/admin-guide/media/imx7.rst | 2 +- > > ...-mipi-csi2.yaml => nxp,imx-mipi-csi2.yaml} | 2 +- > > MAINTAINERS | 4 +- > > drivers/media/platform/Kconfig | 1 + > > drivers/media/platform/Makefile | 1 + > > drivers/media/platform/imx/Kconfig | 24 ++++++++ > > drivers/media/platform/imx/Makefile | 1 + > > .../platform/imx/imx-mipi-csis.c} | 59 +++++++++++++++++-- > > drivers/staging/media/imx/Makefile | 1 - > > drivers/staging/media/imx/TODO | 26 ++++++++ > > drivers/staging/media/imx/imx7-media-csi.c | 8 ++- > > 11 files changed, 117 insertions(+), 12 deletions(-) > > rename Documentation/devicetree/bindings/media/{nxp,imx7-mipi-csi2.yaml => nxp,imx-mipi-csi2.yaml} (98%) > > create mode 100644 drivers/media/platform/imx/Kconfig > > create mode 100644 drivers/media/platform/imx/Makefile > > rename drivers/{staging/media/imx/imx7-mipi-csis.c => media/platform/imx/imx-mipi-csis.c} (95%) -- Regards, Laurent Pinchart