From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CE8AC433EF for ; Tue, 8 Mar 2022 12:14:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346733AbiCHMPE (ORCPT ); Tue, 8 Mar 2022 07:15:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237459AbiCHMPC (ORCPT ); Tue, 8 Mar 2022 07:15:02 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACE92419B9 for ; Tue, 8 Mar 2022 04:14:06 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BCF11488; Tue, 8 Mar 2022 13:14:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1646741645; bh=cp9new5L1lG9283IQsS9fdbpD0V3aXIWRmt4tjxShJo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Au8BZSWNeHRRoKDBhQKOWqMpsObRHgULiBFB0MSyzSMBaoTWCuskP5Ve9wU6P9sre ZwH3RoF6YP63kiz5CzASgU9DeUHzBsLDCl/LnortqOsmU4iY2vDozFttIBfTb8l/8I kYO2xcXHcSNl6eauZRzwUZx4diTertCEsK1fHxos= Date: Tue, 8 Mar 2022 14:13:51 +0200 From: Laurent Pinchart To: Arec Kao Cc: linux-media@vger.kernel.org, sakari.ailus@linux.intel.com, andy.yeh@intel.com, tfiga@google.com Subject: Re: [PATCH 2/2] Re-run BLC when gain change Message-ID: References: <20220308033839.3773-1-arec.kao@intel.com> <20220308033839.3773-2-arec.kao@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220308033839.3773-2-arec.kao@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Arec, Thank you for the patch. On Tue, Mar 08, 2022 at 11:38:39AM +0800, Arec Kao wrote: > Changing the gain affects the black-level through the device; > the gain should therefore not be changed during a BLC procedure. > If the gain changes, then the BLC routine should be re-run > in some scenarios. > > Signed-off-by: Arec Kao > --- > .../userspace-api/media/v4l/ext-ctrls-image-source.rst | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst > index 71f23f131f97..5ee53ba76d46 100644 > --- a/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst > +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst > @@ -59,6 +59,11 @@ Image Source Control IDs > non-sensitive. > This control is required for automatic calibration of sensors/cameras. > > +``V4L2_CID_BLC (integer)`` > + Changing the gain affects the black-level through the device; the gain > + should therefore not be changed during a BLC procedure. If the gain > + changes, the BLC routine should be re-run in some scenarios. This doesn't tell me what the control does. > + > .. c:type:: v4l2_area > > .. flat-table:: struct v4l2_area -- Regards, Laurent Pinchart