From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Jacopo Mondi <jacopo@jmondi.org>,
Steve Longerbeam <slongerbeam@gmail.com>,
sakari.ailus@iki.fi, hverkuil-cisco@xs4all.nl,
mirela.rabulea@nxp.com, xavier.roumegue@oss.nxp.com,
hugues.fruchet@st.com, prabhakar.mahadev-lad.rj@bp.renesas.com,
aford173@gmail.com, festevam@gmail.com,
Eugen.Hristev@microchip.com, jbrunet@baylibre.com,
paul.elder@ideasonboard.com,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v5 00/27] media: ov5640: Rework the clock tree programming for MIPI
Date: Wed, 23 Mar 2022 10:59:09 +0200 [thread overview]
Message-ID: <YjrhXefKYaPdx55B@pendragon.ideasonboard.com> (raw)
In-Reply-To: <7c082420-63f4-0520-21a2-7e10a1e2c321@ideasonboard.com>
Hi Tomi,
On Wed, Mar 23, 2022 at 10:51:04AM +0200, Tomi Valkeinen wrote:
> On 24/02/2022 11:42, Jacopo Mondi wrote:
> > v1:
> > https://patchwork.linuxtv.org/project/linux-media/list/?series=7249
> > v2:
> > https://patchwork.linuxtv.org/project/linux-media/list/?series=7311
> > v3:
> > https://patchwork.linuxtv.org/project/linux-media/list/?series=7385
> > v4:
> > https://patchwork.linuxtv.org/project/linux-media/list/?series=7389
> >
> > A branch for testing based on the most recent media-master is available at
> > https://git.sr.ht/~jmondi_/linux #jmondi/media-master/ov5640-v5
>
> I tested these with DRA76 EVM & CAL, using CAL's legacy non-MC mode. It
> doesn't work. I think there are two problems:
>
> - CAL uses mbus codes like MEDIA_BUS_FMT_UYVY8_2X8 for CSI-2, not 1X16.
> OV5640 used to support 2X8, but now it doesn't.
>
> - OV5640 sets the default code to MEDIA_BUS_FMT_UYVY8_2X8, even for
> CSI-2 where it doesn't support MEDIA_BUS_FMT_UYVY8_2X8.
>
> I'd like to just change CAL and drop the 2X8 support and instead use
> 1X16, but then any sensor that uses 2X8 would work. So I guess I need to
> change the code to support both.
We really need to phase out 2X8 for CSI-2. Can you add a warning in that
case if you support both ?
> Anyway, both of those issues might also surface on other platforms, as
> ov5640 behavior has changed.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-03-23 8:59 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 9:42 [PATCH v5 00/27] media: ov5640: Rework the clock tree programming for MIPI Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 01/27] media: ov5640: Add pixel rate to modes Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 02/27] media: ov5604: Re-arrange modes definition Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 03/27] media: ov5640: Add ov5640_is_csi2() function Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 04/27] media: ov5640: Associate bpp with formats Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 05/27] media: ov5640: Add LINK_FREQ control Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 06/27] media: ov5640: Update pixel_rate and link_freq Jacopo Mondi
2022-04-07 16:25 ` Hugues FRUCHET - FOSS
2022-04-11 16:46 ` Jacopo Mondi
2022-04-26 13:34 ` Hugues FRUCHET - FOSS
2022-02-24 9:42 ` [PATCH v5 07/27] media: ov5640: Rework CSI-2 clock tree Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 08/27] media: ov5640: Rework timings programming Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 09/27] media: ov5640: Fix 720x480 in RGB888 mode Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 10/27] media: ov5640: Split DVP and CSI-2 timings Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 11/27] media: ov5640: Provide timings accessor Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 12/27] media: ov5640: Re-sort per-mode register tables Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 13/27] media: ov5640: Remove duplicated mode settings Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 14/27] media: ov5640: Remove ov5640_mode_init_data Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 15/27] media: ov5640: Add HBLANK control Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 16/27] media: ov5640: Add VBLANK control Jacopo Mondi
2022-04-07 16:25 ` Hugues FRUCHET - FOSS
2022-04-11 15:42 ` Jacopo Mondi
2022-04-26 12:53 ` Hugues FRUCHET - FOSS
2022-04-26 13:58 ` Jacopo Mondi
2022-04-26 14:32 ` Hugues FRUCHET - FOSS
2022-02-24 9:43 ` [PATCH v5 17/27] media: ov5640: Change CSI-2 timings to comply with FPS Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 18/27] media: ov5640: Implement init_cfg Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 19/27] media: ov5640: Implement get_selection Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 20/27] media: ov5640: Limit frame_interval to DVP mode only Jacopo Mondi
2022-04-07 16:25 ` Hugues FRUCHET - FOSS
2022-04-08 16:08 ` Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 21/27] media: ov5640: Register device properties Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 22/27] media: ov5640: Add RGB565_1X16 format Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 23/27] media: ov5640: Add BGR888 format Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 24/27] media: ov5640: Restrict sizes to mbus code Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 25/27] media: ov5640: Adjust format to bpp in s_fmt Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 26/27] media: ov5640: Split DVP and CSI-2 formats Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 27/27] media: ov5640: Move format mux config in format Jacopo Mondi
2022-03-04 0:09 ` [PATCH v5 00/27] media: ov5640: Rework the clock tree programming for MIPI Sakari Ailus
2022-03-04 8:41 ` Eugen.Hristev
2022-03-04 8:45 ` Jacopo Mondi
2022-03-04 8:52 ` Sakari Ailus
2022-03-23 8:51 ` Tomi Valkeinen
2022-03-23 8:54 ` Sakari Ailus
2022-03-23 8:59 ` Laurent Pinchart [this message]
2022-03-23 9:50 ` Jacopo Mondi
2022-03-23 10:41 ` Laurent Pinchart
2022-03-28 14:57 ` Jacopo Mondi
2022-03-28 20:50 ` Sakari Ailus
2022-04-07 16:25 ` Hugues FRUCHET - FOSS
2022-04-08 11:05 ` Sakari Ailus
2022-04-26 12:32 ` Hugues FRUCHET - FOSS
2022-04-07 16:24 ` Hugues FRUCHET - FOSS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjrhXefKYaPdx55B@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=Eugen.Hristev@microchip.com \
--cc=aford173@gmail.com \
--cc=festevam@gmail.com \
--cc=hugues.fruchet@st.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=jbrunet@baylibre.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mirela.rabulea@nxp.com \
--cc=paul.elder@ideasonboard.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sakari.ailus@iki.fi \
--cc=slongerbeam@gmail.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=xavier.roumegue@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox