From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2D82C433F5 for ; Sat, 2 Apr 2022 11:35:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354691AbiDBLhc (ORCPT ); Sat, 2 Apr 2022 07:37:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231430AbiDBLhc (ORCPT ); Sat, 2 Apr 2022 07:37:32 -0400 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C6B2B84F for ; Sat, 2 Apr 2022 04:35:40 -0700 (PDT) Received: by mail-oi1-x22c.google.com with SMTP id q189so5278944oia.9 for ; Sat, 02 Apr 2022 04:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tVmxAeV6jn1gWoncdeIJ5il6g0CdD+Hlq/EJxdUklqE=; b=LX19uD64aLiDbq3sb546SA4HLqf42Hkj/oUycVdKLmFoJECd+hM13ExfTEaEPnp2PL 2KZsm7KZk4HZb4V+xwi5sbfA3JGGZAX/D+5SNk5btOtJHf6uT2RR2ULjb9KlhkpTm7F1 XmYasU+20jlkyQ0EDlHndJu7lWkehb+9JOLlXJR+9yBBR/4B/DXXKmS+W3m9YHlsMfu8 HgFtjrjGD7qNUTQvhYOFhghbbKH1dmjzRDvPikJLUswtPre+XZwrflCzE+GrbkHD0fQQ 7uG76GGsFNZqmVKV/uVkn7FJqv/mI5i/aCUVRxso0YK5hffxgs/0UvtsF7kncaawG2GU INQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tVmxAeV6jn1gWoncdeIJ5il6g0CdD+Hlq/EJxdUklqE=; b=2067e9ZcYwc5ynm8TLMtoFzPvLSuPpsPlFnzWl/FNDCrItaZh1pmjmrmfGQ5/oBsg3 9IjhSBJpuZiGbFIULMwLuYxfQs9MSVKP57RU9ao8KRE1evVftS53V4FICQmDT6MeBfjL wgrV451PL55G2b3uQ0SrW0EPOKpXt8Rw8/lMerS693pkxSwW8EGOIwsbvIR5WDiw0Hsg /xjXYWmt/es+S1Az8uvv1Xs6YZrehoKItlxRD1nkRr7/CWWOZlZUUHUUhaOGnLfvkGI+ i4Jlyo+BfTfYQKEF73MlH0dDUsYK084Aab4vHHyWa2OH4ry35KZKkRLO02ZyZKnewDco KSmw== X-Gm-Message-State: AOAM530J2lXmryOTx5msq4meZwLbABg9uygB2PD40/rujfOTzZKgDVxt oVTjkY45hJriAofhqR3cLNT5Fw== X-Google-Smtp-Source: ABdhPJwxMUnytlHFsdF6Bum7FoSq6ZYIQ0IJaVahiou9heXHf6ka4kyt7XPFCWoOXG6HgpUNyhO1og== X-Received: by 2002:a05:6808:120e:b0:2f8:6db8:afa0 with SMTP id a14-20020a056808120e00b002f86db8afa0mr6338394oil.283.1648899339624; Sat, 02 Apr 2022 04:35:39 -0700 (PDT) Received: from eze-laptop ([2803:9800:98c2:8470:9f4:8e2a:88e5:ec01]) by smtp.gmail.com with ESMTPSA id b188-20020aca34c5000000b002da579c994dsm1998072oia.31.2022.04.02.04.35.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Apr 2022 04:35:39 -0700 (PDT) Date: Sat, 2 Apr 2022 08:35:33 -0300 From: Ezequiel Garcia To: Nicolas Dufresne Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , kernel@collabora.com, Sebastian Fricke , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 17/23] media: rkvdec: Enable capture buffer holding for H264 Message-ID: References: <20220331193726.289559-1-nicolas.dufresne@collabora.com> <20220331193726.289559-18-nicolas.dufresne@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220331193726.289559-18-nicolas.dufresne@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, Mar 31, 2022 at 03:37:19PM -0400, Nicolas Dufresne wrote: > In order to support interlaced video decoding, the driver must > allow holding the capture buffer so that the second field can > be decoded into it. > > Signed-off-by: Nicolas Dufresne > Reviewed-by: Sebastian Fricke IMO, this patch (and the similar one for Hantro) should come after interlaced support is added. Thanks, Ezequiel > --- > drivers/staging/media/rkvdec/rkvdec.c | 4 ++++ > drivers/staging/media/rkvdec/rkvdec.h | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c > index 1b805710e195..b6376eaa92d7 100644 > --- a/drivers/staging/media/rkvdec/rkvdec.c > +++ b/drivers/staging/media/rkvdec/rkvdec.c > @@ -148,6 +148,7 @@ static const struct rkvdec_coded_fmt_desc rkvdec_coded_fmts[] = { > .ops = &rkvdec_h264_fmt_ops, > .num_decoded_fmts = ARRAY_SIZE(rkvdec_h264_vp9_decoded_fmts), > .decoded_fmts = rkvdec_h264_vp9_decoded_fmts, > + .subsystem_flags = VB2_V4L2_FL_SUPPORTS_M2M_HOLD_CAPTURE_BUF, > }, > { > .fourcc = V4L2_PIX_FMT_VP9_FRAME, > @@ -404,6 +405,9 @@ static int rkvdec_s_output_fmt(struct file *file, void *priv, > cap_fmt->fmt.pix_mp.ycbcr_enc = f->fmt.pix_mp.ycbcr_enc; > cap_fmt->fmt.pix_mp.quantization = f->fmt.pix_mp.quantization; > > + /* Enable format specific queue features */ > + vq->subsystem_flags |= desc->subsystem_flags; > + > return 0; > } > > diff --git a/drivers/staging/media/rkvdec/rkvdec.h b/drivers/staging/media/rkvdec/rkvdec.h > index 2f4ea1786b93..e37f1a015fa0 100644 > --- a/drivers/staging/media/rkvdec/rkvdec.h > +++ b/drivers/staging/media/rkvdec/rkvdec.h > @@ -81,6 +81,7 @@ struct rkvdec_coded_fmt_desc { > const struct rkvdec_coded_fmt_ops *ops; > unsigned int num_decoded_fmts; > const u32 *decoded_fmts; > + u32 subsystem_flags; > }; > > struct rkvdec_dev { > -- > 2.34.1 >