From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EB4BC43217 for ; Sat, 2 Apr 2022 10:52:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354568AbiDBKye (ORCPT ); Sat, 2 Apr 2022 06:54:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354537AbiDBKyX (ORCPT ); Sat, 2 Apr 2022 06:54:23 -0400 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 584E91456F0 for ; Sat, 2 Apr 2022 03:52:27 -0700 (PDT) Received: by mail-oi1-x230.google.com with SMTP id i7so5227633oie.7 for ; Sat, 02 Apr 2022 03:52:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ey9vgHYF15jaDHDhev6v9T/d9GPKBVHQu6Tqb5CYYyM=; b=HSIAyb6agxiQlPpmDhu5VUFC8W6axguHYuWiQ1YjcJSUXFQG0Klku8VYjsWDOE1iK8 SiaSwjmRfSzwGXb/YRwSXmKS9k9c5AQNI06TWQNPKAwbCqc9H2b6ujVz6aUZjAlzL+kN 59GwFhWpv7ENyIQlv9nXdHYlHdOYL8WhuNF76Gbmnwypuq7t4h9piSmTuVifU4/GciDG U9eNehQlBIE+6GRNJHpAMDaPJU76XB0K8bcpm6RweE6DOcvLSNJu2gNSX62rtiBckmKY eUFRHqNv4kcD7FaGaigSnEb94x3FkF+t4HOEm2GoXli39nwcVGGd8JUE7fig4iFPYq4Z Tb3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ey9vgHYF15jaDHDhev6v9T/d9GPKBVHQu6Tqb5CYYyM=; b=EsFZkWj1snNZQ1k7JMFtTiPi7AyoK6TnaDIQnf9Wman0Rf0ouSytBzSzKPp8/NxoEP 6QvCg3fasI5qRu2AVP1aE1D+ahBEg2cUw/VKa6qexCfstnFG9xoH6lJhk2IS8YGbIxQc jcCXbQDItLlBmBpMSQEUuR3NP3A0E0kzGNvvQE9j2AyVmwRo0yBP62SpY7Q7d3DOEqM4 WGrwPcgGVMtRtTHvJ6lYS2Zzbh80HYVob2iU1xGlrB/F2BstEzLluFw6JKvd4a8RibIP YCO2xglDfGwz1vDatrDTNULjIhVwFyh0/f7bqCnO7rjWr/3oDTFjeb4tLLm1/2rIGx2T XtwQ== X-Gm-Message-State: AOAM533Qacc3J30hRYzoqM1atatJM7xpz0qw0FqbtnsaDGdg1+9NHngL pmUzJtjutb+aFzmTDf/gfriIZA== X-Google-Smtp-Source: ABdhPJzAojYVGGVf2DMiQ6Yncl14J2QRw60j6diHXtf/kKGVIcqcwAN8wNu/oR/IqF6/57Pz9/oMog== X-Received: by 2002:a05:6808:1992:b0:2da:7ea7:7ef8 with SMTP id bj18-20020a056808199200b002da7ea77ef8mr6395564oib.49.1648896746687; Sat, 02 Apr 2022 03:52:26 -0700 (PDT) Received: from eze-laptop ([2803:9800:98c2:8470:9f4:8e2a:88e5:ec01]) by smtp.gmail.com with ESMTPSA id 20-20020a05687010d400b000de9c6d81e3sm2015920oar.58.2022.04.02.03.52.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Apr 2022 03:52:25 -0700 (PDT) Date: Sat, 2 Apr 2022 07:52:20 -0300 From: Ezequiel Garcia To: Nicolas Dufresne Cc: Tomasz Figa , Marek Szyprowski , Mauro Carvalho Chehab , kernel@collabora.com, Sebastian Fricke , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 03/23] media: videobuf2-v4l2: Warn on holding buffers without support Message-ID: References: <20220331193726.289559-1-nicolas.dufresne@collabora.com> <20220331193726.289559-4-nicolas.dufresne@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220331193726.289559-4-nicolas.dufresne@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, Mar 31, 2022 at 03:37:05PM -0400, Nicolas Dufresne wrote: > From: Sebastian Fricke > > Using V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF flag without specifying the > subsystem flag VB2_V4L2_FL_SUPPORTS_M2M_HOLD_CAPTURE_BUF, results in > silently ignoring it. > Warn the user via a debug print when the flag is requested but ignored > by the videobuf2 framework. > > Signed-off-by: Sebastian Fricke > Signed-off-by: Nicolas Dufresne Reviewed-by: Ezequiel Garcia > --- > drivers/media/common/videobuf2/videobuf2-v4l2.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c b/drivers/media/common/videobuf2/videobuf2-v4l2.c > index 6edf4508c636..812c8d1962e0 100644 > --- a/drivers/media/common/videobuf2/videobuf2-v4l2.c > +++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c > @@ -329,8 +329,13 @@ static int vb2_fill_vb2_v4l2_buffer(struct vb2_buffer *vb, struct v4l2_buffer *b > */ > vbuf->flags &= ~V4L2_BUF_FLAG_TIMECODE; > vbuf->field = b->field; > - if (!(q->subsystem_flags & VB2_V4L2_FL_SUPPORTS_M2M_HOLD_CAPTURE_BUF)) > + if (!(q->subsystem_flags & VB2_V4L2_FL_SUPPORTS_M2M_HOLD_CAPTURE_BUF)) { > + if (vbuf->flags & V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF) > + dprintk(q, 1, > + "Request holding buffer (%d), unsupported on output queue\n", > + b->index); > vbuf->flags &= ~V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF; > + } > } else { > /* Zero any output buffer flags as this is a capture buffer */ > vbuf->flags &= ~V4L2_BUFFER_OUT_FLAGS; > -- > 2.34.1 >