From: Ian Cowan <ian@linux.cowan.aero>
To: LABBE Corentin <clabbe@baylibre.com>
Cc: mchehab@kernel.org, gregkh@linuxfoundation.org,
dan.carpenter@oracle.com, mjpeg-users@lists.sourceforge.net,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH 1/4] staging: media: zoran: add zrdev_dbg() macros
Date: Sun, 24 Apr 2022 21:22:30 -0400 [thread overview]
Message-ID: <YmX31vg+lCx6rsKF@fedora> (raw)
In-Reply-To: <YmWiQsrPj0uIpZ7w@Red>
On Sun, Apr 24, 2022 at 09:17:22PM +0200, LABBE Corentin wrote:
> Hello
>
> Thanks for your patchs, removing dprintk is a good idea.
> Please use pci_xxx() instead of dev_xxx() to be consistent with the rest of the driver.
> The comment title is misleading, zrdev_err is not about debugging. What about Logging macros ?
>
> Regards
>
I have made those modifications, and I will resubmit patches 1 and 2
shortly. Those are the only patches that affected by this change; 3 and
4 will not change.
Thanks,
Ian
next prev parent reply other threads:[~2022-04-25 1:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 5:17 [PATCH 1/4] staging: media: zoran: add zrdev_dbg() macros Ian Cowan
2022-04-24 19:17 ` LABBE Corentin
2022-04-25 1:22 ` Ian Cowan [this message]
2022-04-25 4:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmX31vg+lCx6rsKF@fedora \
--to=ian@linux.cowan.aero \
--cc=clabbe@baylibre.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mjpeg-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox