From: Sakari Ailus <sakari.ailus@iki.fi>
To: Jacopo Mondi <jacopo@jmondi.org>
Cc: Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>,
krzysztof.kozlowski@canonical.com,
jeanmichel.hautbois@ideasonboard.com,
laurent.pinchart@ideasonboard.com, paul.kocialkowski@bootlin.com,
paul.elder@ideasonboard.com,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"open list:OMNIVISION OV5670 SENSOR DRIVER"
<linux-media@vger.kernel.org>
Subject: Re: [PATCH v3 6/8] media: i2c: ov5670: Add runtime_pm operations
Date: Wed, 27 Apr 2022 12:59:24 +0300 [thread overview]
Message-ID: <YmkT/I4yJ0ddawsx@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <YmkTfLMdtMQDBQFO@valkosipuli.retiisi.eu>
On Wed, Apr 27, 2022 at 12:57:16PM +0300, Sakari Ailus wrote:
> > + ret = pm_runtime_resume_and_get(&client->dev);
>
> Please see how e.g. the CCS driver does this (no need for autosuspend
> though). E.g. don't use runtime PM to power the sensor on in probe, or off
> in remove.
What's actually needed in this driver would be explicit use of the resume
and suspend callbacks for !CONFIG_PM as well as setting the callbacks in
ov5670_pm_ops. No other changes should be needed.
--
Sakari Ailus
next prev parent reply other threads:[~2022-04-27 10:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 9:01 [PATCH v3 0/8] media: i2c: ov5670: OF support, runtime_pm, regulators Jacopo Mondi
2022-03-29 9:01 ` [PATCH v3 1/8] media: dt-bindings: i2c: Document ov5670 Jacopo Mondi
2022-03-29 9:01 ` [PATCH v3 2/8] media: i2c: ov5670: Allow probing with OF Jacopo Mondi
2022-03-30 5:30 ` Sakari Ailus
2022-03-29 9:01 ` [PATCH v3 3/8] media: i2c: ov5670: Probe clocks " Jacopo Mondi
2022-03-30 5:31 ` Sakari Ailus
2022-03-29 9:01 ` [PATCH v3 4/8] media: i2c: ov5670: Probe regulators Jacopo Mondi
2022-03-29 9:01 ` [PATCH v3 5/8] media: i2c: ov5670: Probe GPIOs Jacopo Mondi
2022-03-29 9:01 ` [PATCH v3 6/8] media: i2c: ov5670: Add runtime_pm operations Jacopo Mondi
2022-03-31 10:08 ` Sakari Ailus
2022-03-31 10:33 ` Laurent Pinchart
2022-03-31 12:34 ` Sakari Ailus
2022-04-27 9:57 ` Sakari Ailus
2022-04-27 9:59 ` Sakari Ailus [this message]
2022-03-29 9:01 ` [PATCH v3 7/8] media: i2c: ov5670: Implement init_cfg Jacopo Mondi
2022-03-30 5:33 ` Sakari Ailus
2022-03-29 9:01 ` [PATCH v3 8/8] media: i2c: ov5670: Add .get_selection() support Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmkT/I4yJ0ddawsx@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=chiranjeevi.rapolu@intel.com \
--cc=jacopo@jmondi.org \
--cc=jeanmichel.hautbois@ideasonboard.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.elder@ideasonboard.com \
--cc=paul.kocialkowski@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox