From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F5F7C433F5 for ; Fri, 13 May 2022 16:20:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382340AbiEMQUZ (ORCPT ); Fri, 13 May 2022 12:20:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352775AbiEMQUZ (ORCPT ); Fri, 13 May 2022 12:20:25 -0400 Received: from gofer.mess.org (gofer.mess.org [88.97.38.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DF7625E7 for ; Fri, 13 May 2022 09:20:23 -0700 (PDT) Received: by gofer.mess.org (Postfix, from userid 1000) id ADF73101BDF; Fri, 13 May 2022 17:20:21 +0100 (BST) Date: Fri, 13 May 2022 17:20:21 +0100 From: Sean Young To: Oliver Neukum Cc: linux-media@vger.kernel.org, mchehab@kernel.org Subject: Re: [PATCH 1/4] igorplugusb: respect DMA coherency Message-ID: References: <20220512123849.25903-1-oneukum@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220512123849.25903-1-oneukum@suse.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, May 12, 2022 at 02:38:46PM +0200, Oliver Neukum wrote: > The coherency rules mean that you cannot embed > a buffer inside a descriptor. kmalloc() separately. I've merged this series to my tree. Thanks! Sean > > Signed-off-by: Oliver Neukum > --- > drivers/media/rc/igorplugusb.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/rc/igorplugusb.c b/drivers/media/rc/igorplugusb.c > index b40dbf500186..b46362da8623 100644 > --- a/drivers/media/rc/igorplugusb.c > +++ b/drivers/media/rc/igorplugusb.c > @@ -38,7 +38,7 @@ struct igorplugusb { > > struct timer_list timer; > > - uint8_t buf_in[MAX_PACKET]; > + u8 *buf_in; > > char phys[64]; > }; > @@ -177,6 +177,9 @@ static int igorplugusb_probe(struct usb_interface *intf, > if (!ir->urb) > goto fail; > > + ir->buf_in = kmalloc(MAX_PACKET, GFP_KERNEL); > + if (!ir->buf_in) > + goto fail; > usb_fill_control_urb(ir->urb, udev, > usb_rcvctrlpipe(udev, 0), (uint8_t *)&ir->request, > ir->buf_in, sizeof(ir->buf_in), igorplugusb_callback, ir); > @@ -223,6 +226,7 @@ static int igorplugusb_probe(struct usb_interface *intf, > rc_free_device(ir->rc); > usb_free_urb(ir->urb); > del_timer(&ir->timer); > + kfree(ir->buf_in); > > return ret; > } > @@ -236,6 +240,7 @@ static void igorplugusb_disconnect(struct usb_interface *intf) > usb_set_intfdata(intf, NULL); > usb_kill_urb(ir->urb); > usb_free_urb(ir->urb); > + kfree(ir->buf_in); > } > > static const struct usb_device_id igorplugusb_table[] = { > -- > 2.35.3