From: Sean Young <sean@mess.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: linux-media@vger.kernel.org, mchehab@kernel.org
Subject: Re: [PATCH] iguanair: no superfluous usb_unlink_urb()
Date: Fri, 13 May 2022 17:20:41 +0100 [thread overview]
Message-ID: <Yn6FWePGyTw+QwRH@gofer.mess.org> (raw)
In-Reply-To: <20220512125000.8340-1-oneukum@suse.com>
On Thu, May 12, 2022 at 02:50:00PM +0200, Oliver Neukum wrote:
> Unlinking yourself while the completion handler
> is running is a NOP. Drop it.
Applied, thanks!
Sean
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---
> drivers/media/rc/iguanair.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c
> index c9cb8277723f..276bf3c8a8cb 100644
> --- a/drivers/media/rc/iguanair.c
> +++ b/drivers/media/rc/iguanair.c
> @@ -149,10 +149,8 @@ static void iguanair_rx(struct urb *urb)
> return;
>
> ir = urb->context;
> - if (!ir) {
> - usb_unlink_urb(urb);
> + if (!ir)
> return;
> - }
>
> switch (urb->status) {
> case 0:
> @@ -161,7 +159,6 @@ static void iguanair_rx(struct urb *urb)
> case -ECONNRESET:
> case -ENOENT:
> case -ESHUTDOWN:
> - usb_unlink_urb(urb);
> return;
> case -EPIPE:
> default:
> --
> 2.35.3
prev parent reply other threads:[~2022-05-13 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 12:50 [PATCH] iguanair: no superfluous usb_unlink_urb() Oliver Neukum
2022-05-13 16:20 ` Sean Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yn6FWePGyTw+QwRH@gofer.mess.org \
--to=sean@mess.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox