From: Sean Young <sean@mess.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: linux-media@vger.kernel.org, mchehab@kernel.org
Subject: Re: [PATCH] imon_raw: respect DMA coherency
Date: Mon, 16 May 2022 17:40:46 +0100 [thread overview]
Message-ID: <YoJ+jhKDxUokK207@gofer.mess.org> (raw)
In-Reply-To: <2c6478af-6247-0cbf-8761-7ca288522f7f@suse.com>
On Mon, May 16, 2022 at 01:00:30PM +0200, Oliver Neukum wrote:
> On 13.05.22 18:23, Sean Young wrote:
> Hi!
> > On Thu, May 12, 2022 at 03:03:21PM +0200, Oliver Neukum wrote:
> >> No buffer can be embedded inside a descriptor, not even a simple be64.
> >> Use a separate kmalloc()
> > This patch needs a tiny change from be64_to_cpu() to be64_to_cpup(), I've
> > tested that change with the hardware.
> Needs? It is certainly not wrong and the subsequent logging will be in the
> converted order, but need
It certainly is wrong, and it doesn't compile without it, so yes it does
need it. The kernel test robot also complained about.
Thanks
Sean
next prev parent reply other threads:[~2022-05-16 16:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 13:03 [PATCH] imon_raw: respect DMA coherency Oliver Neukum
2022-05-12 17:59 ` kernel test robot
2022-05-12 19:02 ` kernel test robot
2022-05-13 4:40 ` kernel test robot
2022-05-13 16:23 ` Sean Young
2022-05-16 11:00 ` Oliver Neukum
2022-05-16 16:40 ` Sean Young [this message]
2022-05-17 7:34 ` Oliver Neukum
2022-05-17 7:42 ` Sean Young
2022-05-17 8:28 ` Oliver Neukum
2022-05-17 10:45 ` Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoJ+jhKDxUokK207@gofer.mess.org \
--to=sean@mess.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox