From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 437BAC433F5 for ; Mon, 16 May 2022 16:40:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236213AbiEPQkx (ORCPT ); Mon, 16 May 2022 12:40:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343742AbiEPQku (ORCPT ); Mon, 16 May 2022 12:40:50 -0400 Received: from gofer.mess.org (gofer.mess.org [IPv6:2a02:8011:d000:212::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8928E6553 for ; Mon, 16 May 2022 09:40:48 -0700 (PDT) Received: by gofer.mess.org (Postfix, from userid 1000) id C60A6101BE5; Mon, 16 May 2022 17:40:46 +0100 (BST) Date: Mon, 16 May 2022 17:40:46 +0100 From: Sean Young To: Oliver Neukum Cc: linux-media@vger.kernel.org, mchehab@kernel.org Subject: Re: [PATCH] imon_raw: respect DMA coherency Message-ID: References: <20220512130321.30599-1-oneukum@suse.com> <2c6478af-6247-0cbf-8761-7ca288522f7f@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2c6478af-6247-0cbf-8761-7ca288522f7f@suse.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, May 16, 2022 at 01:00:30PM +0200, Oliver Neukum wrote: > On 13.05.22 18:23, Sean Young wrote: > Hi! > > On Thu, May 12, 2022 at 03:03:21PM +0200, Oliver Neukum wrote: > >> No buffer can be embedded inside a descriptor, not even a simple be64. > >> Use a separate kmalloc() > > This patch needs a tiny change from be64_to_cpu() to be64_to_cpup(), I've > > tested that change with the hardware. > Needs? It is certainly not wrong and the subsequent logging will be in the > converted order, but need It certainly is wrong, and it doesn't compile without it, so yes it does need it. The kernel test robot also complained about. Thanks Sean